New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 679931 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature



Sign in to add a comment

Provide an API to query build history

Project Member Reported by st...@chromium.org, Jan 11 2017

Issue description

Given a build id on a specific build config (master name and builder name on buildbot; bucket name and builder name on Luci?), Findit needs an API to query previous builds.
 

Comment 1 by estaab@chromium.org, Jan 12 2017

What does a build config mean in this case? Previous builds are available from master and builder name.

Comment 2 by st...@chromium.org, Jan 12 2017

(sorry for the unclear description)

A build config means the combination of master name and builder name.

Currently on buildbot, there is build number, so we could use master/builder and build number to query previous builds.

After migration to Luci, per discussion with iannucci@, the concept of build number will be gone and build id (a uuid or hash?) will be in place. So we need a new mechanism to go from one build to its previous build.
Is an API already existing?

Comment 3 by st...@chromium.org, Jan 12 2017

Description: Show this description

Comment 4 by st...@chromium.org, Jan 12 2017

Cc: chanli@chromium.org lijeffrey@chromium.org
Labels: Pri-2
If this is really a Pri-1, find an owner and update the priority.

This is the result of a bulk edit that moved high priority available bugs to a lower priority in an attempt to be more honest with bug filers.
Project Member

Comment 6 by bugdroid1@chromium.org, Apr 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/external/github.com/luci/luci-go.git/+/9fb9880d65325cef1fd8ff4099a1de27b4bf684e

commit 9fb9880d65325cef1fd8ff4099a1de27b4bf684e
Author: hinoka <hinoka@google.com>
Date: Thu Apr 20 22:17:27 2017

Milo buildbot builder page: Add pagnation with cursors.

In the UI, backward pages are implemented via memcache, just like luci scheduler
In the API, backward pages are not supported

Note that for the most part we operate around pointers to cursors, to store the state that "the cursor does not exist", ie the end of the query has been reached.

BUG= 679931 , 700263 

Review-Url: https://codereview.chromium.org/2810113002

[modify] https://crrev.com/9fb9880d65325cef1fd8ff4099a1de27b4bf684e/milo/api/proto/buildbot.pb.go
[modify] https://crrev.com/9fb9880d65325cef1fd8ff4099a1de27b4bf684e/milo/api/proto/buildbot.proto
[modify] https://crrev.com/9fb9880d65325cef1fd8ff4099a1de27b4bf684e/milo/api/proto/pb.discovery.go
[modify] https://crrev.com/9fb9880d65325cef1fd8ff4099a1de27b4bf684e/milo/api/resp/builder.go
[modify] https://crrev.com/9fb9880d65325cef1fd8ff4099a1de27b4bf684e/milo/appengine/buildbot/builder.go
[modify] https://crrev.com/9fb9880d65325cef1fd8ff4099a1de27b4bf684e/milo/appengine/buildbot/console.go
[modify] https://crrev.com/9fb9880d65325cef1fd8ff4099a1de27b4bf684e/milo/appengine/buildbot/datastore.go
[modify] https://crrev.com/9fb9880d65325cef1fd8ff4099a1de27b4bf684e/milo/appengine/buildbot/grpc.go
[modify] https://crrev.com/9fb9880d65325cef1fd8ff4099a1de27b4bf684e/milo/appengine/buildbot/html.go
[modify] https://crrev.com/9fb9880d65325cef1fd8ff4099a1de27b4bf684e/milo/appengine/common/funcs.go
[modify] https://crrev.com/9fb9880d65325cef1fd8ff4099a1de27b4bf684e/milo/appengine/common/middleware.go
[modify] https://crrev.com/9fb9880d65325cef1fd8ff4099a1de27b4bf684e/milo/appengine/frontend/expectations/buildbot.builder-Basic_Test_no_builds.html
[modify] https://crrev.com/9fb9880d65325cef1fd8ff4099a1de27b4bf684e/milo/appengine/frontend/expectations/buildbot.builder-Basic_Test_with_builds.html
[modify] https://crrev.com/9fb9880d65325cef1fd8ff4099a1de27b4bf684e/milo/appengine/frontend/templates/pages/builder.html

Comment 7 by no...@chromium.org, Apr 21 2017

Components: -Infra>Platform>Milo Infra>Platform>Buildbucket
Status: Fixed (was: Available)
buildbucket search API can be used to query build history in LUCI. This is where Milo loads builds from.

This applies to waterfalls too, but we didn't migrate any waterfalls to buildbucket yet.

This request looks already fulfilled to me, so marking as fixed.

Comment 8 by no...@chromium.org, Apr 21 2017

Labels: -Type-Bug Type-Feature

Sign in to add a comment