New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 679911 link

Starred by 1 user
Status: Fixed
Owner:
█ roc...@chromium.org
please use my google.com address
Closed: Jan 2017
Cc:
altimin@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Blink V8 initialization incorrectly assumes a scheduler

Project Member Reported by roc...@chromium.org, Jan 10 2017 
A recent change (https://codereview.chromium.org/2589363003) introduced the assumption that the current blink::Platform implementation must provide a non-null scheduler. However, UtilityThreadImpl initializes Blink with a Platform impl that does not provide a scheduler.

We need to either correct the assumption, or provide a scheduler in utility processes.
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 11 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7b9e6bc428d965901cec2999f5ed0933b81bdd29

commit 7b9e6bc428d965901cec2999f5ed0933b81bdd29
Author: rockot <rockot@chromium.org>
Date: Wed Jan 11 14:47:46 2017

Tolerate a null scheduler in V8 initialization

Some utility processes need to initailize Blink and V8, and V8
initialization now assumes the main thread provides a scheduler; but
a utility process' main thread does not in fact provide one.

This eliminates the recently introduced assumption of a non-null scheduler,
defaulting to the previous behavior (using the current ThreadTaskRunnerHandle)
when no scheduler is provided.

BUG= 679911 
R=jochen@chromium.org

Review-Url: https://codereview.chromium.org/2624033002
Cr-Commit-Position: refs/heads/master@{#442901}

[modify] https://crrev.com/7b9e6bc428d965901cec2999f5ed0933b81bdd29/gin/per_isolate_data.cc
[modify] https://crrev.com/7b9e6bc428d965901cec2999f5ed0933b81bdd29/third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp
[modify] https://crrev.com/7b9e6bc428d965901cec2999f5ed0933b81bdd29/third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.cpp

Comment 2 by roc...@chromium.org, Jan 11 2017

Status: Fixed (was: Started)
►

Sign in to add a comment