New issue
Advanced search Search tips

Issue 679907 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 1
Type: Bug



Sign in to add a comment

Keep track of whether a certificate report has been sent via retry

Project Member Reported by est...@chromium.org, Jan 10 2017

Issue description

Report retry will likely give us lots of new types of errors, which could skew the percentages we track for existing types of errors. Add a boolean field to certificate reports that is set whenever a report is retried.
 

Comment 1 by est...@chromium.org, Jan 10 2017

Labels: -Pri-3 M-57 Pri-1
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c9b9670bc2ea41eeb69175f90771f6f034673e48

commit c9b9670bc2ea41eeb69175f90771f6f034673e48
Author: meacer <meacer@chromium.org>
Date: Wed Jan 18 01:36:11 2017

Add retry information to certificate reports.

This CL adds a is_retry_upload to CertLoggerRequest proto that's set to
false by default. When a certificate report upload fails and is retried
for a second time, the flag is set to true. This will help identify new
certificate reports that are now being observed because of the report
retry feature.

BUG= 679907 

Review-Url: https://codereview.chromium.org/2632533002
Cr-Commit-Position: refs/heads/master@{#444232}

[modify] https://crrev.com/c9b9670bc2ea41eeb69175f90771f6f034673e48/chrome/browser/safe_browsing/certificate_reporting_service.cc
[modify] https://crrev.com/c9b9670bc2ea41eeb69175f90771f6f034673e48/chrome/browser/safe_browsing/certificate_reporting_service.h
[modify] https://crrev.com/c9b9670bc2ea41eeb69175f90771f6f034673e48/chrome/browser/safe_browsing/certificate_reporting_service_browsertest.cc
[modify] https://crrev.com/c9b9670bc2ea41eeb69175f90771f6f034673e48/chrome/browser/safe_browsing/certificate_reporting_service_test_utils.cc
[modify] https://crrev.com/c9b9670bc2ea41eeb69175f90771f6f034673e48/chrome/browser/safe_browsing/certificate_reporting_service_test_utils.h
[modify] https://crrev.com/c9b9670bc2ea41eeb69175f90771f6f034673e48/chrome/browser/safe_browsing/certificate_reporting_service_unittest.cc
[modify] https://crrev.com/c9b9670bc2ea41eeb69175f90771f6f034673e48/components/certificate_reporting/cert_logger.proto
[modify] https://crrev.com/c9b9670bc2ea41eeb69175f90771f6f034673e48/components/certificate_reporting/error_report.cc
[modify] https://crrev.com/c9b9670bc2ea41eeb69175f90771f6f034673e48/components/certificate_reporting/error_report.h

Comment 3 by mea...@chromium.org, Jan 18 2017

Status: Fixed (was: Assigned)
b/34361668 for server side changes.

Sign in to add a comment