Client callback for CheckResourceUrl missing in v4_local_database_manager.cc |
||||||
Issue descriptionIn V4LocalDatabaseManager::RespondToClient(), there's a switch case statement for each type of client callback. It is missing the case for CHECK_RESOURCE_URL.
,
Jan 11 2017
,
Jan 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ff1a6112240cb285eab6a15a62419c2359b84ff5 commit ff1a6112240cb285eab6a15a62419c2359b84ff5 Author: vakh <vakh@chromium.org> Date: Thu Jan 12 01:00:16 2017 Add the missing callback to client for CheckResourceUrl. Also updated the test to check for the matching full hash in that case. BUG= 679906 Review-Url: https://codereview.chromium.org/2622063002 Cr-Commit-Position: refs/heads/master@{#443096} [modify] https://crrev.com/ff1a6112240cb285eab6a15a62419c2359b84ff5/components/safe_browsing_db/v4_local_database_manager.cc [modify] https://crrev.com/ff1a6112240cb285eab6a15a62419c2359b84ff5/components/safe_browsing_db/v4_local_database_manager.h [modify] https://crrev.com/ff1a6112240cb285eab6a15a62419c2359b84ff5/components/safe_browsing_db/v4_local_database_manager_unittest.cc
,
Jan 12 2017
Requesting merge in M56 since: 1. this is a small local patch 2. Is Finch controlled 3. Finch experiment is not enabled in Stable (yet).
,
Jan 12 2017
The CL for merging to M56 is here: http://crrev.com/2629713002 I'll land it only if it gets approved for merge.
,
Jan 13 2017
Your change meets the bar and is auto-approved for M56. Please go ahead and merge the CL manually. Please contact milestone owner if you have questions. Owners: amineer@(clank), cmasso@(bling), gkihumba@(cros), bustamante@(desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jan 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e3870de98715fb276dee10831a43efe98a2523ff commit e3870de98715fb276dee10831a43efe98a2523ff Author: vakh <vakh@chromium.org> Date: Fri Jan 13 03:22:05 2017 [M56] Add the missing callback to client for CheckResourceUrl Merges http://crrev.com/2622063002 to M56. NOTRY=true NOPRESUBMIT=true BUG= 679906 Review-Url: https://codereview.chromium.org/2629713002 Cr-Commit-Position: refs/branch-heads/2924@{#757} Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059} [modify] https://crrev.com/e3870de98715fb276dee10831a43efe98a2523ff/components/safe_browsing_db/v4_local_database_manager.cc [modify] https://crrev.com/e3870de98715fb276dee10831a43efe98a2523ff/components/safe_browsing_db/v4_local_database_manager.h [modify] https://crrev.com/e3870de98715fb276dee10831a43efe98a2523ff/components/safe_browsing_db/v4_local_database_manager_unittest.cc
,
Jan 13 2017
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by vakh@chromium.org
, Jan 10 2017