Autotest Parameterized job infrastructure is now dead
Reported by
jrbarnette@chromium.org,
Jan 10 2017
|
||||||||
Issue descriptionThe Autotest RPC call create_parameterized_job() is now unused in the source base. This call, and the small raft of code it depends on should be removed. The root of the tree of dead code starts in frontend/afe/rpc_interface.py, with create_parameterized_job(). Deleting that code will also cause other code under frontend/afe/models.py to become dead as well. Additionally the change means the parameterized_job_id column in the afe_jobs table becomes unused, and references to it can be deleted (the field should be treated as "always false or unset"). Additionally, this change should make frontend.afe.models.Kernel finally unnecessary, allowing additional cleanup.
,
Jan 10 2017
,
Jan 12 2017
Another item that will be made dead by deleting the
create_parameterized_job() RPC is the stuff under here:
client/site_tests/autoupdate_ParameterizedJob
,
Jan 17 2017
This would be dead, except that the CL that made it dead got reverted. So, we're stuck until that can re-land.
,
Mar 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/0ed607598403c8e757b64b8c92f02f6b13a3eaee commit 0ed607598403c8e757b64b8c92f02f6b13a3eaee Author: Richard Barnette <jrbarnette@chromium.org> Date: Thu Mar 02 21:20:49 2017 [autotest] Delete support for parameterized jobs. This deletes the `create_parameterized_job()` RPC endpoint and the associated (unused!) "parameterized_jobs" config setting. It also garbage collects code made unreferenced by these deletions. BUG= chromium:679903 TEST=unit tests, and run push_to_prod suite in a local instance Change-Id: I8ed683d0c8ffa879d0e10319b0a736133d56327e Reviewed-on: https://chromium-review.googlesource.com/436407 Commit-Ready: Richard Barnette <jrbarnette@chromium.org> Tested-by: Richard Barnette <jrbarnette@chromium.org> Reviewed-by: Richard Barnette <jrbarnette@google.com> [modify] https://crrev.com/0ed607598403c8e757b64b8c92f02f6b13a3eaee/frontend/afe/model_attributes.py [modify] https://crrev.com/0ed607598403c8e757b64b8c92f02f6b13a3eaee/frontend/afe/rpc_utils.py [modify] https://crrev.com/0ed607598403c8e757b64b8c92f02f6b13a3eaee/frontend/afe/frontend_test_utils.py [modify] https://crrev.com/0ed607598403c8e757b64b8c92f02f6b13a3eaee/frontend/frontend_unittest.py [modify] https://crrev.com/0ed607598403c8e757b64b8c92f02f6b13a3eaee/global_config.ini [modify] https://crrev.com/0ed607598403c8e757b64b8c92f02f6b13a3eaee/frontend/afe/models_test.py [modify] https://crrev.com/0ed607598403c8e757b64b8c92f02f6b13a3eaee/frontend/afe/rpc_interface_unittest.py [modify] https://crrev.com/0ed607598403c8e757b64b8c92f02f6b13a3eaee/frontend/afe/models.py [modify] https://crrev.com/0ed607598403c8e757b64b8c92f02f6b13a3eaee/frontend/afe/rpc_interface.py
,
Mar 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/2a56e2ed79a5e737ce2e830807f8778d862e6585 commit 2a56e2ed79a5e737ce2e830807f8778d862e6585 Author: Richard Barnette <jrbarnette@chromium.org> Date: Wed Mar 08 02:07:34 2017 [autotest] Remove UI dependencies on parameterized jobs. This removes the (small) UI dependencies on the 'parameterized_jobs' data field returned by the 'get_static_data' RPC. BUG= chromium:679903 TEST=Test the 'Create Job' button in the AFE UI. Change-Id: I859301f509ad32fd1a84fd4addd126383b591fd8 Reviewed-on: https://chromium-review.googlesource.com/450870 Commit-Ready: Richard Barnette <jrbarnette@chromium.org> Tested-by: Richard Barnette <jrbarnette@chromium.org> Reviewed-by: Michael Tang <ntang@chromium.org> Reviewed-by: Dan Shi <dshi@google.com> [modify] https://crrev.com/2a56e2ed79a5e737ce2e830807f8778d862e6585/frontend/client/src/autotest/afe/create/CreateJobViewPresenter.java
,
Mar 8 2017
,
Mar 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/b28def33556c59638a885cdc5710c9594c8fcd76 commit b28def33556c59638a885cdc5710c9594c8fcd76 Author: Richard Barnette <jrbarnette@chromium.org> Date: Sun Mar 12 05:21:31 2017 [autotest] Remove the 'parameterized_jobs' global config setting. This removes the 'parameterized_jobs' setting from global_config.ini, and the associated code that uses or tests the setting. BUG= chromium:679903 TEST=unit tests; test the 'Create Job' button in the AFE UI. Change-Id: I0846c0bc0f369d48cec7f71346c04961f8f52365 Reviewed-on: https://chromium-review.googlesource.com/450829 Commit-Ready: Richard Barnette <jrbarnette@chromium.org> Tested-by: Richard Barnette <jrbarnette@chromium.org> Reviewed-by: Allen Li <ayatane@chromium.org> Reviewed-by: Michael Tang <ntang@chromium.org> [modify] https://crrev.com/b28def33556c59638a885cdc5710c9594c8fcd76/frontend/frontend_unittest.py [modify] https://crrev.com/b28def33556c59638a885cdc5710c9594c8fcd76/frontend/afe/frontend_test_utils.py [modify] https://crrev.com/b28def33556c59638a885cdc5710c9594c8fcd76/global_config.ini [modify] https://crrev.com/b28def33556c59638a885cdc5710c9594c8fcd76/frontend/afe/models_test.py [modify] https://crrev.com/b28def33556c59638a885cdc5710c9594c8fcd76/frontend/afe/models.py [modify] https://crrev.com/b28def33556c59638a885cdc5710c9594c8fcd76/frontend/afe/rpc_interface.py
,
Mar 23 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/fddab4a620978bdb74c72299325fbe441e36977a commit fddab4a620978bdb74c72299325fbe441e36977a Author: Richard Barnette <jrbarnette@chromium.org> Date: Thu Mar 23 03:05:58 2017 [autotest] Delete support for parameterized jobs. This deletes the `create_parameterized_job()` RPC endpoint and the associated (unused!) "parameterized_jobs" config setting. It also garbage collects code made unreferenced by these deletions. BUG= chromium:679903 TEST=unit tests, and run push_to_prod suite in a local instance Change-Id: I0c02db8dcd4e8b0a8ac9649723eefffd31c95d82 Reviewed-on: https://chromium-review.googlesource.com/451838 Commit-Ready: Richard Barnette <jrbarnette@chromium.org> Tested-by: Richard Barnette <jrbarnette@chromium.org> Reviewed-by: Dan Shi <dshi@google.com> [modify] https://crrev.com/fddab4a620978bdb74c72299325fbe441e36977a/frontend/afe/model_attributes.py [modify] https://crrev.com/fddab4a620978bdb74c72299325fbe441e36977a/frontend/afe/rpc_utils.py [modify] https://crrev.com/fddab4a620978bdb74c72299325fbe441e36977a/frontend/afe/frontend_test_utils.py [modify] https://crrev.com/fddab4a620978bdb74c72299325fbe441e36977a/frontend/afe/models_test.py [modify] https://crrev.com/fddab4a620978bdb74c72299325fbe441e36977a/frontend/afe/rpc_interface_unittest.py [modify] https://crrev.com/fddab4a620978bdb74c72299325fbe441e36977a/frontend/afe/models.py [modify] https://crrev.com/fddab4a620978bdb74c72299325fbe441e36977a/frontend/afe/rpc_interface.py
,
Apr 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/06fb2c440eb9f8d37eba52386cfcd268489484a1 commit 06fb2c440eb9f8d37eba52386cfcd268489484a1 Author: Richard Barnette <jrbarnette@chromium.org> Date: Thu Apr 27 16:12:06 2017 [autotest] Remove UI dependencies on parameterized jobs. This removes the (small) UI dependencies on the 'parameterized_jobs' data field returned by the 'get_static_data' RPC. BUG= chromium:679903 TEST=Test the 'Create Job' button in the AFE UI. Change-Id: I859301f509ad32fd1a84fd4addd126383b591fd8 Reviewed-on: https://chromium-review.googlesource.com/450870 Commit-Ready: Richard Barnette <jrbarnette@chromium.org> Tested-by: Richard Barnette <jrbarnette@chromium.org> Reviewed-by: Michael Tang <ntang@chromium.org> Reviewed-by: Dan Shi <dshi@google.com> (cherry picked from commit 2a56e2ed79a5e737ce2e830807f8778d862e6585) Reviewed-on: https://chromium-review.googlesource.com/487740 Reviewed-by: Keith Haddow <haddowk@chromium.org> Commit-Queue: Keith Haddow <haddowk@chromium.org> Tested-by: Keith Haddow <haddowk@chromium.org> Trybot-Ready: Keith Haddow <haddowk@chromium.org> [modify] https://crrev.com/06fb2c440eb9f8d37eba52386cfcd268489484a1/frontend/client/src/autotest/afe/create/CreateJobViewPresenter.java
,
Apr 27 2017
Database schema changes are covered in a separate bug... I think everything else is done. So, let's declare victory.
,
Aug 1 2017
,
Jan 22 2018
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by jrbarnette@chromium.org
, Jan 10 2017