New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 679875 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Collect all test_args in an object and pass them all the way down to server_tests

Project Member Reported by pprabhu@chromium.org, Jan 10 2017

Issue description

Currently, server_job parses a whole bunch of arguments to autoserv and provides these to a server test control file via the namespace.

From there, the control file pulls out some of the data and manually passes it in to the server test's run_once method.

This is not extensible.
In preparation to making HostInfo available to the tests, we will create a TestArguments object
- This is created by the server_job,
- It is passed in to the control file through the namespace (and consolidates a bunch of globals currently passed in through the namespace)
- It is also passed in automagically to the server side tests' run_once method.


In particular,
- This object will contain the Host object that server side control files currently create in an ad-hoc method and then pass in to the tests.
- This will contain the afe_host object currently passed in via the machines dict.
- In the future, it will contain the HostInfoStore, which will replace the afe_host object passed in via the machines dict.
 
Labels: -current-issue
Milestones:
[1] 
- Create TestArguments to contain the Host object and the afe_host machine dict object.
- Instantiate TestArguments in server_job and provide it to control files via namespace.
- Change control files to use the Host object from TestArguments instead of creating their own via server/hosts/factory.py

[2]
- Automagically, optionally pass the TestArguments object to run_once
- change the tests that currently expect a host argument to expect a test_args instead.

[3]
- Change all tests to expect the test_args,
- Make test_args mandatory for run_once.
Status: WontFix (was: Started)
Took a different direction. This feature request is very stale.

Sign in to add a comment