New issue
Advanced search Search tips

Issue 679873 link

Starred by 1 user
Status: Fixed
Owner:
ericwilligers@chromium.org
Closed: Feb 2017
Cc:
style-bugs@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

Independent transform properties should support none

Project Member Reported by cbracefield@google.com, Jan 10 2017 
UserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/57.0.2970.0 Safari/537.36

Steps to reproduce the problem:
1. Enable Experimental Web Platform Features
2. Open https://jsfiddle.net/cbracefield/L9c32rq4/
3. 

What is the expected behavior?
Scale should be none

What went wrong?
Scale is 3 2

Did this work before? No 

Does this work in other browsers? Yes

Chrome version: 57.0.2970.0  Channel: dev
OS Version: 
Flash Version: 

https://drafts.csswg.org/css-transforms-2/#individual-transforms

Comment 1 by ericwilligers@chromium.org, Jan 10 2017

Owner: ericwilligers@chromium.org
Status: Started (was: Unconfirmed)
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 11 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/82f137db47aaedf2f741cd2615c735a1980dc7ce

commit 82f137db47aaedf2f741cd2615c735a1980dc7ce
Author: divyanshi <divyanshi@google.com>
Date: Wed Jan 11 23:19:21 2017

CSS: Scale support for none

The initial value for scale is none not 1
https://drafts.csswg.org/css-transforms-2/#individual-transforms

BUG= 679873 

Review-Url: https://codereview.chromium.org/2620263002
Cr-Commit-Position: refs/heads/master@{#443051}

[modify] https://crrev.com/82f137db47aaedf2f741cd2615c735a1980dc7ce/third_party/WebKit/LayoutTests/fast/css/getComputedStyle/computed-style-listing-expected.txt
[modify] https://crrev.com/82f137db47aaedf2f741cd2615c735a1980dc7ce/third_party/WebKit/LayoutTests/fast/css/getComputedStyle/computed-style-without-renderer-listing-expected.txt
[modify] https://crrev.com/82f137db47aaedf2f741cd2615c735a1980dc7ce/third_party/WebKit/LayoutTests/svg/css/getComputedStyle-listing-expected.txt
[modify] https://crrev.com/82f137db47aaedf2f741cd2615c735a1980dc7ce/third_party/WebKit/LayoutTests/transforms/scale-parsing.html
[modify] https://crrev.com/82f137db47aaedf2f741cd2615c735a1980dc7ce/third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp
[modify] https://crrev.com/82f137db47aaedf2f741cd2615c735a1980dc7ce/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp
[modify] https://crrev.com/82f137db47aaedf2f741cd2615c735a1980dc7ce/third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.cpp
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 24 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3deaebb8edf5fb2461d962efbfa6673f5669dacc

commit 3deaebb8edf5fb2461d962efbfa6673f5669dacc
Author: cbracefield <cbracefield@google.com>
Date: Tue Jan 24 06:04:54 2017

CSS: Translate support for none.

The initial value for translate is none not 0px.
https://drafts.csswg.org/css-transforms-2/#individual-transforms

BUG= 679873 

Review-Url: https://codereview.chromium.org/2643643007
Cr-Commit-Position: refs/heads/master@{#445662}

[modify] https://crrev.com/3deaebb8edf5fb2461d962efbfa6673f5669dacc/third_party/WebKit/LayoutTests/fast/css/getComputedStyle/computed-style-listing-expected.txt
[modify] https://crrev.com/3deaebb8edf5fb2461d962efbfa6673f5669dacc/third_party/WebKit/LayoutTests/fast/css/getComputedStyle/computed-style-without-renderer-listing-expected.txt
[modify] https://crrev.com/3deaebb8edf5fb2461d962efbfa6673f5669dacc/third_party/WebKit/LayoutTests/svg/css/getComputedStyle-listing-expected.txt
[modify] https://crrev.com/3deaebb8edf5fb2461d962efbfa6673f5669dacc/third_party/WebKit/LayoutTests/transforms/translate-parsing.html
[modify] https://crrev.com/3deaebb8edf5fb2461d962efbfa6673f5669dacc/third_party/WebKit/Source/core/animation/CSSTranslateInterpolationType.cpp
[modify] https://crrev.com/3deaebb8edf5fb2461d962efbfa6673f5669dacc/third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp
[modify] https://crrev.com/3deaebb8edf5fb2461d962efbfa6673f5669dacc/third_party/WebKit/Source/core/css/properties/CSSPropertyAPITranslate.cpp
[modify] https://crrev.com/3deaebb8edf5fb2461d962efbfa6673f5669dacc/third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.cpp
Project Member

Comment 5 by bugdroid1@chromium.org, Feb 7 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7f3c2b8170c9058511d39135cfa1ff7cf0c9a668

commit 7f3c2b8170c9058511d39135cfa1ff7cf0c9a668
Author: ericwilligers <ericwilligers@chromium.org>
Date: Tue Feb 07 22:39:32 2017

CSS: Rotate support for none and fixed responsive-test.js

The initial value for rotate is none not 0deg.
https://drafts.csswg.org/css-transforms-2/#individual-transforms

Responsive test was not checking that the property value was valid.

Also added a parsing test for scale.

Patch by divyanshi@google.com
https://codereview.chromium.org/2625313002/

Interpolation and composition expectations added.

BUG= 679873 

Review-Url: https://codereview.chromium.org/2662203002
Cr-Commit-Position: refs/heads/master@{#448751}

[modify] https://crrev.com/7f3c2b8170c9058511d39135cfa1ff7cf0c9a668/third_party/WebKit/LayoutTests/animations/composition/rotate-composition.html
[add] https://crrev.com/7f3c2b8170c9058511d39135cfa1ff7cf0c9a668/third_party/WebKit/LayoutTests/animations/interpolation/rotate-interpolation-expected.txt
[modify] https://crrev.com/7f3c2b8170c9058511d39135cfa1ff7cf0c9a668/third_party/WebKit/LayoutTests/animations/interpolation/rotate-interpolation.html
[modify] https://crrev.com/7f3c2b8170c9058511d39135cfa1ff7cf0c9a668/third_party/WebKit/LayoutTests/animations/responsive/resources/responsive-test.js
[modify] https://crrev.com/7f3c2b8170c9058511d39135cfa1ff7cf0c9a668/third_party/WebKit/LayoutTests/animations/responsive/rotate-responsive.html
[modify] https://crrev.com/7f3c2b8170c9058511d39135cfa1ff7cf0c9a668/third_party/WebKit/LayoutTests/animations/responsive/transform-responsive.html
[modify] https://crrev.com/7f3c2b8170c9058511d39135cfa1ff7cf0c9a668/third_party/WebKit/LayoutTests/fast/css/getComputedStyle/computed-style-listing-expected.txt
[modify] https://crrev.com/7f3c2b8170c9058511d39135cfa1ff7cf0c9a668/third_party/WebKit/LayoutTests/fast/css/getComputedStyle/computed-style-without-renderer-listing-expected.txt
[modify] https://crrev.com/7f3c2b8170c9058511d39135cfa1ff7cf0c9a668/third_party/WebKit/LayoutTests/svg/css/getComputedStyle-listing-expected.txt
[modify] https://crrev.com/7f3c2b8170c9058511d39135cfa1ff7cf0c9a668/third_party/WebKit/LayoutTests/transforms/rotate-parsing.html
[modify] https://crrev.com/7f3c2b8170c9058511d39135cfa1ff7cf0c9a668/third_party/WebKit/LayoutTests/transforms/scale-parsing.html
[modify] https://crrev.com/7f3c2b8170c9058511d39135cfa1ff7cf0c9a668/third_party/WebKit/Source/core/animation/css/CSSAnimatableValueFactory.cpp
[modify] https://crrev.com/7f3c2b8170c9058511d39135cfa1ff7cf0c9a668/third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp
[modify] https://crrev.com/7f3c2b8170c9058511d39135cfa1ff7cf0c9a668/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIRotate.cpp
[modify] https://crrev.com/7f3c2b8170c9058511d39135cfa1ff7cf0c9a668/third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.cpp
Project Member

Comment 6 by bugdroid1@chromium.org, Feb 10 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f05f8abb0c65ea13a76fcf6b49cff9c12eb820e0

commit f05f8abb0c65ea13a76fcf6b49cff9c12eb820e0
Author: ericwilligers <ericwilligers@chromium.org>
Date: Fri Feb 10 05:27:49 2017

Animations: Smooth interpolation for translate none

When translate is animating or transitioning, and
the from value or to value (but not both) is none,
the value none is replaced by the equivalent
identity value: 0px

https://drafts.csswg.org/css-transforms-2/#individual-transforms

BUG= 679873 

Review-Url: https://codereview.chromium.org/2680163004
Cr-Commit-Position: refs/heads/master@{#449549}

[modify] https://crrev.com/f05f8abb0c65ea13a76fcf6b49cff9c12eb820e0/third_party/WebKit/LayoutTests/animations/composition/translate-composition.html
[modify] https://crrev.com/f05f8abb0c65ea13a76fcf6b49cff9c12eb820e0/third_party/WebKit/LayoutTests/animations/interpolation/translate-interpolation.html
[modify] https://crrev.com/f05f8abb0c65ea13a76fcf6b49cff9c12eb820e0/third_party/WebKit/Source/core/animation/CSSTranslateInterpolationType.cpp
[modify] https://crrev.com/f05f8abb0c65ea13a76fcf6b49cff9c12eb820e0/third_party/WebKit/Source/core/animation/CSSTranslateInterpolationType.h
[modify] https://crrev.com/f05f8abb0c65ea13a76fcf6b49cff9c12eb820e0/third_party/WebKit/Source/core/animation/css/CSSAnimatableValueFactory.cpp
[modify] https://crrev.com/f05f8abb0c65ea13a76fcf6b49cff9c12eb820e0/third_party/WebKit/Source/core/css/resolver/AnimatedStyleBuilder.cpp

Comment 7 by ericwilligers@chromium.org, Feb 13 2017

Labels: Update-Monthly

Comment 9 by ericwilligers@chromium.org, Feb 13 2017

Status: Fixed (was: Started)
►

Sign in to add a comment