New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 679872 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Last visit > 30 days ago
Closed: Jan 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Feature

Blocking:
issue 677178



Sign in to add a comment

record irrelevant changes to CIDB in DetectIrrelevantChanges

Project Member Reported by nxia@chromium.org, Jan 10 2017

Issue description

As each CQ build has only one board configuration, we should record irrelevant changes to CIDB in DetectIrrelevantChanges for CQ builds, so that CQ-master can access slave irrelevant changes as early as possible.


 
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/b6d62e80e19d91b27d120ca1b4711134502503ae

commit b6d62e80e19d91b27d120ca1b4711134502503ae
Author: Ningning Xia <nxia@chromium.org>
Date: Tue Dec 27 23:30:41 2016

Record irrelevant changes to CIDB in DetectIrrelevantChanges

Each CQ build config has only one board, it's safe to move the logic
of recording irrelevant changes to CIDB in DetectIrrelevantChanges
stage. With this change, CQ-master can know the irrelevant changes of
each slave as early as possible.

BUG= chromium:679872 
TEST=unit_tests

Change-Id: I6e1552e451d504592ce9210171aab4f80122ea13
Reviewed-on: https://chromium-review.googlesource.com/426404
Commit-Ready: Ningning Xia <nxia@chromium.org>
Tested-by: Ningning Xia <nxia@chromium.org>
Reviewed-by: Ningning Xia <nxia@chromium.org>

[modify] https://crrev.com/b6d62e80e19d91b27d120ca1b4711134502503ae/cbuildbot/stages/completion_stages_unittest.py
[modify] https://crrev.com/b6d62e80e19d91b27d120ca1b4711134502503ae/cbuildbot/validation_pool.py
[modify] https://crrev.com/b6d62e80e19d91b27d120ca1b4711134502503ae/cbuildbot/stages/completion_stages.py
[modify] https://crrev.com/b6d62e80e19d91b27d120ca1b4711134502503ae/cbuildbot/stages/report_stages_unittest.py
[modify] https://crrev.com/b6d62e80e19d91b27d120ca1b4711134502503ae/cbuildbot/stages/report_stages.py

Comment 2 by nxia@chromium.org, Jan 20 2017

Status: Fixed (was: Untriaged)

Comment 3 by dchan@google.com, Apr 17 2017

Labels: VerifyIn-59

Comment 4 by dchan@google.com, May 30 2017

Labels: VerifyIn-60

Comment 5 by dchan@chromium.org, Aug 1 2017

Labels: VerifyIn-61

Comment 6 by dchan@chromium.org, Oct 14 2017

Status: Archived (was: Fixed)

Sign in to add a comment