New issue
Advanced search Search tips

Issue 679870 link

Starred by 1 user
Status: Fixed
Owner:
michae...@chromium.org
Closed: Apr 2017
Cc:
abodenha@chromium.org
r...@chromium.org
tbarzic@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug

Blocking:
issue 627975



Sign in to add a comment

Move file handler API from //chrome to //extensions

Project Member Reported by michae...@chromium.org, Jan 10 2017 
It would be nice for app_shell to support file handling apps.

Comment 1 by michae...@chromium.org, Jan 10 2017

Blocking: 627975
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 12 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2d3d04ad2ce2dc65573d4b6399d3a9b88ee9e58f

commit 2d3d04ad2ce2dc65573d4b6399d3a9b88ee9e58f
Author: michaelpg <michaelpg@chromium.org>
Date: Thu Jan 12 18:56:04 2017

Remove unused FirstFileHandlerForEntry()

Precursor to some possible refactoring to extract the file_handlers API from
//chrome to //extensions.

BUG= 679870 
R=benwells@chromium.org

Review-Url: https://codereview.chromium.org/2621193002
Cr-Commit-Position: refs/heads/master@{#443309}

[modify] https://crrev.com/2d3d04ad2ce2dc65573d4b6399d3a9b88ee9e58f/apps/launcher.cc
[modify] https://crrev.com/2d3d04ad2ce2dc65573d4b6399d3a9b88ee9e58f/chrome/browser/extensions/api/file_handlers/app_file_handler_util.cc
[modify] https://crrev.com/2d3d04ad2ce2dc65573d4b6399d3a9b88ee9e58f/chrome/browser/extensions/api/file_handlers/app_file_handler_util.h
Project Member

Comment 3 by bugdroid1@chromium.org, Feb 7 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/75d89e70f4a7a0a8762239d1e36f4109f2c4fb24

commit 75d89e70f4a7a0a8762239d1e36f4109f2c4fb24
Author: michaelpg <michaelpg@chromium.org>
Date: Tue Feb 07 01:34:29 2017

API delegate for non-native file systems

The Chrome OS Files app can provide non-native file systems, like
Drive. Unrelated APIs like file_handlers can access files, including
files from non-native FSs. This CL creates NonNativeFileSystemDelegate
to handle queries about non-native FSs, so that the API itself doesn't
have to depend on the FS logic in //chrome/browser/chromeos.

In AppShell, neither non-native FSs nor the Files app exist. We'd like
to extract the file_handlers API to //extensions. Dropping its use of
the //chrome/browser/chromeos file manager helps.

BUG= 679870 

Review-Url: https://codereview.chromium.org/2666763005
Cr-Commit-Position: refs/heads/master@{#448499}

[modify] https://crrev.com/75d89e70f4a7a0a8762239d1e36f4109f2c4fb24/chrome/browser/extensions/BUILD.gn
[modify] https://crrev.com/75d89e70f4a7a0a8762239d1e36f4109f2c4fb24/chrome/browser/extensions/api/chrome_extensions_api_client.cc
[modify] https://crrev.com/75d89e70f4a7a0a8762239d1e36f4109f2c4fb24/chrome/browser/extensions/api/chrome_extensions_api_client.h
[modify] https://crrev.com/75d89e70f4a7a0a8762239d1e36f4109f2c4fb24/chrome/browser/extensions/api/file_handlers/app_file_handler_util.cc
[modify] https://crrev.com/75d89e70f4a7a0a8762239d1e36f4109f2c4fb24/chrome/browser/extensions/api/file_handlers/directory_util.cc
[modify] https://crrev.com/75d89e70f4a7a0a8762239d1e36f4109f2c4fb24/chrome/browser/extensions/api/file_handlers/mime_util.cc
[add] https://crrev.com/75d89e70f4a7a0a8762239d1e36f4109f2c4fb24/chrome/browser/extensions/api/file_handlers/non_native_file_system_delegate_chromeos.cc
[add] https://crrev.com/75d89e70f4a7a0a8762239d1e36f4109f2c4fb24/chrome/browser/extensions/api/file_handlers/non_native_file_system_delegate_chromeos.h
[modify] https://crrev.com/75d89e70f4a7a0a8762239d1e36f4109f2c4fb24/extensions/browser/api/extensions_api_client.cc
[modify] https://crrev.com/75d89e70f4a7a0a8762239d1e36f4109f2c4fb24/extensions/browser/api/extensions_api_client.h
[add] https://crrev.com/75d89e70f4a7a0a8762239d1e36f4109f2c4fb24/extensions/browser/api/file_handlers/non_native_file_system_delegate.h

Comment 4 by st...@chromium.org, Feb 7 2017

Cc: st...@chromium.org tbarzic@chromium.org abodenha@chromium.org
Awesome!
Project Member

Comment 5 by bugdroid1@chromium.org, Feb 9 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/10d5e4e8430e41ca148452f2f8582db517846799

commit 10d5e4e8430e41ca148452f2f8582db517846799
Author: michaelpg <michaelpg@chromium.org>
Date: Thu Feb 09 23:23:44 2017

Move file_handlers API from //chrome to //extensions

Largely mechanical CL via move_source_file.py, subbing some Profile usage
for BrowserContext.

Results in removing some DEPS exceptions and #includes from //apps.

BUG= 679870 

Review-Url: https://codereview.chromium.org/2685453002
Cr-Commit-Position: refs/heads/master@{#449460}

[modify] https://crrev.com/10d5e4e8430e41ca148452f2f8582db517846799/apps/DEPS
[modify] https://crrev.com/10d5e4e8430e41ca148452f2f8582db517846799/apps/launcher.cc
[modify] https://crrev.com/10d5e4e8430e41ca148452f2f8582db517846799/chrome/browser/chromeos/extensions/file_manager/private_api_misc.cc
[modify] https://crrev.com/10d5e4e8430e41ca148452f2f8582db517846799/chrome/browser/chromeos/extensions/file_manager/private_api_tasks.cc
[modify] https://crrev.com/10d5e4e8430e41ca148452f2f8582db517846799/chrome/browser/chromeos/file_manager/file_tasks.cc
[modify] https://crrev.com/10d5e4e8430e41ca148452f2f8582db517846799/chrome/browser/chromeos/file_manager/file_tasks.h
[modify] https://crrev.com/10d5e4e8430e41ca148452f2f8582db517846799/chrome/browser/chromeos/file_manager/open_util.cc
[modify] https://crrev.com/10d5e4e8430e41ca148452f2f8582db517846799/chrome/browser/chromeos/fileapi/external_file_url_request_job.cc
[modify] https://crrev.com/10d5e4e8430e41ca148452f2f8582db517846799/chrome/browser/extensions/BUILD.gn
[modify] https://crrev.com/10d5e4e8430e41ca148452f2f8582db517846799/chrome/browser/extensions/api/developer_private/developer_private_api.cc
[modify] https://crrev.com/10d5e4e8430e41ca148452f2f8582db517846799/chrome/browser/extensions/api/file_system/file_system_api.cc
[modify] https://crrev.com/10d5e4e8430e41ca148452f2f8582db517846799/chrome/browser/extensions/api/image_writer_private/image_writer_private_api.cc
[modify] https://crrev.com/10d5e4e8430e41ca148452f2f8582db517846799/chrome/browser/extensions/api/log_private/log_private_api_chromeos.cc
[modify] https://crrev.com/10d5e4e8430e41ca148452f2f8582db517846799/chrome/test/BUILD.gn
[modify] https://crrev.com/10d5e4e8430e41ca148452f2f8582db517846799/extensions/browser/BUILD.gn
[modify] https://crrev.com/10d5e4e8430e41ca148452f2f8582db517846799/extensions/browser/DEPS
[modify] https://crrev.com/10d5e4e8430e41ca148452f2f8582db517846799/extensions/browser/api/BUILD.gn
[modify] https://crrev.com/10d5e4e8430e41ca148452f2f8582db517846799/extensions/browser/api/DEPS
[add] https://crrev.com/10d5e4e8430e41ca148452f2f8582db517846799/extensions/browser/api/file_handlers/BUILD.gn
[add] https://crrev.com/10d5e4e8430e41ca148452f2f8582db517846799/extensions/browser/api/file_handlers/OWNERS
[rename] https://crrev.com/10d5e4e8430e41ca148452f2f8582db517846799/extensions/browser/api/file_handlers/app_file_handler_util.cc
[rename] https://crrev.com/10d5e4e8430e41ca148452f2f8582db517846799/extensions/browser/api/file_handlers/app_file_handler_util.h
[rename] https://crrev.com/10d5e4e8430e41ca148452f2f8582db517846799/extensions/browser/api/file_handlers/app_file_handler_util_unittest.cc
[rename] https://crrev.com/10d5e4e8430e41ca148452f2f8582db517846799/extensions/browser/api/file_handlers/directory_util.cc
[rename] https://crrev.com/10d5e4e8430e41ca148452f2f8582db517846799/extensions/browser/api/file_handlers/directory_util.h
[rename] https://crrev.com/10d5e4e8430e41ca148452f2f8582db517846799/extensions/browser/api/file_handlers/directory_util_unittest.cc
[rename] https://crrev.com/10d5e4e8430e41ca148452f2f8582db517846799/extensions/browser/api/file_handlers/mime_util.cc
[rename] https://crrev.com/10d5e4e8430e41ca148452f2f8582db517846799/extensions/browser/api/file_handlers/mime_util.h
[rename] https://crrev.com/10d5e4e8430e41ca148452f2f8582db517846799/extensions/browser/api/file_handlers/mime_util_unittest.cc
Project Member

Comment 6 by bugdroid1@chromium.org, Feb 9 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9790279a2f9d6fb329b9fb6140f1f72ee1b9674a

commit 9790279a2f9d6fb329b9fb6140f1f72ee1b9674a
Author: bsep <bsep@chromium.org>
Date: Thu Feb 09 23:43:49 2017

Revert of Move file_handlers API from //chrome to //extensions (patchset #5 id:80001 of https://codereview.chromium.org/2685453002/ )

Reason for revert:
Broke compile on Linux x64. Example failure: https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Linux%20x64/builds/16205

The build error is kind of confusing to me so apologizes in advance if this is the wrong CL.

Original issue's description:
> Move file_handlers API from //chrome to //extensions
>
> Largely mechanical CL via move_source_file.py, subbing some Profile usage
> for BrowserContext.
>
> Results in removing some DEPS exceptions and #includes from //apps.
>
> BUG= 679870 
>
> Review-Url: https://codereview.chromium.org/2685453002
> Cr-Commit-Position: refs/heads/master@{#449460}
> Committed: https://chromium.googlesource.com/chromium/src/+/10d5e4e8430e41ca148452f2f8582db517846799

TBR=benwells@chromium.org,mtomasz@chromium.org,tzik@chromium.org,michaelpg@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 679870 

Review-Url: https://codereview.chromium.org/2685883008
Cr-Commit-Position: refs/heads/master@{#449465}

[modify] https://crrev.com/9790279a2f9d6fb329b9fb6140f1f72ee1b9674a/apps/DEPS
[modify] https://crrev.com/9790279a2f9d6fb329b9fb6140f1f72ee1b9674a/apps/launcher.cc
[modify] https://crrev.com/9790279a2f9d6fb329b9fb6140f1f72ee1b9674a/chrome/browser/chromeos/extensions/file_manager/private_api_misc.cc
[modify] https://crrev.com/9790279a2f9d6fb329b9fb6140f1f72ee1b9674a/chrome/browser/chromeos/extensions/file_manager/private_api_tasks.cc
[modify] https://crrev.com/9790279a2f9d6fb329b9fb6140f1f72ee1b9674a/chrome/browser/chromeos/file_manager/file_tasks.cc
[modify] https://crrev.com/9790279a2f9d6fb329b9fb6140f1f72ee1b9674a/chrome/browser/chromeos/file_manager/file_tasks.h
[modify] https://crrev.com/9790279a2f9d6fb329b9fb6140f1f72ee1b9674a/chrome/browser/chromeos/file_manager/open_util.cc
[modify] https://crrev.com/9790279a2f9d6fb329b9fb6140f1f72ee1b9674a/chrome/browser/chromeos/fileapi/external_file_url_request_job.cc
[modify] https://crrev.com/9790279a2f9d6fb329b9fb6140f1f72ee1b9674a/chrome/browser/extensions/BUILD.gn
[modify] https://crrev.com/9790279a2f9d6fb329b9fb6140f1f72ee1b9674a/chrome/browser/extensions/api/developer_private/developer_private_api.cc
[rename] https://crrev.com/9790279a2f9d6fb329b9fb6140f1f72ee1b9674a/chrome/browser/extensions/api/file_handlers/api_file_handler_util_unittest.cc
[rename] https://crrev.com/9790279a2f9d6fb329b9fb6140f1f72ee1b9674a/chrome/browser/extensions/api/file_handlers/app_file_handler_util.cc
[rename] https://crrev.com/9790279a2f9d6fb329b9fb6140f1f72ee1b9674a/chrome/browser/extensions/api/file_handlers/app_file_handler_util.h
[rename] https://crrev.com/9790279a2f9d6fb329b9fb6140f1f72ee1b9674a/chrome/browser/extensions/api/file_handlers/directory_util.cc
[rename] https://crrev.com/9790279a2f9d6fb329b9fb6140f1f72ee1b9674a/chrome/browser/extensions/api/file_handlers/directory_util.h
[rename] https://crrev.com/9790279a2f9d6fb329b9fb6140f1f72ee1b9674a/chrome/browser/extensions/api/file_handlers/directory_util_unittest.cc
[rename] https://crrev.com/9790279a2f9d6fb329b9fb6140f1f72ee1b9674a/chrome/browser/extensions/api/file_handlers/mime_util.cc
[rename] https://crrev.com/9790279a2f9d6fb329b9fb6140f1f72ee1b9674a/chrome/browser/extensions/api/file_handlers/mime_util.h
[rename] https://crrev.com/9790279a2f9d6fb329b9fb6140f1f72ee1b9674a/chrome/browser/extensions/api/file_handlers/mime_util_unittest.cc
[modify] https://crrev.com/9790279a2f9d6fb329b9fb6140f1f72ee1b9674a/chrome/browser/extensions/api/file_system/file_system_api.cc
[modify] https://crrev.com/9790279a2f9d6fb329b9fb6140f1f72ee1b9674a/chrome/browser/extensions/api/image_writer_private/image_writer_private_api.cc
[modify] https://crrev.com/9790279a2f9d6fb329b9fb6140f1f72ee1b9674a/chrome/browser/extensions/api/log_private/log_private_api_chromeos.cc
[modify] https://crrev.com/9790279a2f9d6fb329b9fb6140f1f72ee1b9674a/chrome/test/BUILD.gn
[modify] https://crrev.com/9790279a2f9d6fb329b9fb6140f1f72ee1b9674a/extensions/browser/BUILD.gn
[modify] https://crrev.com/9790279a2f9d6fb329b9fb6140f1f72ee1b9674a/extensions/browser/DEPS
[modify] https://crrev.com/9790279a2f9d6fb329b9fb6140f1f72ee1b9674a/extensions/browser/api/BUILD.gn
[modify] https://crrev.com/9790279a2f9d6fb329b9fb6140f1f72ee1b9674a/extensions/browser/api/DEPS
[delete] https://crrev.com/29056b8168c2bf32aa3f6a4be9f3d71aca4c9d12/extensions/browser/api/file_handlers/BUILD.gn
[delete] https://crrev.com/29056b8168c2bf32aa3f6a4be9f3d71aca4c9d12/extensions/browser/api/file_handlers/OWNERS

Comment 7 by michae...@chromium.org, Feb 10 2017 

I can't reproduce this breakage locally, but it's clear we need to add more deps to e/b/api/file_handlers/BUILD.gn. That's fairly simple but I've asked brettw@ to verify my changes (and to understand why this isn't a problem for the 90% of APIs with broken BUILD.gn deps).
Project Member

Comment 8 by bugdroid1@chromium.org, Feb 13 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bc6e379f8e228ee5a137e2ee3ff89b973a3494ef

commit bc6e379f8e228ee5a137e2ee3ff89b973a3494ef
Author: michaelpg <michaelpg@chromium.org>
Date: Mon Feb 13 23:17:27 2017

Move file_handlers API from //chrome to //extensions

Largely mechanical CL via move_source_file.py, subbing some Profile usage
for BrowserContext.

Results in removing some DEPS exceptions and #includes from //apps.

BUG= 679870 

Review-Url: https://codereview.chromium.org/2685453002
Cr-Original-Commit-Position: refs/heads/master@{#449460}
Committed: https://chromium.googlesource.com/chromium/src/+/10d5e4e8430e41ca148452f2f8582db517846799
Review-Url: https://codereview.chromium.org/2685453002
Cr-Commit-Position: refs/heads/master@{#450144}

[modify] https://crrev.com/bc6e379f8e228ee5a137e2ee3ff89b973a3494ef/apps/DEPS
[modify] https://crrev.com/bc6e379f8e228ee5a137e2ee3ff89b973a3494ef/apps/launcher.cc
[modify] https://crrev.com/bc6e379f8e228ee5a137e2ee3ff89b973a3494ef/chrome/browser/chromeos/extensions/file_manager/private_api_misc.cc
[modify] https://crrev.com/bc6e379f8e228ee5a137e2ee3ff89b973a3494ef/chrome/browser/chromeos/extensions/file_manager/private_api_tasks.cc
[modify] https://crrev.com/bc6e379f8e228ee5a137e2ee3ff89b973a3494ef/chrome/browser/chromeos/file_manager/file_tasks.cc
[modify] https://crrev.com/bc6e379f8e228ee5a137e2ee3ff89b973a3494ef/chrome/browser/chromeos/file_manager/file_tasks.h
[modify] https://crrev.com/bc6e379f8e228ee5a137e2ee3ff89b973a3494ef/chrome/browser/chromeos/file_manager/open_util.cc
[modify] https://crrev.com/bc6e379f8e228ee5a137e2ee3ff89b973a3494ef/chrome/browser/chromeos/fileapi/external_file_url_request_job.cc
[modify] https://crrev.com/bc6e379f8e228ee5a137e2ee3ff89b973a3494ef/chrome/browser/extensions/BUILD.gn
[modify] https://crrev.com/bc6e379f8e228ee5a137e2ee3ff89b973a3494ef/chrome/browser/extensions/api/developer_private/developer_private_api.cc
[modify] https://crrev.com/bc6e379f8e228ee5a137e2ee3ff89b973a3494ef/chrome/browser/extensions/api/file_system/file_system_api.cc
[modify] https://crrev.com/bc6e379f8e228ee5a137e2ee3ff89b973a3494ef/chrome/browser/extensions/api/image_writer_private/image_writer_private_api.cc
[modify] https://crrev.com/bc6e379f8e228ee5a137e2ee3ff89b973a3494ef/chrome/browser/extensions/api/log_private/log_private_api_chromeos.cc
[modify] https://crrev.com/bc6e379f8e228ee5a137e2ee3ff89b973a3494ef/chrome/test/BUILD.gn
[modify] https://crrev.com/bc6e379f8e228ee5a137e2ee3ff89b973a3494ef/extensions/browser/BUILD.gn
[modify] https://crrev.com/bc6e379f8e228ee5a137e2ee3ff89b973a3494ef/extensions/browser/DEPS
[modify] https://crrev.com/bc6e379f8e228ee5a137e2ee3ff89b973a3494ef/extensions/browser/api/BUILD.gn
[modify] https://crrev.com/bc6e379f8e228ee5a137e2ee3ff89b973a3494ef/extensions/browser/api/DEPS
[add] https://crrev.com/bc6e379f8e228ee5a137e2ee3ff89b973a3494ef/extensions/browser/api/file_handlers/BUILD.gn
[add] https://crrev.com/bc6e379f8e228ee5a137e2ee3ff89b973a3494ef/extensions/browser/api/file_handlers/OWNERS
[rename] https://crrev.com/bc6e379f8e228ee5a137e2ee3ff89b973a3494ef/extensions/browser/api/file_handlers/app_file_handler_util.cc
[rename] https://crrev.com/bc6e379f8e228ee5a137e2ee3ff89b973a3494ef/extensions/browser/api/file_handlers/app_file_handler_util.h
[rename] https://crrev.com/bc6e379f8e228ee5a137e2ee3ff89b973a3494ef/extensions/browser/api/file_handlers/app_file_handler_util_unittest.cc
[rename] https://crrev.com/bc6e379f8e228ee5a137e2ee3ff89b973a3494ef/extensions/browser/api/file_handlers/directory_util.cc
[rename] https://crrev.com/bc6e379f8e228ee5a137e2ee3ff89b973a3494ef/extensions/browser/api/file_handlers/directory_util.h
[rename] https://crrev.com/bc6e379f8e228ee5a137e2ee3ff89b973a3494ef/extensions/browser/api/file_handlers/directory_util_unittest.cc
[rename] https://crrev.com/bc6e379f8e228ee5a137e2ee3ff89b973a3494ef/extensions/browser/api/file_handlers/mime_util.cc
[rename] https://crrev.com/bc6e379f8e228ee5a137e2ee3ff89b973a3494ef/extensions/browser/api/file_handlers/mime_util.h
[rename] https://crrev.com/bc6e379f8e228ee5a137e2ee3ff89b973a3494ef/extensions/browser/api/file_handlers/mime_util_unittest.cc
Project Member

Comment 9 by bugdroid1@chromium.org, Feb 15 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/67362b5be791794950cbfb2b2e5ecb3574ba2e9d

commit 67362b5be791794950cbfb2b2e5ecb3574ba2e9d
Author: michaelpg <michaelpg@chromium.org>
Date: Wed Feb 15 06:18:27 2017

Move GPUFeatureChecker to content layer

The GPUFeatureChecker provides WebGL status to chrome's extension
requirements checker and the webstore private API. Move it to //content so it
can be used from //extensions without relying on //chrome.

This will allow us to move the extension requirements checker out of //chrome
so AppShell can use it (and can check for WebGL support).

BUG= 679870 

Review-Url: https://codereview.chromium.org/2666243002
Cr-Commit-Position: refs/heads/master@{#450587}

[modify] https://crrev.com/67362b5be791794950cbfb2b2e5ecb3574ba2e9d/chrome/browser/BUILD.gn
[modify] https://crrev.com/67362b5be791794950cbfb2b2e5ecb3574ba2e9d/chrome/browser/extensions/api/webstore_private/webstore_private_api.cc
[modify] https://crrev.com/67362b5be791794950cbfb2b2e5ecb3574ba2e9d/chrome/browser/extensions/api/webstore_private/webstore_private_api.h
[modify] https://crrev.com/67362b5be791794950cbfb2b2e5ecb3574ba2e9d/chrome/browser/extensions/chrome_requirements_checker.cc
[modify] https://crrev.com/67362b5be791794950cbfb2b2e5ecb3574ba2e9d/chrome/browser/extensions/chrome_requirements_checker.h
[delete] https://crrev.com/b1cca1425ef4a0f3174c3feff5ce6a099f6aed95/chrome/browser/gpu/gpu_feature_checker.cc
[delete] https://crrev.com/b1cca1425ef4a0f3174c3feff5ce6a099f6aed95/chrome/browser/gpu/gpu_feature_checker.h
[modify] https://crrev.com/67362b5be791794950cbfb2b2e5ecb3574ba2e9d/content/browser/BUILD.gn
[add] https://crrev.com/67362b5be791794950cbfb2b2e5ecb3574ba2e9d/content/browser/gpu/gpu_feature_checker_impl.cc
[add] https://crrev.com/67362b5be791794950cbfb2b2e5ecb3574ba2e9d/content/browser/gpu/gpu_feature_checker_impl.h
[modify] https://crrev.com/67362b5be791794950cbfb2b2e5ecb3574ba2e9d/content/public/browser/BUILD.gn
[add] https://crrev.com/67362b5be791794950cbfb2b2e5ecb3574ba2e9d/content/public/browser/gpu_feature_checker.cc
[add] https://crrev.com/67362b5be791794950cbfb2b2e5ecb3574ba2e9d/content/public/browser/gpu_feature_checker.h

Comment 10 by st...@chromium.org, Mar 3 2017

Cc: r...@chromium.org

Comment 11 by st...@chromium.org, Mar 3 2017

Cc: -st...@chromium.org

Comment 12 by michae...@chromium.org, Apr 19 2017

Status: Fixed (was: Started)
Project Member

Comment 14 by bugdroid1@chromium.org, May 6 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5734f6c060a77bb7ba0c67342a43064f555d3c41

commit 5734f6c060a77bb7ba0c67342a43064f555d3c41
Author: michaelpg <michaelpg@chromium.org>
Date: Sat May 06 23:43:26 2017

Revert of AppShell: pass command-line files to app as launch data (patchset #3 id:40001 of https://codereview.chromium.org/2824553002/ )

Reason for revert:
TBR was insufficient for commit

Original issue's description:
> AppShell: pass command-line files to app as launch data
>
> An app that registers file handlers can be passed filenames on the
> command line to use those files.
>
> BUG= 679870 
> TBR=benwells@chromium.org # DEPS
>
> Review-Url: https://codereview.chromium.org/2824553002
> Cr-Commit-Position: refs/heads/master@{#469827}
> Committed: https://chromium.googlesource.com/chromium/src/+/b7b29db1011a7b8e0e8816449e2209305402a46a

TBR=rkc@chromium.org,benwells@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 679870 

Review-Url: https://codereview.chromium.org/2864603007
Cr-Commit-Position: refs/heads/master@{#469893}

[modify] https://crrev.com/5734f6c060a77bb7ba0c67342a43064f555d3c41/extensions/shell/BUILD.gn
[modify] https://crrev.com/5734f6c060a77bb7ba0c67342a43064f555d3c41/extensions/shell/DEPS
[modify] https://crrev.com/5734f6c060a77bb7ba0c67342a43064f555d3c41/extensions/shell/browser/DEPS
[modify] https://crrev.com/5734f6c060a77bb7ba0c67342a43064f555d3c41/extensions/shell/browser/default_shell_browser_main_delegate.cc
►

Sign in to add a comment