New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 679860 link

Starred by 0 users

Issue metadata

Status: Duplicate
Merged: issue 724711
Owner:
Last visit > 30 days ago
Closed: Aug 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocking:
issue 676152



Sign in to add a comment

easy_unlock: minify html/js/css resources

Project Member Reported by vapier@chromium.org, Jan 10 2017

Issue description

can we run easy unlock's js/css files through closure-compiler or something ?  looks like we can shave off 500k from these guys somewhat easily.

easy_unlock_background.js & easy_unlock_pairing.js are 4MB by themselves.
 
Cc: tbarzic@chromium.org
Owner: tengs@chromium.org
Passing it on to tengs.

Comment 2 by tengs@chromium.org, Aug 3 2017

Mergedinto: 724711
Status: Duplicate (was: Untriaged)
The easy_unlock_background.js & easy_unlock_pairing.js files are generated by the closure-compiler. I think the large number of dependencies make them quite large. 

However, for EasyUnlock v2, we are switching over to native code, so we can pretty much delete the entirety of easy_unlock_background.js. 

I've filed this work in  bug 724711 .
iirc, the 500k # i came up with running closure-compiler across the files using the minimization mode

Comment 4 by tengs@chromium.org, Aug 3 2017

Ah, in that case, I'll double check the compiler options we're using to generate these files.

Sign in to add a comment