I've stumbled on something like this while fixing Issue 678543.

The problem is that every time AccountSigninView.checkGooglePlayServices is called, a new UserRecoverableErrorHandler.ModalDialog is created and assigned to mGooglePlayServicesUpdateErrorHandler. All the previous ones are forgotten, even though they might have been already displayed.

Hopefully this will help you. :)

Yep that is the problem, thanks!

I plan to modify AccountSigninView to re-use mGooglePlayServicesUpdateErrorHandler. UserRecoverableErrorHandler.ModalDialog will also need to be modified to not create a new dialog every time every time handle() is called.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5a7ffae71d0dcf646d26ef202f8d1882587724c7

commit 5a7ffae71d0dcf646d26ef202f8d1882587724c7
Author: estevenson <estevenson@chromium.org>
Date: Thu Jan 12 20:44:16 2017

Signin: Reuse existing "update gms" dialogs when possible.

Currently, |updateAccounts()| is sometimes called multiple times in
AccountSigninView which results in multiple "update GMS" dialogs being
generated, and the user must click back three times for the dialogs to
disappear.

This CL changes signin to re-use existing dialogs where possible and
always remove old dialogs before creating a new one.

BUG= 679851 

Review-Url: https://codereview.chromium.org/2626083004
Cr-Commit-Position: refs/heads/master@{#443349}

[modify] https://crrev.com/5a7ffae71d0dcf646d26ef202f8d1882587724c7/chrome/android/java/src/org/chromium/chrome/browser/externalauth/UserRecoverableErrorHandler.java
[modify] https://crrev.com/5a7ffae71d0dcf646d26ef202f8d1882587724c7/chrome/android/java/src/org/chromium/chrome/browser/signin/AccountSigninView.java

To verify the fix:

Preconditions:
  * GMS should be out of date
  * Use either a fresh install of Chrome or clear all data for an existing install

Steps to verify:
  1) Launch Chrome
  2) Accept TOS
  3) When the "Update Google Play services" dialog appears, it should be dismiss-able by tapping the back button once or by tapping outside of the dialog once

Step 3) is also accessible from settings -> sign in.

Just to add on to the comment above, we should be sure to test the dialogue from both first run and from the sign in flow from Settings -> Sign in.

Christine, can you help us find someone on the Android test team to verify the fix by following the repro steps in comment #5 before we request a merge?

+Sailaja who was helping us test this dialogue before.

Sailaja, please see the repro steps in #5. Can you please help us verify on latest Canary so we can request a merge back to 56?

I've verified this fix on Canary. I'm requesting a merge back to M56. This is the final CL necessary to merge back to 56 for the GMS out of date dialogue, and I think it's important that the dialogue is dismissible with a single click.

+Alex FYI

This bug requires manual review: We are only 10 days from stable.
Please contact the milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), gkihumba@(cros), bustamante@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Merge approved for branch 2924 (M56).

Please merge and then test the next beta build that's available (we build nightly, take the latest M56 build after merge is complete, can use https://chromedash.googleplex.com/builds?platform=Android to see a list of recent builds, hit "Signed" to get a link to the build bucket).  We have no margin for error (our next release is our stable candidate) so please ensure we're careful here.

Verified that this is fixed as per steps @ #5 on 57.0.2987.0 - Sony Z3/6.0.
I will mark it verified once the M56 build with the fix is available.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0851a76d19a01b08e8d65122a12a7a384ca8b91c

commit 0851a76d19a01b08e8d65122a12a7a384ca8b91c
Author: Eric Stevenson <estevenson@chromium.org>
Date: Fri Jan 20 23:47:00 2017

Signin: Reuse existing "update gms" dialogs when possible.

Currently, |updateAccounts()| is sometimes called multiple times in
AccountSigninView which results in multiple "update GMS" dialogs being
generated, and the user must click back three times for the dialogs to
disappear.

This CL changes signin to re-use existing dialogs where possible and
always remove old dialogs before creating a new one.

BUG= 679851 

Review-Url: https://codereview.chromium.org/2626083004
Cr-Commit-Position: refs/heads/master@{#443349}
(cherry picked from commit 5a7ffae71d0dcf646d26ef202f8d1882587724c7)

Review-Url: https://codereview.chromium.org/2643373002 .
Cr-Commit-Position: refs/branch-heads/2924@{#827}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}

[modify] https://crrev.com/0851a76d19a01b08e8d65122a12a7a384ca8b91c/chrome/android/java/src/org/chromium/chrome/browser/externalauth/UserRecoverableErrorHandler.java
[modify] https://crrev.com/0851a76d19a01b08e8d65122a12a7a384ca8b91c/chrome/android/java/src/org/chromium/chrome/browser/signin/AccountSigninView.java

Hi Sailaja, can you verify this fix now that there's a 56 build available with the fix?

Verified that this is fixed as per steps @ #5 on 56.0.2924.74 - Sony Z3/6.0.

Thanks Sailaja!