New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 679841 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug-Security



Sign in to add a comment

Stack-buffer-overflow in v8::internal::DoubleToRadixCString

Project Member Reported by ClusterFuzz, Jan 10 2017

Issue description

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=5430118219776000

Fuzzer: decoder_langfuzz
Job Type: linux_asan_d8_v8_mipsel_dbg
Platform Id: linux

Crash Type: Stack-buffer-overflow WRITE 1
Crash Address: 0xdd9bd044
Crash State:
  v8::internal::DoubleToRadixCString
  v8::internal::Builtin_Impl_NumberPrototypeToString
  v8::internal::Builtin_NumberPrototypeToString
  
Sanitizer: address (ASAN)

Recommended Security Severity: High

Regressed: V8: r41254:41255

Minimized Testcase (6.93 Kb): https://cluster-fuzz.appspot.com/download/AMIfv97Rjac1GOhxDLJWb27tYeadq24hCM3Lgfiuf86W9mAxz-E_qnk1EwrEG_vLjqAC7R_4cn9gtmY9She6liPIIN5WTekkLOrir_Lg1a_s_Xsycj-S-92FxvP1vs_0zNDJS6foO6DEPmCckvnnxlAK12IHxRs2L2RVQBzMInipDxN7jUy9azBRZH9RtlJkvUdQtByUbDxuWobzqCcrmdPFr7Dbg9PIrNoPEMtVWh42eGt32UZiOjAOrnWO5n5gluLUNkOG2CJDIu5KdST9nZ0cPsNzHmqsIHkpTENtaHUMnVFrK1Zv7zmmcFH1xA4DPrOVQClKtTy5Z-uRiDU2sVis4zwZDq88BC320gpQE1THg8Ur8qtIQ-w6tBgZxTlo65vN3MX0oRruigCvktWYV5BzfOXCHXRorg?testcase_id=5430118219776000

Issue filed automatically.

See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.
 
Project Member

Comment 1 by sheriffbot@chromium.org, Jan 11 2017

Labels: M-57
Project Member

Comment 2 by sheriffbot@chromium.org, Jan 11 2017

Labels: ReleaseBlock-Beta
This issue is a security regression. If you are not able to fix this quickly, please revert the change that introduced it.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 3 by sheriffbot@chromium.org, Jan 11 2017

Labels: Pri-1
Project Member

Comment 4 by sheriffbot@chromium.org, Jan 12 2017

Labels: M-57
Labels: -OS-Linux OS-All
Owner: yangguo@chromium.org
Status: Assigned (was: Untriaged)
Regression range points to https://chromium.googlesource.com/v8/v8/+/21b0dbedfd470b67c47f84428e1af95a506e49e5, which looks related.
Project Member

Comment 6 by bugdroid1@chromium.org, Jan 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/73de4f8f1e89da2bb54bb3b79c58e10cf50cfd53

commit 73de4f8f1e89da2bb54bb3b79c58e10cf50cfd53
Author: yangguo <yangguo@chromium.org>
Date: Mon Jan 16 11:44:29 2017

Fix overflow in Number.prototype.toString with custom radix.

R=tebbi@chromium.org
BUG= chromium:679841 

Review-Url: https://codereview.chromium.org/2638733002
Cr-Commit-Position: refs/heads/master@{#42364}

[modify] https://crrev.com/73de4f8f1e89da2bb54bb3b79c58e10cf50cfd53/src/conversions.cc

Project Member

Comment 7 by bugdroid1@chromium.org, Jan 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/d33dc16f435c529d818ba5a27c2d206e2ff91144

commit d33dc16f435c529d818ba5a27c2d206e2ff91144
Author: yangguo <yangguo@chromium.org>
Date: Mon Jan 16 13:49:00 2017

Add test case for Number.prototype.toString (r42364).

TBR=tebbi@chromium.org
BUG= chromium:679841 

Review-Url: https://codereview.chromium.org/2631163002
Cr-Commit-Position: refs/heads/master@{#42375}

[add] https://crrev.com/d33dc16f435c529d818ba5a27c2d206e2ff91144/test/mjsunit/regress/regress-crbug-679841.js

Project Member

Comment 8 by ClusterFuzz, Jan 17 2017

ClusterFuzz has detected this issue as fixed in range 42363:42364.

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=5430118219776000

Fuzzer: decoder_langfuzz
Job Type: linux_asan_d8_v8_mipsel_dbg
Platform Id: linux

Crash Type: Stack-buffer-overflow WRITE 1
Crash Address: 0xdd9bd044
Crash State:
  v8::internal::DoubleToRadixCString
  v8::internal::Builtin_Impl_NumberPrototypeToString
  v8::internal::Builtin_NumberPrototypeToString
  
Sanitizer: address (ASAN)

Recommended Security Severity: High

Regressed: V8: r41254:41255
Fixed: V8: r42363:42364

Minimized Testcase (6.93 Kb): https://cluster-fuzz.appspot.com/download/AMIfv97Rjac1GOhxDLJWb27tYeadq24hCM3Lgfiuf86W9mAxz-E_qnk1EwrEG_vLjqAC7R_4cn9gtmY9She6liPIIN5WTekkLOrir_Lg1a_s_Xsycj-S-92FxvP1vs_0zNDJS6foO6DEPmCckvnnxlAK12IHxRs2L2RVQBzMInipDxN7jUy9azBRZH9RtlJkvUdQtByUbDxuWobzqCcrmdPFr7Dbg9PIrNoPEMtVWh42eGt32UZiOjAOrnWO5n5gluLUNkOG2CJDIu5KdST9nZ0cPsNzHmqsIHkpTENtaHUMnVFrK1Zv7zmmcFH1xA4DPrOVQClKtTy5Z-uRiDU2sVis4zwZDq88BC320gpQE1THg8Ur8qtIQ-w6tBgZxTlo65vN3MX0oRruigCvktWYV5BzfOXCHXRorg?testcase_id=5430118219776000

See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Status: Fixed (was: Assigned)
Project Member

Comment 10 by sheriffbot@chromium.org, Jan 17 2017

Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify
Labels: -reward-topanel reward-unpaid reward-3500
Labels: -reward-unpaid reward-inprocess
Labels: -ReleaseBlock-Beta
Project Member

Comment 14 by sheriffbot@chromium.org, Apr 25 2017

Labels: -Restrict-View-SecurityNotify allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment