Issue 679840 link

Starred by 1 user

Issue metadata

Status:	Archived
Owner:	kylec...@chromium.org
Closed:	Jan 2017
Cc:	sadrul@chromium.org jamescook@chromium.org mustash-bugs@google.com
EstimatedDays:	----
NextAction:	----
OS:	Chrome
Pri:	1
Type:	Bug
Proj-Mustash-Mus VerifyIn-58 VerifyIn-59 VerifyIn-60 VerifyIn-61

mustash is broken running with Ozone DRM

Project Member Reported by kylec...@chromium.org, Jan 10 2017

Issue description

Trying to run mustash on a Chromebook device with Ozone DRM is broken currently. There is a crash on ui::Service::OnStart() when it launches and everything fails with the WS.

The crash in particular happens when XkbKeyboardLayoutEngine::SetCurrentLayoutByName() is called, or if that is moved then when other Ozone DRM functionality gets called later. The root cause is that there is no base::TaskScheduler instance. It looks many things got switch from using WorkerPool to TaskRunner last week.

Calling base::TaskScheduler::CreateAndSetSimpleTaskScheduler() near the start of Service::OnStart() fixes the crash. I'm not sure if we need to specify any TaskScheduler params or how many worker threads we want.

Comment 1 by kylec...@chromium.org, Jan 10 2017

Owner: kylec...@chromium.org
Status: Started (was: Untriaged)

Project Member

Comment 2 by bugdroid1@chromium.org, Jan 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3ae6c6b59c0c9a5609fb220d7c494649ad1e826a

commit 3ae6c6b59c0c9a5609fb220d7c494649ad1e826a
Author: kylechar <kylechar@chromium.org>
Date: Wed Jan 11 18:13:30 2017

Create TaskScheduler for all Mojo apps.

Running mustash on device currently crashes on startup. This is because
ui::Service doesn't create a TaskScheduler before Ozone DRM uses it. One
option is to have ui::Service::OnStart() create a TaskScheduler. If
other Mojo applications need a task scheduler they'll have to do the
same. Instead, have MashRunner start a TaskRunner for each process.

This fixes the crash in Ozone DRM and doesn't seem to cause any other
problems.

BUG= 679840 

Review-Url: https://codereview.chromium.org/2621153003
Cr-Commit-Position: refs/heads/master@{#442956}

[modify] https://crrev.com/3ae6c6b59c0c9a5609fb220d7c494649ad1e826a/chrome/app/mash/mash_runner.cc