New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 679837 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Feature

Blocking:
issue 611883



Sign in to add a comment

Compute render surface's ClipTreeIndex and TransformTreeIndex without using owning_layer_

Project Member Reported by ajuma@chromium.org, Jan 10 2017

Issue description

The surface's effect node has a clip_id and transform_id, but these are set differently that the values on the owning layer. So we need to modify call sites to work with these values.
 

Comment 1 by ajuma@chromium.org, Jan 16 2017

Owner: ajuma@chromium.org
Status: Assigned (was: Available)
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ed86f4eb6b5a10332b8d4477afc19834faa6079a

commit ed86f4eb6b5a10332b8d4477afc19834faa6079a
Author: ajuma <ajuma@chromium.org>
Date: Mon Jan 16 19:54:28 2017

cc: Compute RenderSurfaceImpl's ClipTreeIndex using its effect node

This makes RenderSurfaceImpl::ClipTreeIndex use the surface's
effect node rather than its owning layer to find its clip id.
The clip id on an effect node is actually for the parent of the
owning layer's clip node, but the parent clip node is in fact
the one that call sites care about since it represents the clip
applied to the surface's output rather than to its input.

BUG= 679837 
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2636953002
Cr-Commit-Position: refs/heads/master@{#443935}

[modify] https://crrev.com/ed86f4eb6b5a10332b8d4477afc19834faa6079a/cc/layers/render_surface_impl.cc
[modify] https://crrev.com/ed86f4eb6b5a10332b8d4477afc19834faa6079a/cc/trees/draw_property_utils.cc

Project Member

Comment 3 by bugdroid1@chromium.org, Jan 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/695875dd4c75b268f423628eae300a700e156751

commit 695875dd4c75b268f423628eae300a700e156751
Author: ajuma <ajuma@chromium.org>
Date: Tue Jan 17 15:51:05 2017

cc: Compute RenderSurfaceImpl's TransformTreeIndex using its effect node

This makes RenderSurfaceImpl::TransformTreeIndex use the surface's effect
node rather than its owning layer to find its transform id. For non-root
surfaces, the transform id from the effect node matches the id we
previously got from the owning layer. For the root surface, the id on
the effect node is kRootNodeId (that is, 0) while we previously got
kContentsRootNodeId (that is, 1) from the owning layer; returning
kRootNodeId makes more sense since the draw transform and screen space
transform for the root render surface are defined to be the identity,
and don't include the transform from node 1 to node 0.

BUG= 679837 
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2632313002
Cr-Commit-Position: refs/heads/master@{#444060}

[modify] https://crrev.com/695875dd4c75b268f423628eae300a700e156751/cc/layers/render_surface_impl.cc
[modify] https://crrev.com/695875dd4c75b268f423628eae300a700e156751/cc/trees/draw_property_utils.cc
[modify] https://crrev.com/695875dd4c75b268f423628eae300a700e156751/cc/trees/property_tree.cc

Comment 4 by ajuma@chromium.org, Jan 17 2017

Status: Fixed (was: Assigned)

Sign in to add a comment