New issue
Advanced search Search tips

Issue 679835 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Request summary page should include the currently selected payment method

Project Member Reported by anthonyvd@chromium.org, Jan 10 2017

Issue description

The payment method initially displayed should be the first complete credit card returned by autofill's frecency algorithm.

When clicked, the dialog should navigate to the payment selection screen.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/045303a3e7169ff8f56477510fd7f352060dc9a1

commit 045303a3e7169ff8f56477510fd7f352060dc9a1
Author: anthonyvd <anthonyvd@chromium.org>
Date: Tue Jan 17 22:19:19 2017

[WebPayments] Add the Payment Method section in the Payment Sheet

BUG= 679835 

Review-Url: https://codereview.chromium.org/2621153002
Cr-Commit-Position: refs/heads/master@{#444162}

[modify] https://crrev.com/045303a3e7169ff8f56477510fd7f352060dc9a1/chrome/browser/payments/chrome_payment_request_delegate.cc
[modify] https://crrev.com/045303a3e7169ff8f56477510fd7f352060dc9a1/chrome/browser/payments/chrome_payment_request_delegate.h
[modify] https://crrev.com/045303a3e7169ff8f56477510fd7f352060dc9a1/chrome/browser/payments/payment_request_factory.cc
[modify] https://crrev.com/045303a3e7169ff8f56477510fd7f352060dc9a1/chrome/browser/ui/BUILD.gn
[add] https://crrev.com/045303a3e7169ff8f56477510fd7f352060dc9a1/chrome/browser/ui/views/payments/payment_method_view_controller.cc
[add] https://crrev.com/045303a3e7169ff8f56477510fd7f352060dc9a1/chrome/browser/ui/views/payments/payment_method_view_controller.h
[modify] https://crrev.com/045303a3e7169ff8f56477510fd7f352060dc9a1/chrome/browser/ui/views/payments/payment_request_dialog.cc
[modify] https://crrev.com/045303a3e7169ff8f56477510fd7f352060dc9a1/chrome/browser/ui/views/payments/payment_request_dialog.h
[modify] https://crrev.com/045303a3e7169ff8f56477510fd7f352060dc9a1/chrome/browser/ui/views/payments/payment_request_views_util.cc
[modify] https://crrev.com/045303a3e7169ff8f56477510fd7f352060dc9a1/chrome/browser/ui/views/payments/payment_sheet_view_controller.cc
[modify] https://crrev.com/045303a3e7169ff8f56477510fd7f352060dc9a1/chrome/browser/ui/views/payments/payment_sheet_view_controller.h
[modify] https://crrev.com/045303a3e7169ff8f56477510fd7f352060dc9a1/components/autofill_strings.grdp
[modify] https://crrev.com/045303a3e7169ff8f56477510fd7f352060dc9a1/components/payments/BUILD.gn
[modify] https://crrev.com/045303a3e7169ff8f56477510fd7f352060dc9a1/components/payments/DEPS
[modify] https://crrev.com/045303a3e7169ff8f56477510fd7f352060dc9a1/components/payments/payment_request.cc
[modify] https://crrev.com/045303a3e7169ff8f56477510fd7f352060dc9a1/components/payments/payment_request.h
[modify] https://crrev.com/045303a3e7169ff8f56477510fd7f352060dc9a1/components/payments/payment_request_delegate.h

Description: Show this description
Project Member

Comment 3 by bugdroid1@chromium.org, Feb 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/75bc466a32b5f692de641e036712861c5a2f2390

commit 75bc466a32b5f692de641e036712861c5a2f2390
Author: anthonyvd <anthonyvd@chromium.org>
Date: Wed Feb 22 22:04:43 2017

[Web Payments] Add a mechanism to build item lists in the PR dialog.

This CL adds the PaymentRequestItemList class and uses it in the
payment method selection screen to display the list of available credit
cards. This class is meant to be used in all places in the PR dialog
where there are lists (payment method, shipping address, billing address
selection screens).

BUG= 679835 

Review-Url: https://codereview.chromium.org/2695653004
Cr-Commit-Position: refs/heads/master@{#452224}

[modify] https://crrev.com/75bc466a32b5f692de641e036712861c5a2f2390/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/75bc466a32b5f692de641e036712861c5a2f2390/chrome/browser/ui/views/payments/payment_method_view_controller.cc
[modify] https://crrev.com/75bc466a32b5f692de641e036712861c5a2f2390/chrome/browser/ui/views/payments/payment_method_view_controller.h
[add] https://crrev.com/75bc466a32b5f692de641e036712861c5a2f2390/chrome/browser/ui/views/payments/payment_request_item_list.cc
[add] https://crrev.com/75bc466a32b5f692de641e036712861c5a2f2390/chrome/browser/ui/views/payments/payment_request_item_list.h
[modify] https://crrev.com/75bc466a32b5f692de641e036712861c5a2f2390/chrome/browser/ui/views/payments/payment_request_sheet_controller.cc
[modify] https://crrev.com/75bc466a32b5f692de641e036712861c5a2f2390/chrome/browser/ui/views/payments/payment_request_sheet_controller.h
[modify] https://crrev.com/75bc466a32b5f692de641e036712861c5a2f2390/chrome/browser/ui/views/payments/payment_request_views_util.h
[modify] https://crrev.com/75bc466a32b5f692de641e036712861c5a2f2390/chrome/browser/ui/views/payments/payment_sheet_view_controller.cc
[modify] https://crrev.com/75bc466a32b5f692de641e036712861c5a2f2390/components/payments/payment_request.cc
[modify] https://crrev.com/75bc466a32b5f692de641e036712861c5a2f2390/components/payments/payment_request.h

Project Member

Comment 4 by bugdroid1@chromium.org, Feb 23 2017

Project Member

Comment 5 by bugdroid1@chromium.org, Feb 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4b014c7ebbe5ed0d2abf313d04699caf6c6ed18d

commit 4b014c7ebbe5ed0d2abf313d04699caf6c6ed18d
Author: anthonyvd <anthonyvd@chromium.org>
Date: Mon Feb 27 17:08:28 2017

[Web Payments] Implement the credit card selection UI functionality.

This patch adds the necessary logic to allow the user to use the
Payment Method Selection Screen to select the credit card to send to the
website.

BUG= 679835 

Review-Url: https://codereview.chromium.org/2711973002
Cr-Commit-Position: refs/heads/master@{#453239}

[modify] https://crrev.com/4b014c7ebbe5ed0d2abf313d04699caf6c6ed18d/chrome/browser/ui/views/payments/payment_method_view_controller.cc
[add] https://crrev.com/4b014c7ebbe5ed0d2abf313d04699caf6c6ed18d/chrome/browser/ui/views/payments/payment_method_view_controller_interactive_uitest.cc
[modify] https://crrev.com/4b014c7ebbe5ed0d2abf313d04699caf6c6ed18d/chrome/browser/ui/views/payments/payment_request_credit_card_editor_interactive_uitest.cc
[modify] https://crrev.com/4b014c7ebbe5ed0d2abf313d04699caf6c6ed18d/chrome/browser/ui/views/payments/payment_request_dialog_view_ids.h
[modify] https://crrev.com/4b014c7ebbe5ed0d2abf313d04699caf6c6ed18d/chrome/browser/ui/views/payments/payment_request_interactive_uitest_base.cc
[modify] https://crrev.com/4b014c7ebbe5ed0d2abf313d04699caf6c6ed18d/chrome/browser/ui/views/payments/payment_request_interactive_uitest_base.h
[modify] https://crrev.com/4b014c7ebbe5ed0d2abf313d04699caf6c6ed18d/chrome/browser/ui/views/payments/payment_request_item_list.cc
[modify] https://crrev.com/4b014c7ebbe5ed0d2abf313d04699caf6c6ed18d/chrome/browser/ui/views/payments/payment_request_item_list.h
[add] https://crrev.com/4b014c7ebbe5ed0d2abf313d04699caf6c6ed18d/chrome/browser/ui/views/payments/payment_request_item_list_unittest.cc
[modify] https://crrev.com/4b014c7ebbe5ed0d2abf313d04699caf6c6ed18d/chrome/test/BUILD.gn
[modify] https://crrev.com/4b014c7ebbe5ed0d2abf313d04699caf6c6ed18d/components/payments/payment_request.h

Status: Fixed (was: Assigned)
Components: -UI>Browser>Autofill>Payments UI>Browser>Payments

Sign in to add a comment