Do not show Win 10 FRE in no-default contexts |
||||
Issue descriptionThere are some edge cases where it doesn't make sense to show the Win 10 FRE because the "set as default browser" button is a no-op. These are: - When build is Canary - When controlled by DefaultBrowserSettingEnabled group policy
,
Jan 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5b44f57323919c2838778c41b3eb00d7d0f0e7b2 commit 5b44f57323919c2838778c41b3eb00d7d0f0e7b2 Author: pmonette <pmonette@chromium.org> Date: Wed Jan 11 17:25:36 2017 Fix the logic that determines when to show the Win 10 promo page. The Win 10 promo is now skipped when the DefaultBrowserSettingEnabled group policy is disabled or the browser distribution does not allow Chrome to be set as the default browser. BUG= 679816 Review-Url: https://codereview.chromium.org/2625793002 Cr-Commit-Position: refs/heads/master@{#442943} [modify] https://crrev.com/5b44f57323919c2838778c41b3eb00d7d0f0e7b2/chrome/browser/ui/startup/startup_tab_provider.cc [modify] https://crrev.com/5b44f57323919c2838778c41b3eb00d7d0f0e7b2/chrome/browser/ui/startup/startup_tab_provider.h [modify] https://crrev.com/5b44f57323919c2838778c41b3eb00d7d0f0e7b2/chrome/browser/ui/startup/startup_tab_provider_unittest.cc
,
Jan 18 2017
Requesting merge. This CL is a dependency (merge conflict) for merging crbug/680076 to M56, which is a regression fix. The CL itself has no impact in Canary, which has been verified in today's build.
,
Jan 18 2017
This bug requires manual review: We are only 12 days from stable. Please contact the milestone owner if you have questions. Owners: amineer@(clank), cmasso@(bling), gkihumba@(cros), bustamante@(desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jan 18 2017
Pushing to M57 along with aforementioned regression fix. |
||||
►
Sign in to add a comment |
||||
Comment 1 by pmonette@chromium.org
, Jan 10 2017Status: Started (was: Untriaged)