New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 679815 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner:
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

DevTools: indicate which console messages come from service workers (different contexts)

Project Member Reported by l...@chromium.org, Jan 10 2017

Issue description

Similar to the way that timestamps appear to the left of a console message to indicate when it was logged, we should also put the name of the service worker from which it originates.
 

Comment 1 by l...@chromium.org, Jan 11 2017

I've attached some screenshots where console messages get an added execution context label, formatted the same way as timestamps, and still filter-able.  The examples show 'top' the main frame, logs from iframes 'example.com' and 'localhost/', and service workers 'sw.js'.

For timestamps, the default setting is to not show them unless the user turns on the setting.  With execution context labels, I'm guessing a user wants to see them if we have more than one context present.  Perhaps we can add a checkbox option in settings but turn it on if we see multiple contexts.

@chowse, WDYT?
contextFilter.png
57.3 KB View Download
contextNoTime.png
87.5 KB View Download
contextWithTime.png
126 KB View Download

Comment 2 by l...@chromium.org, Jan 11 2017

Summary: DevTools: indicate which console messages come from service workers (different contexts) (was: DevTools: indicate which console messages come from service workers)

Comment 3 by l...@chromium.org, Jan 12 2017

Cc: chowse@chromium.org

Comment 4 by l...@chromium.org, Jan 13 2017

Update: we can truncate names if they are too long, show a tooltip of the origin on hover, and hide the label if it matches the current context.
updateContextsConsole.png
37.5 KB View Download

Comment 5 by l...@chromium.org, Jan 18 2017

Components: -Platform>Apps>DevTools Platform>DevTools

Comment 6 by l...@chromium.org, Jan 19 2017

Cc: dgozman@chromium.org
Updated screenshot with:
- smaller width labels
- gear icon for workers
smallerLabels.png
146 KB View Download

Comment 7 by l...@chromium.org, Jan 21 2017

betterAlignment.png
140 KB View Download
betterAlignmentNextToTime.png
167 KB View Download

Comment 8 by l...@chromium.org, Jan 26 2017

Another proposal with only 3 icons:
- Gear, workers
- Box, non-main frames (same icon used in Application)
- Puzzle piece, extensions
- no icon for other contexts (top, page, DevTools generated)

On hover, we can show the full name of the context.  If it's associated with an execution context, we can click the icon to show messages just from that context (changes the context selector dropdown and turns off 'Show all messages').

chowse, dgozman, WDYT?
contextIconsThin.png
51.5 KB View Download
contextIconsWide.png
128 KB View Download
contextIconsLeft.png
154 KB View Download

Comment 9 by l...@chromium.org, Jan 27 2017

Some more screenshots.
contextIcons2Column.png
117 KB View Download
contextIconsOverlay.png
112 KB View Download

Comment 10 by l...@chromium.org, Jan 28 2017

contextIconsGroupsRepeat.png
142 KB View Download

Comment 11 by l...@chromium.org, Feb 2 2017

As a first step, I'd like to land a patch to introduce deterministic ordering for icons.  Before after screenshots below
todaysDecorations.png
52.7 KB View Download
currentDecorations.png
30.2 KB View Download
orderedDecorations.png
29.2 KB View Download
orderedDecorations2.png
39.0 KB View Download
Can we move the repeated counter to the left as well?

Comment 13 by l...@chromium.org, Feb 2 2017

Since the repeat counter can grow arbitrarily longer than the regular error/warning level icons, it would push the group nesting markers to the right and break the vertical group.

Either we have error/warning icons to the right of the nesting markers or the repeat counter has to be on the other side from them.
Let's explore capping counter to certain width? How does that look?

Comment 15 by l...@chromium.org, Feb 2 2017

Neat idea!  With the repeat capped to 99+, some space is added to the left of every message, which doesn't look bad imo.
repeatLeft.png
49.4 KB View Download
repeatLeft2.png
128 KB View Download
I don't think capping to 99+ is a good idea - I always want to know if/when it grows. Also, I think we should rework our repeat counter anyways.

Comment 17 by l...@chromium.org, Nov 8 2017

Status: WontFix (was: Assigned)
Now that better filtering options exist: "url:sw.js" and open console sidebar > click "sw.js", this issue is addressed.  Closing since no work is currently planned.

Sign in to add a comment