New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 679809 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug



Sign in to add a comment

SigninInteractionController doesn't always display its signin errors

Project Member Reported by bzanotti@chromium.org, Jan 10 2017

Issue description

SigninInteractionController is using an AlertCoordinator to show signin errors (unless they have been handled internally by ChromeIdentityInteractionManager).

The errors need to be shown in two scenarios:
- Signin screen isn't shown (error is usually that it couldn't be shown, e.g. network error).
- Signin screen is shown (those errors are rare, they are mostly handled internally by ChromeIdentityInteractionManager, but they exist).

The first scenario is handled correctly but not the second. This is due to the top view controller being different from the one given to the AlertCoordinator. The AlertCoordinator needs its given view controller to be visible because it will present the alert on top of it.

We should probably pass the top visible view controller to AlertCoordinator instead.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6f9dd03c83e9a69b48a941b553fe255c68d401d6

commit 6f9dd03c83e9a69b48a941b553fe255c68d401d6
Author: bzanotti <bzanotti@chromium.org>
Date: Thu Jan 12 15:09:52 2017

[Signin iOS] Ensure SigninInteractionController displays signin errors.

SigninInteractionController uses an AlertCoordinator to display
potential sign-in errors, which requires the view controler to use to
present the alert dialog.
To ensure SigninInteractionController can always display correctly
errors, the AlertCoordinator must be given the top most visible view
controller (some errors are displayed before the sign-in screen is
shown, and some are displayed on top of the sign-in screen).

BUG= 679809 

Review-Url: https://codereview.chromium.org/2626003004
Cr-Commit-Position: refs/heads/master@{#443230}

[modify] https://crrev.com/6f9dd03c83e9a69b48a941b553fe255c68d401d6/ios/chrome/browser/ui/authentication/signin_interaction_controller.mm

Status: Fixed (was: Assigned)

Sign in to add a comment