New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 679783 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 18
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

[USS] Multiple EntityChanges for the same item can be sent in the same ApplySyncChanges.

Project Member Reported by s...@chromium.org, Jan 10 2017

Issue description

Could check and prune before every ApplySyncChanges, or just when encryption is first enabled in the worker. Sending multiple EntityChanges for the same item will crash some models, like autofill. It doesn't make sense for every model type to solve this problem.
 

Comment 1 by s...@chromium.org, Jan 10 2017

Actually, I was initially incorrect. This isn't just a problem with encryption. Within a single GetUpdates request, we're guaranteed to never see the same item twice. However, when syncer.cc loops and makes multiple GetUpdates requests, and then combines those results, before we get to apply/merge, we do need to handle receiving both the same update twice, and separate updates for the same item.

Comment 2 by s...@chromium.org, Jan 17 2018

Labels: SyncHandoff2018
Summary: [USS] Multiple EntityChanges for the same item can be sent in the same ApplySyncChanges. (was: [USS] When blocking for encryption, multiple EntityChanges for the same item can be sent in the same ApplySyncChanges.)
Project Member

Comment 3 by sheriffbot@chromium.org, Jan 18 (5 days ago)

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 4 by mastiz@chromium.org, Jan 18 (5 days ago)

Owner: mastiz@chromium.org
Status: Fixed (was: Untriaged)
Already implemented in DeduplicatePendingUpdatesBasedOnClientTagHash().

Sign in to add a comment