New issue
Advanced search Search tips

Issue 679759 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2017
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Inaccurate comment in StyleAdjuster for position:relative

Project Member Reported by smcgruer@chromium.org, Jan 10 2017

Issue description

StyleAdjuster has the following:

  // After performing the display mutation, check table rows. We do not honor
  // position: relative table rows or cells.  This has been established for
  // position: relative in CSS2.1 (and caused a crash in containingBlock() on
  // some sites).
  if ((style.display() == EDisplay::TableHeaderGroup ||
       style.display() == EDisplay::TableRowGroup ||
       style.display() == EDisplay::TableFooterGroup ||
       style.display() == EDisplay::TableRow) &&
      style.position() == RelativePosition)
    style.setPosition(StaticPosition);

However, support for cells was added back in 2011, in 23fab7d4abe23de5b2855c4d0313467f2c8e4779 (svn://svn.chromium.org/blink/trunk@81049). We should fix up the comment, at least to avoid confusing future me.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1469180ca6e0042310b2288a449531a60e8cc8ce

commit 1469180ca6e0042310b2288a449531a60e8cc8ce
Author: smcgruer <smcgruer@chromium.org>
Date: Thu Jan 12 21:36:15 2017

Fix comment regarding position:relative for table cells

Support for position:relative was added back in early 2011, in
23fab7d4abe23de5b2855c4d0313467f2c8e4779, but the comment was never
updated to reflect the new code.

BUG= 679759 

Review-Url: https://codereview.chromium.org/2625723002
Cr-Commit-Position: refs/heads/master@{#443369}

[modify] https://crrev.com/1469180ca6e0042310b2288a449531a60e8cc8ce/third_party/WebKit/Source/core/css/resolver/StyleAdjuster.cpp

Status: Fixed (was: Started)

Sign in to add a comment