New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 679756 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: ----

Blocked on:
issue 681011



Sign in to add a comment

Get rid of passing separate api object around in chromium_tests

Project Member Reported by phajdan.jr@chromium.org, Jan 10 2017

Issue description

Get rid of passing separate api object around in chromium_tests

Uploaded https://codereview.chromium.org/2628523004/ and https://chromium-review.googlesource.com/c/426658/ .
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/edccd965e42fb29b289f143ca662b787b3c38615

commit edccd965e42fb29b289f143ca662b787b3c38615
Author: Paweł Hajdan, Jr <phajdan.jr@chromium.org>
Date: Wed Jan 11 20:42:33 2017

Get rid of passing separate api object around in chromium_tests (1/2)

This patch only modifies chromium_tests to make it safer to land.

As next steps, callers will be updated.

BUG= 679756 

Change-Id: I967f0e8534da2f3839ca60ee5c0f436891ad4296
Reviewed-on: https://chromium-review.googlesource.com/426658
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org>

[modify] https://crrev.com/edccd965e42fb29b289f143ca662b787b3c38615/scripts/slave/recipe_modules/chromium_tests/__init__.py
[modify] https://crrev.com/edccd965e42fb29b289f143ca662b787b3c38615/scripts/slave/recipe_modules/chromium_tests/api.py

Project Member

Comment 2 by bugdroid1@chromium.org, Jan 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/6e8aadbab3d1181e3ca20ffe0bb411d5212a876c

commit 6e8aadbab3d1181e3ca20ffe0bb411d5212a876c
Author: John Budorick <jbudorick@chromium.org>
Date: Fri Jan 13 16:16:39 2017

Revert "Get rid of passing separate api object around in chromium_tests (1/2)"

This reverts commit edccd965e42fb29b289f143ca662b787b3c38615.

Reason for revert: suspected cause of trybot failures involving "Recipe Module 'chromium_tests' has no dependency 'chromium_tests'."

e.g. https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/370674

Original change's description:
> Get rid of passing separate api object around in chromium_tests (1/2)
> 
> This patch only modifies chromium_tests to make it safer to land.
> 
> As next steps, callers will be updated.
> 
> BUG= 679756 
> 
> Change-Id: I967f0e8534da2f3839ca60ee5c0f436891ad4296
> Reviewed-on: https://chromium-review.googlesource.com/426658
> Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
> Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org>
> 

TBR=iannucci@chromium.org,phajdan.jr@chromium.org,dpranke@chromium.org,estaab@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 679756 

Change-Id: I0896ed27dc437f2de5c4383ca81e8650d734ec1b
Reviewed-on: https://chromium-review.googlesource.com/428118
Commit-Queue: John Budorick <jbudorick@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>

[modify] https://crrev.com/6e8aadbab3d1181e3ca20ffe0bb411d5212a876c/scripts/slave/recipe_modules/chromium_tests/__init__.py
[modify] https://crrev.com/6e8aadbab3d1181e3ca20ffe0bb411d5212a876c/scripts/slave/recipe_modules/chromium_tests/api.py

Comment 3 by kbr@chromium.org, Jan 13 2017

Blockedon: 681011
Project Member

Comment 4 by bugdroid1@chromium.org, Jan 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/6708a0111e8072937d4e88f21e22e8c43378ad21

commit 6708a0111e8072937d4e88f21e22e8c43378ad21
Author: Paweł Hajdan, Jr <phajdan.jr@chromium.org>
Date: Fri Jan 13 16:47:30 2017

Get rid of passing separate api object around in chromium_tests (1/2) (attempt #2)

This is a reland of https://chromium-review.googlesource.com/c/426658/

This patch only modifies chromium_tests to make it safer to land.

As next steps, callers will be updated.

BUG= 679756 , 681011

Change-Id: Ibf6f913ac441ebaadd2f26047c7d301716fba19b
Reviewed-on: https://chromium-review.googlesource.com/427825
Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>

[modify] https://crrev.com/6708a0111e8072937d4e88f21e22e8c43378ad21/scripts/slave/recipe_modules/chromium_tests/__init__.py
[modify] https://crrev.com/6708a0111e8072937d4e88f21e22e8c43378ad21/scripts/slave/recipe_modules/chromium_tests/api.py

Project Member

Comment 5 by bugdroid1@chromium.org, Jan 16 2017

Labels: Pri-2
Status: Fixed (was: Started)

Sign in to add a comment