Get rid of passing separate api object around in chromium_tests Uploaded https://codereview.chromium.org/2628523004/ and https://chromium-review.googlesource.com/c/426658/ .
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build.git/+/edccd965e42fb29b289f143ca662b787b3c38615 commit edccd965e42fb29b289f143ca662b787b3c38615 Author: Paweł Hajdan, Jr <phajdan.jr@chromium.org> Date: Wed Jan 11 20:42:33 2017 Get rid of passing separate api object around in chromium_tests (1/2) This patch only modifies chromium_tests to make it safer to land. As next steps, callers will be updated. BUG= 679756 Change-Id: I967f0e8534da2f3839ca60ee5c0f436891ad4296 Reviewed-on: https://chromium-review.googlesource.com/426658 Reviewed-by: Robbie Iannucci <iannucci@chromium.org> Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org> [modify] https://crrev.com/edccd965e42fb29b289f143ca662b787b3c38615/scripts/slave/recipe_modules/chromium_tests/__init__.py [modify] https://crrev.com/edccd965e42fb29b289f143ca662b787b3c38615/scripts/slave/recipe_modules/chromium_tests/api.py
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build.git/+/6e8aadbab3d1181e3ca20ffe0bb411d5212a876c commit 6e8aadbab3d1181e3ca20ffe0bb411d5212a876c Author: John Budorick <jbudorick@chromium.org> Date: Fri Jan 13 16:16:39 2017 Revert "Get rid of passing separate api object around in chromium_tests (1/2)" This reverts commit edccd965e42fb29b289f143ca662b787b3c38615. Reason for revert: suspected cause of trybot failures involving "Recipe Module 'chromium_tests' has no dependency 'chromium_tests'." e.g. https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/370674 Original change's description: > Get rid of passing separate api object around in chromium_tests (1/2) > > This patch only modifies chromium_tests to make it safer to land. > > As next steps, callers will be updated. > > BUG= 679756 > > Change-Id: I967f0e8534da2f3839ca60ee5c0f436891ad4296 > Reviewed-on: https://chromium-review.googlesource.com/426658 > Reviewed-by: Robbie Iannucci <iannucci@chromium.org> > Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org> > TBR=iannucci@chromium.org,phajdan.jr@chromium.org,dpranke@chromium.org,estaab@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 679756 Change-Id: I0896ed27dc437f2de5c4383ca81e8650d734ec1b Reviewed-on: https://chromium-review.googlesource.com/428118 Commit-Queue: John Budorick <jbudorick@chromium.org> Reviewed-by: John Budorick <jbudorick@chromium.org> [modify] https://crrev.com/6e8aadbab3d1181e3ca20ffe0bb411d5212a876c/scripts/slave/recipe_modules/chromium_tests/__init__.py [modify] https://crrev.com/6e8aadbab3d1181e3ca20ffe0bb411d5212a876c/scripts/slave/recipe_modules/chromium_tests/api.py
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build.git/+/6708a0111e8072937d4e88f21e22e8c43378ad21 commit 6708a0111e8072937d4e88f21e22e8c43378ad21 Author: Paweł Hajdan, Jr <phajdan.jr@chromium.org> Date: Fri Jan 13 16:47:30 2017 Get rid of passing separate api object around in chromium_tests (1/2) (attempt #2) This is a reland of https://chromium-review.googlesource.com/c/426658/ This patch only modifies chromium_tests to make it safer to land. As next steps, callers will be updated. BUG= 679756 , 681011 Change-Id: Ibf6f913ac441ebaadd2f26047c7d301716fba19b Reviewed-on: https://chromium-review.googlesource.com/427825 Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org> Reviewed-by: John Budorick <jbudorick@chromium.org> [modify] https://crrev.com/6708a0111e8072937d4e88f21e22e8c43378ad21/scripts/slave/recipe_modules/chromium_tests/__init__.py [modify] https://crrev.com/6708a0111e8072937d4e88f21e22e8c43378ad21/scripts/slave/recipe_modules/chromium_tests/api.py
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build.git/+/3e194cb2efe2d6e144a375ef7f9c4161cc76e64d commit 3e194cb2efe2d6e144a375ef7f9c4161cc76e64d Author: Paweł Hajdan, Jr <phajdan.jr@chromium.org> Date: Mon Jan 16 15:56:17 2017 Get rid of passing separate api object around in chromium_tests (2/2) Remove unused _api args and update callers BUG= 679756 Change-Id: Ia38f262f25c2cdcc03e7a1d723c9f0f7368d1127 Reviewed-on: https://chromium-review.googlesource.com/427826 Reviewed-by: Emma Söderberg <emso@chromium.org> Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org> [modify] https://crrev.com/3e194cb2efe2d6e144a375ef7f9c4161cc76e64d/scripts/slave/recipe_modules/auto_bisect/api.py [modify] https://crrev.com/3e194cb2efe2d6e144a375ef7f9c4161cc76e64d/scripts/slave/recipe_modules/auto_bisect_staging/api.py [modify] https://crrev.com/3e194cb2efe2d6e144a375ef7f9c4161cc76e64d/scripts/slave/recipe_modules/chromium_tests/api.py [modify] https://crrev.com/3e194cb2efe2d6e144a375ef7f9c4161cc76e64d/scripts/slave/recipe_modules/chromium_tests/bot_config_and_test_db.py [modify] https://crrev.com/3e194cb2efe2d6e144a375ef7f9c4161cc76e64d/scripts/slave/recipes/android/perf.py [modify] https://crrev.com/3e194cb2efe2d6e144a375ef7f9c4161cc76e64d/scripts/slave/recipes/chromium.py [modify] https://crrev.com/3e194cb2efe2d6e144a375ef7f9c4161cc76e64d/scripts/slave/recipes/chromium_trybot.py
Comment 1 by bugdroid1@chromium.org
, Jan 13 2017