New issue
Advanced search Search tips

Issue 679747 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: Jan 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Add full touchscreen pairing and transform support to mustash

Project Member Reported by kylec...@chromium.org, Jan 10 2017

Issue description

There is some very hacky support for touchscreens in mustash right now. We should reuse ash::TouchTransformerController now that the rest of ash display management code is being used. It should be pretty easy to move TouchTransformerController to src/ui/display and decouple it from ash. 
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/55f0eaf2e3f710faafcae8cf32546729adce93b6

commit 55f0eaf2e3f710faafcae8cf32546729adce93b6
Author: kylechar <kylechar@chromium.org>
Date: Wed Jan 11 22:57:37 2017

Move TouchTransformerController to ui/display/.

We need to add touchscreen support to mustash where display and
input-device management happens in a different process from ash.
Decouple ash::TouchTransformerController from the rest of ash and move
to src/ui/display/ so it can be used with mus. This also decouples and
moves the accompanying tests.

The dependency on WindowTreeHostManager can't be broken so add
AshTouchTransformController which extends TouchTransformController and
listens for ash display configuration changes.

BUG= 679747 

Review-Url: https://codereview.chromium.org/2617043003
Cr-Commit-Position: refs/heads/master@{#443037}

[modify] https://crrev.com/55f0eaf2e3f710faafcae8cf32546729adce93b6/ash/BUILD.gn
[modify] https://crrev.com/55f0eaf2e3f710faafcae8cf32546729adce93b6/ash/shell.cc
[modify] https://crrev.com/55f0eaf2e3f710faafcae8cf32546729adce93b6/ash/shell.h
[add] https://crrev.com/55f0eaf2e3f710faafcae8cf32546729adce93b6/ash/touch/ash_touch_transform_controller.cc
[add] https://crrev.com/55f0eaf2e3f710faafcae8cf32546729adce93b6/ash/touch/ash_touch_transform_controller.h
[delete] https://crrev.com/33b63eb41f344fd42b6e1c62e06459c3543f4102/ash/touch/touch_transformer_controller.h
[modify] https://crrev.com/55f0eaf2e3f710faafcae8cf32546729adce93b6/chrome/browser/chromeos/display/touch_calibrator/touch_calibrator_controller.cc
[modify] https://crrev.com/55f0eaf2e3f710faafcae8cf32546729adce93b6/ui/display/BUILD.gn
[modify] https://crrev.com/55f0eaf2e3f710faafcae8cf32546729adce93b6/ui/display/manager/BUILD.gn
[add] https://crrev.com/55f0eaf2e3f710faafcae8cf32546729adce93b6/ui/display/manager/chromeos/DEPS
[rename] https://crrev.com/55f0eaf2e3f710faafcae8cf32546729adce93b6/ui/display/manager/chromeos/touch_transform_controller.cc
[add] https://crrev.com/55f0eaf2e3f710faafcae8cf32546729adce93b6/ui/display/manager/chromeos/touch_transform_controller.h
[rename] https://crrev.com/55f0eaf2e3f710faafcae8cf32546729adce93b6/ui/display/manager/chromeos/touch_transform_controller_unittest.cc

Project Member

Comment 2 by bugdroid1@chromium.org, Jan 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f77fda1001064005346121f403bb80b3414cbc00

commit f77fda1001064005346121f403bb80b3414cbc00
Author: kylechar <kylechar@chromium.org>
Date: Thu Jan 12 05:28:22 2017

Add full touch support to mus.

Everything necessary to use the existing display to touch input-device
association/transform code is accessible from mus now.
ScreenManagerOzone creates a TouchTransformController and tells it to
compute new transforms when the display configuration changes. That's
it.

Delete existing touch code that was added to the WS to associate a
single display and touch input-device.

BUG= 679747 

Review-Url: https://codereview.chromium.org/2627623003
Cr-Commit-Position: refs/heads/master@{#443162}

[modify] https://crrev.com/f77fda1001064005346121f403bb80b3414cbc00/services/ui/display/screen_manager_ozone.cc
[modify] https://crrev.com/f77fda1001064005346121f403bb80b3414cbc00/services/ui/display/screen_manager_ozone.h
[modify] https://crrev.com/f77fda1001064005346121f403bb80b3414cbc00/services/ui/service.cc
[modify] https://crrev.com/f77fda1001064005346121f403bb80b3414cbc00/services/ui/service.h
[modify] https://crrev.com/f77fda1001064005346121f403bb80b3414cbc00/services/ui/ws/BUILD.gn
[modify] https://crrev.com/f77fda1001064005346121f403bb80b3414cbc00/services/ui/ws/display_manager.cc
[modify] https://crrev.com/f77fda1001064005346121f403bb80b3414cbc00/services/ui/ws/test_utils.h
[delete] https://crrev.com/fd39adcc3b11e8ebe81754de74fc3cd191e44c29/services/ui/ws/touch_controller.cc
[delete] https://crrev.com/fd39adcc3b11e8ebe81754de74fc3cd191e44c29/services/ui/ws/touch_controller.h
[modify] https://crrev.com/f77fda1001064005346121f403bb80b3414cbc00/services/ui/ws/window_server_delegate.h

Owner: kylec...@chromium.org
Status: Fixed (was: Untriaged)
We're now using the same touchscreen code in mustash that classic ash uses, so touchscreen device input should work the same.

Comment 4 by dchan@google.com, Mar 4 2017

Labels: VerifyIn-58

Comment 5 by dchan@google.com, Apr 17 2017

Labels: VerifyIn-59

Comment 6 by dchan@google.com, May 30 2017

Labels: VerifyIn-60

Comment 7 by dchan@chromium.org, Aug 1 2017

Labels: VerifyIn-61

Comment 8 by dchan@chromium.org, Oct 14 2017

Status: Archived (was: Fixed)

Sign in to add a comment