Issue metadata
Sign in to add a comment
|
Surface payment apps in settings. Let users disable individual apps. |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||
Issue descriptionHi hwi@ do you have any UI mocks for this? What I can think of is a preference in settings, and click of it shows a list of apps with a toggle button to disable and enable it.
,
Jan 10 2017
This is top priority on the payments side for Bruno this quarter. Hopefully we'll have something soon!
,
Jan 10 2017
Change this task to priority one according to comment #2. Better to have UX input to start this work.
,
Jan 11 2017
,
Jan 11 2017
Will start this work by putting proposed UIs, details of requirement and implementation in a simple doc for communication.
,
Jan 12 2017
Hi all, below are proposed UI screenshots,
,
Jan 12 2017
hwi@, please let us know what you think about the proposed layout. (zkoch@: your opinion would also be valuable.)
,
Jan 12 2017
We have icons for payment apps, by the way. Also would be interesting to hear opinions on the best placement of those.
,
Jan 12 2017
Thanks for moving this forward. I'm working on it today, will keep you posted. Also I'm your UX contact now :)
,
Jan 12 2017
Thanks bbergher@, Below is the screenshot of the proposed UI with payment app icon and similar preferences we have with icon
,
Jan 12 2017
So I can work on it further, where do the icons come from exactly? - Are they app icons? - Is there a specific API to extract icons for payment methods? If so, do you know where I could find the specifications for those icons?
,
Jan 13 2017
These icons come from the payment app. I think it is the app icon.
,
Jan 17 2017
Hey Ganggui, were these screens made before Bruno's mocks? Not sure if I should give commentary yet. :)
,
Jan 17 2017
Reply comment #13: Yes, above screenshots are made before Bruno's mocks, you no need to comment them, I am waiting for our final decisions on Bruno's mocks.
,
Jan 20 2017
Below 1~4.png are the screenshots of the UIs I implemented according to the mocks. I just redesigned the Autofill settings UIs for now since I plan to implement payment app settings UIs in a separate CL under a flag. Note that, I did not customize off the bottom line of the 'icon + add ...' row since I am using Android default layout which looks common and good, see screenshots 5~7.png from Android system settings. If we really want to remove the last bottom line, I have to customize that row.
,
Jan 20 2017
This looks great, don't worry about the bottom line. Thanks! Aiming to have strings ready for you on Monday.
,
Jan 20 2017
Thanks. Two more screenshots with server profile and credit card. The CL is out for review. I can update the strings on Monday if necessary.
,
Jan 20 2017
I feel like the Google Payments text should be centered vertically. Otherwise, these look great.
,
Jan 21 2017
Agreed with comment #19. Below are the screenshots of the settings UIs for payment apps by using default Android preference layout.
,
Jan 23 2017
,
Jan 24 2017
Here are the final screenshots with new strings.
,
Jan 24 2017
Looks great. Presumably the "payment apps" setting is gated on some sort of payment app finch flag?
,
Jan 24 2017
> finch flag Yep. You can enable it locally via chrome://flags/#android-payment-apps as well.
,
Jan 24 2017
And could you please also include, for completeness, a screenshot with autofill off (on the screen where you turn it on/off)?
,
Jan 24 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6dbc00f485873cc326e3742f65fd7313d7af6aaa commit 6dbc00f485873cc326e3742f65fd7313d7af6aaa Author: gogerald <gogerald@chromium.org> Date: Tue Jan 24 17:27:51 2017 Redesign Autofill settings UIs BUG= 679743 Review-Url: https://codereview.chromium.org/2636023002 Cr-Commit-Position: refs/heads/master@{#445750} [add] https://crrev.com/6dbc00f485873cc326e3742f65fd7313d7af6aaa/chrome/android/java/res/xml/autofill_and_payments_preference_fragment_screen.xml [add] https://crrev.com/6dbc00f485873cc326e3742f65fd7313d7af6aaa/chrome/android/java/res/xml/autofill_and_payments_preferences.xml [delete] https://crrev.com/6771b80c488c2c1b685ab2f674928ee09654ab15/chrome/android/java/res/xml/autofill_preferences.xml [modify] https://crrev.com/6dbc00f485873cc326e3742f65fd7313d7af6aaa/chrome/android/java/res/xml/main_preferences.xml [modify] https://crrev.com/6dbc00f485873cc326e3742f65fd7313d7af6aaa/chrome/android/java/src/org/chromium/chrome/browser/ChromeApplication.java [modify] https://crrev.com/6dbc00f485873cc326e3742f65fd7313d7af6aaa/chrome/android/java/src/org/chromium/chrome/browser/autofill/PersonalDataManager.java [modify] https://crrev.com/6dbc00f485873cc326e3742f65fd7313d7af6aaa/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java [modify] https://crrev.com/6dbc00f485873cc326e3742f65fd7313d7af6aaa/chrome/android/java/src/org/chromium/chrome/browser/preferences/MainPreferences.java [delete] https://crrev.com/6771b80c488c2c1b685ab2f674928ee09654ab15/chrome/android/java/src/org/chromium/chrome/browser/preferences/PreferenceCategoryWithButton.java [add] https://crrev.com/6dbc00f485873cc326e3742f65fd7313d7af6aaa/chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillAndPaymentsPreferences.java [add] https://crrev.com/6dbc00f485873cc326e3742f65fd7313d7af6aaa/chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillCreditCardsFragment.java [modify] https://crrev.com/6dbc00f485873cc326e3742f65fd7313d7af6aaa/chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillEditorBase.java [modify] https://crrev.com/6dbc00f485873cc326e3742f65fd7313d7af6aaa/chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillLocalCardEditor.java [delete] https://crrev.com/6771b80c488c2c1b685ab2f674928ee09654ab15/chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillPreferences.java [modify] https://crrev.com/6dbc00f485873cc326e3742f65fd7313d7af6aaa/chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillProfileEditor.java [add] https://crrev.com/6dbc00f485873cc326e3742f65fd7313d7af6aaa/chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillProfilesFragment.java [modify] https://crrev.com/6dbc00f485873cc326e3742f65fd7313d7af6aaa/chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillServerProfilePreferences.java [modify] https://crrev.com/6dbc00f485873cc326e3742f65fd7313d7af6aaa/chrome/android/java/strings/android_chrome_strings.grd [modify] https://crrev.com/6dbc00f485873cc326e3742f65fd7313d7af6aaa/chrome/android/java_sources.gni [modify] https://crrev.com/6dbc00f485873cc326e3742f65fd7313d7af6aaa/chrome/browser/autofill/android/personal_data_manager_android.cc [modify] https://crrev.com/6dbc00f485873cc326e3742f65fd7313d7af6aaa/chrome/browser/autofill/android/personal_data_manager_android.h
,
Jan 24 2017
Updated the strings. 'Autofill forms' switch does not effect other preferences in the screen
,
Jan 24 2017
I know, it's just for documentation for implementation review. These look great, I'm setting up the review deck to get this bit-flipped as soon as possible.
,
Jan 24 2017
Implementation review deck is ready to go https://docs.google.com/presentation/d/1Dq6RSJ9y1BkfKQJlOA7uNUvQT1tcYr2u2AooBq9-QBs If everything looks good, let me know when this will be available in Canary and I'll send it to UI Review.
,
Jan 24 2017
The first part about autofill settings UIs is landed. Will let you know when the second part of surfacing payment apps is landed (under review now).
,
Jan 25 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/81942a0c2161cd39c04dac4368833f8f3ea556ea commit 81942a0c2161cd39c04dac4368833f8f3ea556ea Author: gogerald <gogerald@chromium.org> Date: Wed Jan 25 20:48:42 2017 Surface settings UIs to allow users enable and disable Android payment apps in payment request The feature is disabled by default. It can be enabled via a flag: chrome://flags/#android-payment-apps To test the new functionality: 1) Install BobPayWithIsReadyPayService.apk: https://drive.google.com/a/google.com/file/d/0B3ISiXgGE1MNSnFXcnkwQ1FSbGc/view?usp=sharing 2) Enable chrome://flags/#android-payment-apps. 3) Go to setttings/Autofill and payments/Payment apps BUG= 679743 patch from issue 2636023002 at patchset 140001 (http://crrev.com/2636023002#ps140001) Review-Url: https://codereview.chromium.org/2647573005 Cr-Commit-Position: refs/heads/master@{#446111} [modify] https://crrev.com/81942a0c2161cd39c04dac4368833f8f3ea556ea/chrome/android/java/src/org/chromium/chrome/browser/payments/AndroidPaymentAppFactory.java [add] https://crrev.com/81942a0c2161cd39c04dac4368833f8f3ea556ea/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentPreferencesUtil.java [modify] https://crrev.com/81942a0c2161cd39c04dac4368833f8f3ea556ea/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java [add] https://crrev.com/81942a0c2161cd39c04dac4368833f8f3ea556ea/chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AndroidPaymentAppPreference.java [add] https://crrev.com/81942a0c2161cd39c04dac4368833f8f3ea556ea/chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AndroidPaymentAppsFragment.java [modify] https://crrev.com/81942a0c2161cd39c04dac4368833f8f3ea556ea/chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillAndPaymentsPreferences.java [modify] https://crrev.com/81942a0c2161cd39c04dac4368833f8f3ea556ea/chrome/android/java/strings/android_chrome_strings.grd [modify] https://crrev.com/81942a0c2161cd39c04dac4368833f8f3ea556ea/chrome/android/java_sources.gni
,
Jan 26 2017
The new settings UI is available in canary now. You can download and install below two test payment apps for verification. BobPayWithIsReadyPayService.apk: https://drive.google.com/a/google.com/file/d/0B3ISiXgGE1MNSnFXcnkwQ1FSbGc/view?usp=sharing AlicePayWithIsReadyPayService.apk: https://drive.google.com/a/google.com/file/d/0B3ISiXgGE1MNWWtQSXlhdEFaeDA/view?usp=sharing
,
Feb 2 2017
,
Mar 28 2017
,
Mar 28 2017
,
Jun 27 2017
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||
►
Sign in to add a comment |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Comment 1 by hwi@chromium.org
, Jan 10 2017