New issue
Advanced search Search tips

Issue 679741 link

Starred by 2 users

Issue metadata

Status: Duplicate
Merged: issue webrtc:7067
Owner:
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 627816



Sign in to add a comment

RTCPeerConnectionStats updated

Project Member Reported by hbos@chromium.org, Jan 10 2017

Issue description

The spec is being updated: https://github.com/w3c/webrtc-stats/pull/125

Update our version to match the spec:

dictionary RTCPeerConnectionStats : RTCStats {
    unsigned long dataChannelsOpened;
    unsigned long dataChannelsClosed;
    unsigned long dataChannelsRequested;
    unsigned long dataChannelsAccepted;
}
 

Comment 1 by hbos@chromium.org, Jan 11 2017

Description: Show this description

Comment 2 by hbos@chromium.org, Jan 11 2017

Bug: The closed counter should increment upon leaving the "open" state (this includes open -> closing). We currently only check "-> closed && in open set", i.e. closing -> closed. Closing channels are still counted as opened, not closed.

Comment 3 by hbos@chromium.org, Jan 11 2017

Labels: -M-57
Project Member

Comment 4 by bugdroid1@chromium.org, Jan 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d28adf3696a330580b5fb705531322ca4f9f3297

commit d28adf3696a330580b5fb705531322ca4f9f3297
Author: hbos <hbos@chromium.org>
Date: Mon Jan 16 12:56:26 2017

RTCPeerConnection.getStats whitelist updated due to recent spec changes.

RTCRTPStreamStats.mediaTrackId renamed trackId: https://github.com/w3c/webrtc-stats/issues/113#issuecomment-271548836
RTCMediaStreamTrackStats.kind added: https://github.com/w3c/webrtc-stats/pull/127
RTCPeerConnectionStats.dataChannels[Opened/Closed/Requested/Accepted] added: https://github.com/w3c/webrtc-stats/pull/125/files
RTCTransportStats.activeConnection replaced by dtlsState: https://github.com/w3c/webrtc-stats/pull/122/files

BUG= chromium:657854 ,  chromium:659137 ,  chromium:679741 ,  chromium:653873 ,  chromium:627816 

Review-Url: https://codereview.chromium.org/2621733004
Cr-Commit-Position: refs/heads/master@{#443879}

[modify] https://crrev.com/d28adf3696a330580b5fb705531322ca4f9f3297/chrome/test/data/webrtc/peerconnection_getstats.js

Comment 5 by hbos@chromium.org, Jan 26 2017

Mergedinto: webrtc:7067
Status: Duplicate (was: Started)
This stats dictionary is partially supported (see landed CLs in this thread).
To better track what's left, a webrtc bug has been created to track the remaining work related to this dictionary - merging into that one.

Sign in to add a comment