Should exercise the UI in some minimal capacity, and should be easy to extend and write more tests.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/432cb34b6e2b52305b2ce64373117185513c707a commit 432cb34b6e2b52305b2ce64373117185513c707a Author: mathp <mathp@chromium.org> Date: Tue Jan 10 15:45:00 2017 [Payments] Move Payment Request test files to chrome/test/data/payments Will allow files to be used for desktop testing. BUG= 679734 TEST=existing TBR=dfalcantara Review-Url: https://codereview.chromium.org/2623653003 Cr-Commit-Position: refs/heads/master@{#442593} [modify] https://crrev.com/432cb34b6e2b52305b2ce64373117185513c707a/WATCHLISTS [modify] https://crrev.com/432cb34b6e2b52305b2ce64373117185513c707a/chrome/android/BUILD.gn [modify] https://crrev.com/432cb34b6e2b52305b2ce64373117185513c707a/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestTestBase.java [modify] https://crrev.com/432cb34b6e2b52305b2ce64373117185513c707a/chrome/browser/payments/payment_request_web_contents_manager_browsertest.cc [modify] https://crrev.com/432cb34b6e2b52305b2ce64373117185513c707a/chrome/browser/payments/site_per_process_payments_browsertest.cc [rename] https://crrev.com/432cb34b6e2b52305b2ce64373117185513c707a/chrome/test/data/payments/abort.js [rename] https://crrev.com/432cb34b6e2b52305b2ce64373117185513c707a/chrome/test/data/payments/basic_card.js [rename] https://crrev.com/432cb34b6e2b52305b2ce64373117185513c707a/chrome/test/data/payments/bobpay.js [rename] https://crrev.com/432cb34b6e2b52305b2ce64373117185513c707a/chrome/test/data/payments/bobpay_and_cards.js [rename] https://crrev.com/432cb34b6e2b52305b2ce64373117185513c707a/chrome/test/data/payments/can_make_payment_query.js [rename] https://crrev.com/432cb34b6e2b52305b2ce64373117185513c707a/chrome/test/data/payments/can_make_payment_query_bobpay.js [rename] https://crrev.com/432cb34b6e2b52305b2ce64373117185513c707a/chrome/test/data/payments/can_make_payment_query_cc.js [rename] https://crrev.com/432cb34b6e2b52305b2ce64373117185513c707a/chrome/test/data/payments/contact_details.js [rename] https://crrev.com/432cb34b6e2b52305b2ce64373117185513c707a/chrome/test/data/payments/contact_details_and_free_shipping.js [rename] https://crrev.com/432cb34b6e2b52305b2ce64373117185513c707a/chrome/test/data/payments/dynamic_shipping.js [rename] https://crrev.com/432cb34b6e2b52305b2ce64373117185513c707a/chrome/test/data/payments/email.js [rename] https://crrev.com/432cb34b6e2b52305b2ce64373117185513c707a/chrome/test/data/payments/email_and_free_shipping.js [rename] https://crrev.com/432cb34b6e2b52305b2ce64373117185513c707a/chrome/test/data/payments/email_and_phone.js [rename] https://crrev.com/432cb34b6e2b52305b2ce64373117185513c707a/chrome/test/data/payments/extra_shipping_options.js [rename] https://crrev.com/432cb34b6e2b52305b2ce64373117185513c707a/chrome/test/data/payments/fail_complete.js [rename] https://crrev.com/432cb34b6e2b52305b2ce64373117185513c707a/chrome/test/data/payments/free_shipping.js [rename] https://crrev.com/432cb34b6e2b52305b2ce64373117185513c707a/chrome/test/data/payments/metrics.js [rename] https://crrev.com/432cb34b6e2b52305b2ce64373117185513c707a/chrome/test/data/payments/name.js [rename] https://crrev.com/432cb34b6e2b52305b2ce64373117185513c707a/chrome/test/data/payments/name_and_free_shipping.js [rename] https://crrev.com/432cb34b6e2b52305b2ce64373117185513c707a/chrome/test/data/payments/no_shipping.js [rename] https://crrev.com/432cb34b6e2b52305b2ce64373117185513c707a/chrome/test/data/payments/payment_request_abort_test.html [rename] https://crrev.com/432cb34b6e2b52305b2ce64373117185513c707a/chrome/test/data/payments/payment_request_basic_card_test.html [rename] https://crrev.com/432cb34b6e2b52305b2ce64373117185513c707a/chrome/test/data/payments/payment_request_bobpay_and_cards_test.html [rename] https://crrev.com/432cb34b6e2b52305b2ce64373117185513c707a/chrome/test/data/payments/payment_request_bobpay_test.html [rename] https://crrev.com/432cb34b6e2b52305b2ce64373117185513c707a/chrome/test/data/payments/payment_request_can_make_payment_query_bobpay_test.html [rename] https://crrev.com/432cb34b6e2b52305b2ce64373117185513c707a/chrome/test/data/payments/payment_request_can_make_payment_query_cc_test.html [rename] https://crrev.com/432cb34b6e2b52305b2ce64373117185513c707a/chrome/test/data/payments/payment_request_can_make_payment_query_test.html [rename] https://crrev.com/432cb34b6e2b52305b2ce64373117185513c707a/chrome/test/data/payments/payment_request_contact_details_and_free_shipping_test.html [rename] https://crrev.com/432cb34b6e2b52305b2ce64373117185513c707a/chrome/test/data/payments/payment_request_contact_details_test.html [rename] https://crrev.com/432cb34b6e2b52305b2ce64373117185513c707a/chrome/test/data/payments/payment_request_dynamic_shipping_test.html [rename] https://crrev.com/432cb34b6e2b52305b2ce64373117185513c707a/chrome/test/data/payments/payment_request_email_and_free_shipping_test.html [rename] https://crrev.com/432cb34b6e2b52305b2ce64373117185513c707a/chrome/test/data/payments/payment_request_email_and_phone_test.html [rename] https://crrev.com/432cb34b6e2b52305b2ce64373117185513c707a/chrome/test/data/payments/payment_request_email_test.html [rename] https://crrev.com/432cb34b6e2b52305b2ce64373117185513c707a/chrome/test/data/payments/payment_request_extra_shipping_options_test.html [rename] https://crrev.com/432cb34b6e2b52305b2ce64373117185513c707a/chrome/test/data/payments/payment_request_fail_complete_test.html [rename] https://crrev.com/432cb34b6e2b52305b2ce64373117185513c707a/chrome/test/data/payments/payment_request_free_shipping_test.html [rename] https://crrev.com/432cb34b6e2b52305b2ce64373117185513c707a/chrome/test/data/payments/payment_request_iframe.html [rename] https://crrev.com/432cb34b6e2b52305b2ce64373117185513c707a/chrome/test/data/payments/payment_request_main.html [rename] https://crrev.com/432cb34b6e2b52305b2ce64373117185513c707a/chrome/test/data/payments/payment_request_metrics_test.html [rename] https://crrev.com/432cb34b6e2b52305b2ce64373117185513c707a/chrome/test/data/payments/payment_request_multiple_requests.html [rename] https://crrev.com/432cb34b6e2b52305b2ce64373117185513c707a/chrome/test/data/payments/payment_request_name_and_free_shipping_test.html [rename] https://crrev.com/432cb34b6e2b52305b2ce64373117185513c707a/chrome/test/data/payments/payment_request_name_test.html [rename] https://crrev.com/432cb34b6e2b52305b2ce64373117185513c707a/chrome/test/data/payments/payment_request_no_shipping_test.html [rename] https://crrev.com/432cb34b6e2b52305b2ce64373117185513c707a/chrome/test/data/payments/payment_request_phone_and_free_shipping_test.html [rename] https://crrev.com/432cb34b6e2b52305b2ce64373117185513c707a/chrome/test/data/payments/payment_request_phone_test.html [rename] https://crrev.com/432cb34b6e2b52305b2ce64373117185513c707a/chrome/test/data/payments/payment_request_show_twice_test.html [rename] https://crrev.com/432cb34b6e2b52305b2ce64373117185513c707a/chrome/test/data/payments/phone.js [rename] https://crrev.com/432cb34b6e2b52305b2ce64373117185513c707a/chrome/test/data/payments/phone_and_free_shipping.js [rename] https://crrev.com/432cb34b6e2b52305b2ce64373117185513c707a/chrome/test/data/payments/show_twice.js [rename] https://crrev.com/432cb34b6e2b52305b2ce64373117185513c707a/chrome/test/data/payments/style.css [rename] https://crrev.com/432cb34b6e2b52305b2ce64373117185513c707a/chrome/test/data/payments/util.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a397e24fc14ad76c5e7d462eb7b934da031629b3 commit a397e24fc14ad76c5e7d462eb7b934da031629b3 Author: mathp <mathp@chromium.org> Date: Thu Jan 19 20:01:15 2017 [Payments] Introduce basic interactive browsertests for Payment Request According to code documentation [1], the tests need to be in "interactive_ui_tests" because they will need focus, and thus can't be sharded like regular browsertests. I also went with the approach of putting several test classes in the same file for a couple of reasons: we may not have many tests at first (thus little clutter), and it's easier to add a test when one can see what other tests are doing nearby. Certainly later on as these things are less true, we can split into multiple files as needed. Also want to mention that the tests are simplistic now; a follow-up CL will focus on View elements and click them. [1] https://cs.chromium.org/chromium/src/chrome/test/base/interactive_test_utils.h?rcl=0&l=37 BUG= 679734 TEST=./out/Default/interactive_ui_tests --gtest_filter=PaymentRequest* Review-Url: https://codereview.chromium.org/2631133003 Cr-Commit-Position: refs/heads/master@{#444825} [delete] https://crrev.com/a10ba600a7ad192660ded5dbe0ef94a559724452/chrome/browser/payments/payment_request_web_contents_manager_browsertest.cc [modify] https://crrev.com/a397e24fc14ad76c5e7d462eb7b934da031629b3/chrome/browser/ui/BUILD.gn [modify] https://crrev.com/a397e24fc14ad76c5e7d462eb7b934da031629b3/chrome/browser/ui/views/payments/payment_request_dialog.cc [modify] https://crrev.com/a397e24fc14ad76c5e7d462eb7b934da031629b3/chrome/browser/ui/views/payments/payment_request_dialog.h [add] https://crrev.com/a397e24fc14ad76c5e7d462eb7b934da031629b3/chrome/browser/ui/views/payments/payment_request_interactive_uitest.cc [add] https://crrev.com/a397e24fc14ad76c5e7d462eb7b934da031629b3/chrome/browser/ui/views/payments/payment_request_interactive_uitest_base.cc [add] https://crrev.com/a397e24fc14ad76c5e7d462eb7b934da031629b3/chrome/browser/ui/views/payments/payment_request_interactive_uitest_base.h [add] https://crrev.com/a397e24fc14ad76c5e7d462eb7b934da031629b3/chrome/browser/ui/views/payments/test_chrome_payment_request_delegate.cc [add] https://crrev.com/a397e24fc14ad76c5e7d462eb7b934da031629b3/chrome/browser/ui/views/payments/test_chrome_payment_request_delegate.h [modify] https://crrev.com/a397e24fc14ad76c5e7d462eb7b934da031629b3/chrome/test/BUILD.gn [modify] https://crrev.com/a397e24fc14ad76c5e7d462eb7b934da031629b3/components/payments/payment_request_web_contents_manager.cc [modify] https://crrev.com/a397e24fc14ad76c5e7d462eb7b934da031629b3/components/payments/payment_request_web_contents_manager.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b90312cf0db250b338a3b56f21a491d665b841bf commit b90312cf0db250b338a3b56f21a491d665b841bf Author: mathp <mathp@chromium.org> Date: Fri Jan 27 16:37:12 2017 [Payments] PR: Basic test for the order summary section. Tests the basic structure and navigation to the order summary page. BUG= 679734 TEST=PaymentRequest* interactive_ui_tests Review-Url: https://codereview.chromium.org/2656823006 Cr-Commit-Position: refs/heads/master@{#446685} [modify] https://crrev.com/b90312cf0db250b338a3b56f21a491d665b841bf/chrome/browser/ui/BUILD.gn [modify] https://crrev.com/b90312cf0db250b338a3b56f21a491d665b841bf/chrome/browser/ui/views/payments/order_summary_view_controller.cc [modify] https://crrev.com/b90312cf0db250b338a3b56f21a491d665b841bf/chrome/browser/ui/views/payments/payment_request_dialog_view.cc [modify] https://crrev.com/b90312cf0db250b338a3b56f21a491d665b841bf/chrome/browser/ui/views/payments/payment_request_dialog_view.h [add] https://crrev.com/b90312cf0db250b338a3b56f21a491d665b841bf/chrome/browser/ui/views/payments/payment_request_dialog_view_ids.h [modify] https://crrev.com/b90312cf0db250b338a3b56f21a491d665b841bf/chrome/browser/ui/views/payments/payment_request_interactive_uitest.cc [modify] https://crrev.com/b90312cf0db250b338a3b56f21a491d665b841bf/chrome/browser/ui/views/payments/payment_request_interactive_uitest_base.cc [modify] https://crrev.com/b90312cf0db250b338a3b56f21a491d665b841bf/chrome/browser/ui/views/payments/payment_request_interactive_uitest_base.h [modify] https://crrev.com/b90312cf0db250b338a3b56f21a491d665b841bf/chrome/browser/ui/views/payments/payment_sheet_view_controller.cc [modify] https://crrev.com/b90312cf0db250b338a3b56f21a491d665b841bf/chrome/browser/ui/views/payments/test_chrome_payment_request_delegate.h [modify] https://crrev.com/b90312cf0db250b338a3b56f21a491d665b841bf/chrome/test/data/payments/no_shipping.js
Comment 1 by bugdroid1@chromium.org
, Jan 10 2017