New issue
Advanced search Search tips

Issue 679714 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

[NoStatePrefetch] Raise in FINAL_STATUS_CANCELLED

Project Member Reported by droger@chromium.org, Jan 10 2017

Issue description

As seen on the Finch dashboard, FINAL_STATUS_CANCELLED raised from 0% to 18%, starting from Canary 57.0.2972.0.

Most likely cause is CL https://codereview.chromium.org/2614473002/, which was intended to increase the FINAL_STATUS_DUPLICATE status.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5b95a428b6dbbcdc487b23828e5637e0b69478b1

commit 5b95a428b6dbbcdc487b23828e5637e0b69478b1
Author: droger <droger@chromium.org>
Date: Wed Jan 11 10:16:39 2017

[NoStatePrefetch] Don't cancel prefetches when there are duplicates

AutocompleteActionPredictor::StartPrerendering actively destroys the existing
prerender when a new one is created, even if the new one is a duplicate.

Thus, when there is a duplicate prerender, PrerenderManager::AddPrerender
must return a handle to it, and not null. That way it increases the
reference count on the prerender and prevents it from being destroyed.

This can be done by simply changing the ordering of the existing code.

BUG= 679714 

Review-Url: https://codereview.chromium.org/2622893002
Cr-Commit-Position: refs/heads/master@{#442844}

[modify] https://crrev.com/5b95a428b6dbbcdc487b23828e5637e0b69478b1/chrome/browser/prerender/prerender_manager.cc
[modify] https://crrev.com/5b95a428b6dbbcdc487b23828e5637e0b69478b1/chrome/browser/prerender/prerender_unittest.cc

Comment 2 by droger@chromium.org, Jan 13 2017

Status: Fixed (was: Started)

Sign in to add a comment