Data URI should be allowed in media session metadata artwork |
|||
Issue descriptionChrome Canary (57.0.2974.0) OS: Android 7.1.1 What steps will reproduce the problem? (1) Go to https://beaufortfrancois.github.io/sandbox/media-session/data-blob.html (2) Start audio file (3) Click "Set Red Blob Artwork" (4) Check notification has a red artwork (5) Click "Set Green Data URI Artwork" What is the expected result? Notification should have a green artwork What happens instead? There is no notification artwork anymore.
,
Jan 10 2017
This is due to a recent change where we only allow HTTP status codes between [200, 300). However ImageDownloader returns 0 as HTTP status code for data URL, which should be 200.
,
Jan 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/56eb36cf3d8aea3d182695e7d518daa1a7a46a66 commit 56eb36cf3d8aea3d182695e7d518daa1a7a46a66 Author: zqzhang <zqzhang@chromium.org> Date: Wed Jan 11 17:48:54 2017 [MediaNotification] Don't check HTTP status code for image fetch ImageDownloader does not return valid HTTP status code for local URLs. This CL removes the check for HTTP status code from MediaImageManager, so that it only checks for the list of downloaded to see if the image fetch succeeded or not. This CL also adds tests for verifying ImageDownloader returns correct results. BUG= 679694 Review-Url: https://codereview.chromium.org/2625703002 Cr-Commit-Position: refs/heads/master@{#442949} [modify] https://crrev.com/56eb36cf3d8aea3d182695e7d518daa1a7a46a66/chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaImageManager.java [modify] https://crrev.com/56eb36cf3d8aea3d182695e7d518daa1a7a46a66/chrome/android/junit/src/org/chromium/chrome/browser/media/ui/MediaImageManagerTest.java [modify] https://crrev.com/56eb36cf3d8aea3d182695e7d518daa1a7a46a66/content/browser/web_contents/web_contents_impl_browsertest.cc
,
Jan 11 2017
,
Jan 12 2017
Verfied in Chromium 57.0.2980.0. Thanks! |
|||
►
Sign in to add a comment |
|||
Comment 1 by mlamouri@chromium.org
, Jan 10 2017Labels: -Pri-3 M-57 Pri-2
Status: Available (was: Untriaged)