New issue
Advanced search Search tips

Issue 679680 link

Starred by 1 user
Status: Duplicate
Merged: issue 679991
Owner:
xiaoche...@chromium.org
Closed: Jan 2017
Cc:
editing-dev@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocked on:
issue 679616


Sign in to add a comment

mostForwardCaretPosition and mostBackwardCaretPosition should be called with clean layout

Project Member Reported by xiaoche...@chromium.org, Jan 10 2017 
These two functions depend on clean layout tree, and should DCHECK that.

Currently some code paths do not call them with clean layout, which should be fixed.

Comment 1 by xiaoche...@chromium.org, Jan 11 2017 

Experiment: https://codereview.chromium.org/2623103003

Most DCHECK hits are via FrameSelection::updateSelectionIfNeeded. Unfortunately, we can't update layout there because the function is called in the middle of node update.

Comment 2 by xiaoche...@chromium.org, Jan 11 2017

Mergedinto: 679991
Status: Duplicate (was: Assigned)
►

Sign in to add a comment