New issue
Advanced search Search tips

Issue 679675 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug-Regression



Sign in to add a comment

PlzNavigate: regression on a few tests -- timeout for failed navigation within <object>

Project Member Reported by arthurso...@chromium.org, Jan 10 2017

Issue description

A regression happened introduced at this commit:
https://codereview.chromium.org/2563423004

The following layout tests are no more working with PlzNavigate.
- virtual/spv2/fast/overflow/overflow-height-float-not-removed-crash3.html
- fast/css/acid2-pixel.html
- fast/dom/HTMLObjectElement/children-changed.html
- imported/wpt/html/semantics/embedded-content/the-object-element/object-attributes.html
- fast/overflow/overflow-height-float-not-removed-crash2.html
- fast/table/giantCellspacing.html
- fast/overflow/overflow-height-float-not-removed-crash.html
- fast/overflow/overflow-height-float-not-removed-crash3.html
- fast/css/acid2.html

It happens when a navigation fails within an <object data="src"></object>.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/68693ab02e29631f4b484299fab89a66c768b01f

commit 68693ab02e29631f4b484299fab89a66c768b01f
Author: arthursonzogni <arthursonzogni@chromium.org>
Date: Wed Jan 25 11:55:52 2017

PlzNavigate: fix regression on the FYI bot.

It fixes a regression introduced in crrev.com/2563423004 for the
FYI bot: "Browser Side Navigation Linux".
It happens with Failed navigation within <object data=...>.
m_progressTracker->progressCompleted() lines were removed by the
previous commit and further call to it didn't happen with PlzNavigate.
It leads to a timeout in a few tests.

Tests fixed:
- virtual/spv2/fast/overflow/overflow-height-float-not-removed-crash3.html
- fast/css/acid2-pixel.html
- fast/dom/HTMLObjectElement/children-changed.html
- imported/wpt/html/semantics/embedded-content/the-object-element/object-attributes.html
- fast/overflow/overflow-height-float-not-removed-crash2.html
- fast/table/giantCellspacing.html
- fast/overflow/overflow-height-float-not-removed-crash.html
- fast/overflow/overflow-height-float-not-removed-crash3.html
- fast/css/acid2.html

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_browser_side_navigation_rel

BUG= 679675 

Review-Url: https://codereview.chromium.org/2624723002
Cr-Commit-Position: refs/heads/master@{#445997}

[modify] https://crrev.com/68693ab02e29631f4b484299fab89a66c768b01f/third_party/WebKit/Source/core/loader/FrameLoader.h
[modify] https://crrev.com/68693ab02e29631f4b484299fab89a66c768b01f/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp

Project Member

Comment 2 by bugdroid1@chromium.org, Jan 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6fc1c64c630cc76c40dc635cb4d39d3d28ee616b

commit 6fc1c64c630cc76c40dc635cb4d39d3d28ee616b
Author: arthursonzogni <arthursonzogni@chromium.org>
Date: Wed Jan 25 14:33:26 2017

PlzNavigate: update layout test filter.

This CL updates the layout test filter for PlzNavigate. Making this
NOTRY as there is no code changes and the filter is only used on a FYI
bot.

BUG= 679675 
NOTRY=true
TBR=clamy@chromium.org

Review-Url: https://codereview.chromium.org/2648383008
Cr-Commit-Position: refs/heads/master@{#446015}

[modify] https://crrev.com/6fc1c64c630cc76c40dc635cb4d39d3d28ee616b/third_party/WebKit/LayoutTests/FlagExpectations/enable-browser-side-navigation

Status: Fixed (was: Started)

Sign in to add a comment