New issue
Advanced search Search tips

Issue 679672 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Jul 17
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

Memory: Do something about deques in WebSocket code

Project Member Reported by ricea@chromium.org, Jan 10 2017

Issue description

Issue 674287 indicates that a 1-element std::deque uses 4KB on Android.

We use deques in the //net part of the WebSocket implementation:

1. std::deque<char> buffer_; in WebSocketDeflater
   Often will be several KB anyway, so not a problem?
2. std::deque<scoped_refptr<IOBufferWithSize> > in WebSocketInflater::InputQueue looks inefficient. Maybe short-lived?
3. std::queue<PendingReceivedFrame> pending_received_frames_; in WebSocketChannel will be inefficient if the renderer is slow.

The easiest thing would be to switch to std::list, but that's inefficient in its own ways.

WTF::Deque is not affected.
 
Labels: Performance

Comment 2 by benhenry@google.com, Jul 14 2017

Labels: -Performance Performance-Memory
Project Member

Comment 3 by sheriffbot@chromium.org, Jul 16

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Status: Fixed (was: Untriaged)
These have all been replaced by base::circular_deque or base::queue.

Sign in to add a comment