Memory: Do something about deques in WebSocket code |
||||
Issue descriptionIssue 674287 indicates that a 1-element std::deque uses 4KB on Android. We use deques in the //net part of the WebSocket implementation: 1. std::deque<char> buffer_; in WebSocketDeflater Often will be several KB anyway, so not a problem? 2. std::deque<scoped_refptr<IOBufferWithSize> > in WebSocketInflater::InputQueue looks inefficient. Maybe short-lived? 3. std::queue<PendingReceivedFrame> pending_received_frames_; in WebSocketChannel will be inefficient if the renderer is slow. The easiest thing would be to switch to std::list, but that's inefficient in its own ways. WTF::Deque is not affected.
,
Jul 14 2017
,
Jul 16
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 17
These have all been replaced by base::circular_deque or base::queue. |
||||
►
Sign in to add a comment |
||||
Comment 1 by tyoshino@chromium.org
, Jan 10 2017