New issue
Advanced search Search tips

Issue 679671 link

Starred by 1 user
Status: Fixed
Owner:
tmartino@chromium.org
Closed: Jan 2017
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

StartupBrowserCreatorFirstRunTest.RestoreOnStartupURLsPolicySpecified failing on Win10 Tests x64

Project Member Reported by foolip@chromium.org, Jan 10 2017 
https://findit-for-me.appspot.com/waterfall/build-failure?url=https://build.chromium.org/p/chromium.win/builders/Win10%20Tests%20x64/builds/7451
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=StartupBrowserCreatorFirstRunTest.RestoreOnStartupURLsPolicySpecified&testType=browser_tests

Here's one failure log:

StartupBrowserCreatorFirstRunTest.RestoreOnStartupURLsPolicySpecified (run #1):
[ RUN      ] StartupBrowserCreatorFirstRunTest.RestoreOnStartupURLsPolicySpecified
c:\c\win\src\chromerowser\ui\startup\startup_browser_creator_browsertest.cc(1071): error: Value of: tab_strip->count()
  Actual: 2
Expected: 1
[  FAILED  ] StartupBrowserCreatorFirstRunTest.RestoreOnStartupURLsPolicySpecified, where TypeParam =  and GetParam() =  (481 ms)

StartupBrowserCreatorFirstRunTest.RestoreOnStartupURLsPolicySpecified (run #2):
[ RUN      ] StartupBrowserCreatorFirstRunTest.RestoreOnStartupURLsPolicySpecified
c:\c\win\src\chromerowser\ui\startup\startup_browser_creator_browsertest.cc(1071): error: Value of: tab_strip->count()
  Actual: 2
Expected: 1
[  FAILED  ] StartupBrowserCreatorFirstRunTest.RestoreOnStartupURLsPolicySpecified, where TypeParam =  and GetParam() =  (520 ms)

StartupBrowserCreatorFirstRunTest.RestoreOnStartupURLsPolicySpecified (run #3):
[ RUN      ] StartupBrowserCreatorFirstRunTest.RestoreOnStartupURLsPolicySpecified
[3120:948:0110/014337.799:WARNING:ipc_message_attachment_set.cc(49)] MessageAttachmentSet destroyed with unconsumed attachments: 0/1
c:\c\win\src\chromerowser\ui\startup\startup_browser_creator_browsertest.cc(1071): error: Value of: tab_strip->count()
  Actual: 2
Expected: 1
[  FAILED  ] StartupBrowserCreatorFirstRunTest.RestoreOnStartupURLsPolicySpecified, where TypeParam =  and GetParam() =  (920 ms)

StartupBrowserCreatorFirstRunTest.RestoreOnStartupURLsPolicySpecified (run #4):
[ RUN      ] StartupBrowserCreatorFirstRunTest.RestoreOnStartupURLsPolicySpecified
c:\c\win\src\chromerowser\ui\startup\startup_browser_creator_browsertest.cc(1071): error: Value of: tab_strip->count()
  Actual: 2
Expected: 1
[  FAILED  ] StartupBrowserCreatorFirstRunTest.RestoreOnStartupURLsPolicySpecified, where TypeParam =  and GetParam() =  (897 ms)

FindIt thinks that https://crrev.com/a52322134679a349366417e04e502bc8ce1f68e4 is the cause, so reverting that.
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 10 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d38026c5a4b7a69552a4d7f41c37fdb735f0e283

commit d38026c5a4b7a69552a4d7f41c37fdb735f0e283
Author: foolip <foolip@chromium.org>
Date: Tue Jan 10 10:02:08 2017

Revert of Enabling kUseConsolidatedStartupFlow by default on trunk. (patchset #23 id:440001 of https://codereview.chromium.org/2475913003/ )

Reason for revert:
StartupBrowserCreatorFirstRunTest.RestoreOnStartupURLsPolicySpecified failing on Win10 Tests x64

BUG= 679671 

Original issue's description:
> Enabling kUseConsolidatedStartupFlow by default on trunk.
>
> Code changes:
> - Disabling onboarding content for ChromeOS. Promotions for CrOS are out-of-scope for this launch.
> - Ensuring that preference-specified tabs do not appear in new windows when a tabbed browser already exists for the profile.
>
> Test changes:
> - Removed 12 outdated tests
> - Fixed or updated 9 tests
>
> Details of affected tests, and rationale, can be found in this doc: https://docs.google.com/a/google.com/document/d/1PjAemEEFrl0gIDVQfnr1oAnHkb6DcV47HlOyyo7ICZI/edit?usp=sharing
>
> BUG=608875,314819, 313856 
>
> Review-Url: https://codereview.chromium.org/2475913003
> Cr-Commit-Position: refs/heads/master@{#442487}
> Committed: https://chromium.googlesource.com/chromium/src/+/a52322134679a349366417e04e502bc8ce1f68e4

TBR=pkasting@chromium.org,rsesek@chromium.org,tmartino@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=608875,314819, 313856 

Review-Url: https://codereview.chromium.org/2624443004
Cr-Commit-Position: refs/heads/master@{#442544}

[modify] https://crrev.com/d38026c5a4b7a69552a4d7f41c37fdb735f0e283/chrome/browser/app_controller_mac_browsertest.mm
[modify] https://crrev.com/d38026c5a4b7a69552a4d7f41c37fdb735f0e283/chrome/browser/ui/startup/startup_browser_creator_browsertest.cc
[modify] https://crrev.com/d38026c5a4b7a69552a4d7f41c37fdb735f0e283/chrome/browser/ui/startup/startup_browser_creator_triggered_reset_browsertest_win.cc
[modify] https://crrev.com/d38026c5a4b7a69552a4d7f41c37fdb735f0e283/chrome/browser/ui/startup/startup_features.cc
[modify] https://crrev.com/d38026c5a4b7a69552a4d7f41c37fdb735f0e283/chrome/browser/ui/startup/startup_tab_provider.cc
[modify] https://crrev.com/d38026c5a4b7a69552a4d7f41c37fdb735f0e283/chrome/browser/ui/startup/startup_tab_provider.h
[modify] https://crrev.com/d38026c5a4b7a69552a4d7f41c37fdb735f0e283/chrome/browser/ui/startup/startup_tab_provider_unittest.cc

Comment 2 by tmartino@chromium.org, Jan 13 2017

Status: Fixed (was: Assigned)
Fixed and re-landed.
►

Sign in to add a comment