Regression: In chrome:/downloads, blue focus ring for hyperlink does not stay for any download entry in progress.
Reported by
lpa...@etouch.net,
Jan 10 2017
|
|||||
Issue descriptionChrome Version: 57.0.2977.0 (Official Build) 20e4bfed4baf6f6eac0d7142bb9e763bc11512e4-refs/heads/master@{#442447} (32/64-bit) OS: Windows (7,8,10), Mac (10.11.6, 10.12.1), Linux (14.04 LTS) URL: http://www.thinkbroadband.com/download.html What steps will reproduce the problem? 1) Launch chrome, go to above URL and download any file (e.g 1 GB file). 2) Now in a new tab navigate to chrome://downloads. 3) Press Tab key till focus is on hyperlink for the download entry in progress and observe. Blue focus ring does not stay on hyperlink on pressing Tab key. Blue focus ring should stay on hyperlink on pressing Tab key. This is a Regression issue broken in M-57, will soon update other info Manual bisect: Good build: 57.0.2958.0 Bad build: 57.0.2959.0
,
Jan 11 2017
Minimum repro: data:text/html;charset=utf-8,<a href="http://www.gogole.com/" onfocus="this.href='https://www.google.com'">Google</a> 1. Open the above URL 2. Press TAB to focus the link.
,
Jan 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ef80b9a60d5b8809711ab18632705e09fe64e3c6 commit ef80b9a60d5b8809711ab18632705e09fe64e3c6 Author: tkent <tkent@chromium.org> Date: Wed Jan 11 10:28:34 2017 Updating href attribute should not blur. In HTMLAnchorElement::attributeChanged, params.name != hrefAttr && isLink() should have been params.name != hrefAttr || isLink() This CL fixes it, and improves code readability. BUG= 679669 Review-Url: https://codereview.chromium.org/2623163002 Cr-Commit-Position: refs/heads/master@{#442855} [delete] https://crrev.com/cb36c4939dda375f028ae61a6817e10d7de39161/third_party/WebKit/LayoutTests/fast/dom/HTMLAnchorElement/remove-href-from-focused-anchor.html [rename] https://crrev.com/ef80b9a60d5b8809711ab18632705e09fe64e3c6/third_party/WebKit/LayoutTests/fast/dom/HTMLAnchorElement/update-href-of-focused-anchor-expected.txt [add] https://crrev.com/ef80b9a60d5b8809711ab18632705e09fe64e3c6/third_party/WebKit/LayoutTests/fast/dom/HTMLAnchorElement/update-href-of-focused-anchor.html [modify] https://crrev.com/ef80b9a60d5b8809711ab18632705e09fe64e3c6/third_party/WebKit/Source/core/html/HTMLAnchorElement.cpp
,
Jan 11 2017
,
Sep 29 2017
,
Sep 29 2017
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by hdodda@chromium.org
, Jan 10 2017Labels: hasbisect-per-revision
Owner: tkent@chromium.org
Status: Assigned (was: Unconfirmed)