New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 679663 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
No longer actively working on Chrom...
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug


Show other hotlists

Hotlists containing this issue:
EnamelAndFriendsFixIt


Sign in to add a comment

Incognito content is persisted in landscape app switch

Reported by s...@hagennielsen.dk, Jan 10 2017

Issue description

Steps to reproduce the problem:
1. Open a page in an incognito tab
2. Turn the phone to landscape mode
3. Turn off the screen by clicking the power button
4. Unlock the screen again.
5. Turn back to portrait
6. Close the incognito tab
7. Switch to another app
8. Turn to landscape
9. Double tap the button to switch app.

The screenshot of the content in the closed incognito tab is now visible in the preview for app switch. This behaviour even persists after killing chrome and restarting it.

What is the expected behavior?
The app switch preview should not be allowed to show closed incognito content.

What went wrong?
The app did not clean up properly when closing the incognito tab.

Did this work before? N/A 

Chrome version: 55.0.2883.79  Channel: n/a
OS Version: iOS 10.2
Flash Version:
 
Components: UI>Browser>Incognito
Labels: -Type-Bug-Security -Restrict-View-SecurityTeam Team-Security-UX Type-Bug
Thanks for the report. This isn't something we'd usually consider a security vulnerability, but it may still be a bug. Adding the security UX team in case they're interested.
Components: Privacy
Labels: -Pri-2 M-48 Pri-1
Owner: lpromero@chromium.org
Status: Assigned (was: Unconfirmed)
Louis, you fixed similar bug (521131), could you please take a look at this one.
Cc: linds...@chromium.org cma...@chromium.org
Claude, Lindsay, by any chance do you know if this is a regression?
Labels: -M-48 M-57
Weird, the incognitoBlocker (https://cs.chromium.org/chromium/src/ios/chrome/app/application_delegate/app_state.mm?q=incognitoblocker&sq=package:chromium&l=195&dr=C) is correctly added and even inspecting the app UI when the screen is being locked shows the overlay.

Apple says to modify the UI in applicationDidEnterBackground (http://stackoverflow.com/a/18961652), which is what we do. Do they take the snapshot differently when locking the screen?

I'd be interested if this is only in iOS 10, or if it was there all along.

Note to repro I disabled the passcode (not sure if really necessary though).
This is an iOS/UIKit bug as I repro on the attached project.
TestScreenshot.zip
25.8 KB Download
Status: ExternalDependency (was: Assigned)
Area:
UIKit

Summary:
System screenshot taken before applicationDidEnterBackground leaks private data when locking screen

In https://developer.apple.com/library/content/documentation/iPhone/Conceptual/iPhoneOSProgrammingGuide/BackgroundExecution/BackgroundExecution.html#//apple_ref/doc/uid/TP40007072-CH4-SW8, there is this recommandation:

Remove sensitive information from views before moving to the background. When an app transitions to the background, the system takes a snapshot of the app’s main window, which it then presents briefly when transitioning your app back to the foreground. Before returning from your applicationDidEnterBackground: method, you should hide or obscure passwords and other sensitive personal information that might be captured as part of the snapshot.

This is correct when switching apps, but is broken when first locking the screen and when switching orientations. Please follow the repro steps closely with the minimalistic project attached.

Steps to Reproduce:
1. Launch Safari in portrait (to load an app that supports landscape orientation in the multitasking tray).
2. Launch the dummy app TestScreenshot in portrait. It shows "PRIVATE!".
3. Rotate to landscape.
4. Lock the screen. applicationDidEnterBackground is called and changes the label to "Concealed".
5. Unlock the screen.
6. Rotate to portrait.
7. Switch to Safari.
8. Rotate to landscape.
9. Double tap the Home button.

Expected Results:
The landscape screenshot for TestScreenshot shows "Concealed".

Actual Results:
The landscape screenshot for TestScreenshot shows "PRIVATE!".

Version:
iOS 10.1 and iOS 10.2. Others not tested.

Configuration:
iPhone 5S

Attachments:
'TestScreenshot.zip' and 'Screen Shot 2017-01-12 at 20.17.57.png' were successfully uploaded.

Comment 7 by pkl@chromium.org, Jan 18 2017

Cc: gch...@chromium.org edchin@chromium.org
Labels: -M-57
Removing milestone.
Cc: pinkerton@chromium.org
Labels: -Pri-1 Pri-2
lpromero: can you put the radar number in the bug so i can escalate to apple?

Lowering to P2 since it requires an OS fix. 
rdar://657297451
This is reproducible on iOS 9.3.5 on iPhone 6 on build 58.0.3029.33dev
Labels: Hotlist-EnamelAndFriendsFixIt
Status: Fixed (was: ExternalDependency)
Looks fixed on iOS 11. I tested on iPhone 7 Plus iOS 11.1.1 and iPhone X 11.1.2.

Sign in to add a comment