"Failed to fetch custom actions." error in console, for mounted zip files |
|||||||||
Issue descriptionChrome Version: 57.0.2958.0 Chrome OS Version: 9034.0.0 Chrome OS Platform: Chromebook Pixel Steps To Reproduce: (1) Open a zip file in Files app to mount it. (2) [ctrl] + [shift] + j to open the javascript console for foreground scripts. (3) Click the mounted volume on the left pane. (4) See the javascript console. Expected Result: No errors. Actual Result: "Failed to fetch custom actions because of: Failed to fetch actions." How frequently does this problem reproduce? (Always, sometimes, hard to reproduce?) Always. What is the impact to the user, and is there a workaround? If so, what is it? No direct impact, but might be related to other issues like Issue 678191 .
,
Feb 22 2017
,
Feb 22 2017
,
Feb 22 2018
,
Feb 23 2018
,
Feb 28 2018
,
Oct 31
,
Nov 19
,
Nov 19
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c07a7947d4e93b35f5abcca3d2dddffa0aa2f4d0 commit c07a7947d4e93b35f5abcca3d2dddffa0aa2f4d0 Author: Anand K. Mistry <amistry@chromium.org> Date: Mon Nov 19 03:28:19 2018 Implement a dummy onGetActionsRequested listener. The FSP implementation doesn't handle the difference between "not implemented" and "error". Zip archiver doesn't provide any custom actions, but FSP interprets this as an error and that bubbles back to the Files App. BUG= 679634 Change-Id: I5b52c64b0d01bd700ea4509d046630396afa756c Reviewed-on: https://chromium-review.googlesource.com/c/1341435 Reviewed-by: Sam McNally <sammc@chromium.org> Commit-Queue: Anand Mistry <amistry@chromium.org> Cr-Commit-Position: refs/heads/master@{#609171} [modify] https://crrev.com/c07a7947d4e93b35f5abcca3d2dddffa0aa2f4d0/chrome/browser/resources/chromeos/zip_archiver/js/background.js
,
Nov 19
,
Dec 28
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/46acbaaac08d30f8c32ec217ef29c1b4a721eb66 commit 46acbaaac08d30f8c32ec217ef29c1b4a721eb66 Author: Sam McNally <sammc@chromium.org> Date: Fri Dec 28 09:33:31 2018 Treat unimplemented onGetActionsRequested event handling as success. Some filesystem providers don't seem to implement this, so reporting errors whenever one is encountered is not useful. Return an empty result in those cases instead of an error. Remove the dummy implementation in zip archiver to simplify code and avoid polluting metrics. Bump its version number to force Chrome to launch its background page and notice the absent event handler. Bug: 679634 Change-Id: I7153bb419e0f2888e8675b292142a581b0e17cf0 Reviewed-on: https://chromium-review.googlesource.com/c/1381353 Reviewed-by: Anand Mistry <amistry@chromium.org> Reviewed-by: Naoki Fukino <fukino@chromium.org> Commit-Queue: Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#619135} [modify] https://crrev.com/46acbaaac08d30f8c32ec217ef29c1b4a721eb66/chrome/browser/chromeos/file_system_provider/provided_file_system.cc [modify] https://crrev.com/46acbaaac08d30f8c32ec217ef29c1b4a721eb66/chrome/browser/resources/chromeos/zip_archiver/js/background.js [modify] https://crrev.com/46acbaaac08d30f8c32ec217ef29c1b4a721eb66/chrome/browser/resources/chromeos/zip_archiver/manifest.json |
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by yamaguchi@chromium.org
, Jan 10 2017