Get rid of Document::m_updateFocusAppearanceSelectionBahavior |
|||
Issue descriptionDocument::m_updateFocusAppearanceSelectionBahavior is used for passing SelectionBehaviorOnFocus value to Document::updateFocusAppearanceTimerFired() and it is set by Document::updateFocusAppearanceSoon(). However, all call sites of Document::updateFocusAppearanceSoon(), only two call sites in HTMLInputElement, pass SelectionBehaviorOnFocus::Restore. Given that, we don't need to have m_updateFocusAppearanceSelectionBahavior
,
Jan 13 2017
,
Jan 16 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/32bac3b4c95c52cc6820ea90bf60e24e0c745ff0 commit 32bac3b4c95c52cc6820ea90bf60e24e0c745ff0 Author: tkent <tkent@chromium.org> Date: Mon Jan 16 04:45:55 2017 Remove SelectionBehaviorOnFocus argument of Document::updateFocusAppearanceSoon(). The argument was always SelectionBehaviorOnFocus::Restore. Also, rename it to updateFocusAppearanceLater(). This CL removes one callsite in HTMLInputElement::attachLayoutTree(). It was necessary because WebKit recreated Shadow DOM whenever RenderObject was recreated. [1] [1] https://bugs.webkit.org/show_bug.cgi?id=34620 BUG= 679631 Review-Url: https://codereview.chromium.org/2634453003 Cr-Commit-Position: refs/heads/master@{#443846} [modify] https://crrev.com/32bac3b4c95c52cc6820ea90bf60e24e0c745ff0/third_party/WebKit/Source/core/dom/Document.cpp [modify] https://crrev.com/32bac3b4c95c52cc6820ea90bf60e24e0c745ff0/third_party/WebKit/Source/core/dom/Document.h [modify] https://crrev.com/32bac3b4c95c52cc6820ea90bf60e24e0c745ff0/third_party/WebKit/Source/core/html/HTMLInputElement.cpp
,
Jan 16 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by dominicc@chromium.org
, Jan 13 2017