New issue
Advanced search Search tips

Issue 679630 link

Starred by 1 user
Status: Available
Owner: ----
Cc:
tkent@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task



Sign in to add a comment

We should rename Element::UpdateFocusAppearance() to appropriate one

Project Member Reported by yosin@chromium.org, Jan 10 2017 
The name of updateFocusAppearance() is misleading since HTMLInputElement::updateFocusAppearance() change selection and more things other than just changing appearance of the element.

Comment 1 by dominicc@chromium.org, Jan 19 2017

Cc: dominicc@chromium.org
Owner: yosin@chromium.org
Status: Assigned (was: Untriaged)
What should it be renamed to?

Comment 2 by tkent@chromium.org, Feb 7 2017

Labels: -Type-Bug Type-Task

Comment 3 by yosin@chromium.org, Mar 23 2017

Owner: ----
Status: Available (was: Assigned)
My proposal is Element::didSetFocus().

Document::updateFocusAppearanceTimerFired() is the only call site which is not
fit this name.

Comment 4 by benhenry@chromium.org, Sep 29 2017

Components: Blink>HTML>Focus

Comment 5 by benhenry@chromium.org, Sep 29 2017

Components: -Blink>Focus
Project Member

Comment 6 by sheriffbot@chromium.org, Oct 1

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 7 by tkent@chromium.org, Oct 2

Cc: -dominicc@chromium.org
Components: -Blink>HTML
Labels: -Hotlist-Recharge-Cold Hotlist-CodeHealth
Status: Available (was: Untriaged)
Summary: We should rename Element::UpdateFocusAppearance() to appropriate one (was: We should rename Element::updateFocusAppearance() to appropriate one)
►

Sign in to add a comment