New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 679607 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
OOO until 2019-01-24
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug

Blocked on:
issue 673921

Blocking:
issue 663188
issue 680002



Sign in to add a comment

Switch Mac Intel GPU bots to 10.12 from 10.10

Project Member Reported by kbr@chromium.org, Jan 10 2017

Issue description

The Mac Minis in the Swarming pool are currently running 10.10. They should be upgraded to 10.12 so they're testing a recent OS version.

 

Comment 1 by kbr@chromium.org, Jan 10 2017

Cc: geoffl...@chromium.org jmad...@chromium.org
Components: Internals>GPU>ANGLE Blink>WebGL
Tryjob:
https://codereview.chromium.org/2627553002/

There are a couple of WebGL 2.0 and ANGLE test failures that need to be suppressed.

Project Member

Comment 2 by bugdroid1@chromium.org, Jan 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/angle/angle/+/bb1db48ed5c7607fbd18e35b57080a28386d8d7e

commit bb1db48ed5c7607fbd18e35b57080a28386d8d7e
Author: Jamie Madill <jmadill@chromium.org>
Date: Tue Jan 10 15:48:32 2017

Suppress two new failing tests on OSX 10.12 Intel.

BUG= chromium:679607 

Change-Id: Iacba3958dc942d7830caec8e053148533bff4069
Reviewed-on: https://chromium-review.googlesource.com/425872
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

[modify] https://crrev.com/bb1db48ed5c7607fbd18e35b57080a28386d8d7e/src/tests/gl_tests/TextureTest.cpp

Project Member

Comment 3 by bugdroid1@chromium.org, Jan 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/angle/angle/+/bb1db48ed5c7607fbd18e35b57080a28386d8d7e

commit bb1db48ed5c7607fbd18e35b57080a28386d8d7e
Author: Jamie Madill <jmadill@chromium.org>
Date: Tue Jan 10 15:48:32 2017

Suppress two new failing tests on OSX 10.12 Intel.

BUG= chromium:679607 

Change-Id: Iacba3958dc942d7830caec8e053148533bff4069
Reviewed-on: https://chromium-review.googlesource.com/425872
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

[modify] https://crrev.com/bb1db48ed5c7607fbd18e35b57080a28386d8d7e/src/tests/gl_tests/TextureTest.cpp

Project Member

Comment 4 by bugdroid1@chromium.org, Jan 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/806ee17727dce5a50eff16b2010b4189751370cd

commit 806ee17727dce5a50eff16b2010b4189751370cd
Author: geofflang <geofflang@chromium.org>
Date: Tue Jan 10 23:00:12 2017

Roll ANGLE 037340d..98e3407

https://chromium.googlesource.com/angle/angle.git/+log/037340d..98e3407

BUG=chromium:678526, chromium:679607 ,chromium:679725

TBR=jmadill@chromium.org

TEST=bots

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2623983002
Cr-Commit-Position: refs/heads/master@{#442718}

[modify] https://crrev.com/806ee17727dce5a50eff16b2010b4189751370cd/DEPS

Comment 5 by kbr@chromium.org, Jan 10 2017

Blocking: 663188
The RGB9_E5 suppressions will need to be added. Doing them and referencing  Issue 663188 .

Comment 6 by kbr@chromium.org, Jan 11 2017

https://codereview.chromium.org/2627553002/ cuts over these bots to run their tests exclusively on 10.12.

Comment 7 by kbr@chromium.org, Jan 11 2017

Blocking: 680002
Project Member

Comment 8 by bugdroid1@chromium.org, Jan 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/441e2bf997a5a78a92c5b49b391b852e065713fa

commit 441e2bf997a5a78a92c5b49b391b852e065713fa
Author: kbr <kbr@chromium.org>
Date: Wed Jan 11 06:46:15 2017

Switch Mac Intel GPU jobs to target 10.12 bots instead of 10.10.

BUG= 679607 ,  663188 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=zmo@chromium.org
NOTRY=true

Review-Url: https://codereview.chromium.org/2627553002
Cr-Commit-Position: refs/heads/master@{#442828}

[modify] https://crrev.com/441e2bf997a5a78a92c5b49b391b852e065713fa/content/test/gpu/generate_buildbot_json.py
[modify] https://crrev.com/441e2bf997a5a78a92c5b49b391b852e065713fa/content/test/gpu/gpu_tests/test_expectations.py
[modify] https://crrev.com/441e2bf997a5a78a92c5b49b391b852e065713fa/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py
[modify] https://crrev.com/441e2bf997a5a78a92c5b49b391b852e065713fa/testing/buildbot/chromium.gpu.fyi.json
[modify] https://crrev.com/441e2bf997a5a78a92c5b49b391b852e065713fa/testing/buildbot/chromium.gpu.json

Comment 9 by kbr@chromium.org, Jan 11 2017

Status: Fixed (was: Started)
We shouldn't be running GPU tests on the 10.10 Mac Minis any more.

Project Member

Comment 10 by bugdroid1@chromium.org, Jan 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/117c52b0a0add3b82ca354e6a2d3dd2be54abc25

commit 117c52b0a0add3b82ca354e6a2d3dd2be54abc25
Author: Philip Jägenstedt <foolip@chromium.org>
Date: Wed Jan 11 09:25:44 2017

Speculatively clobber Mac after "Switch Mac Intel GPU bots to 10.12 from 10.10"

Something in this range broke the Mac builder:
https://chromium.googlesource.com/chromium/src/+log/c6e4c6f1f9865b5a77d2cc4eb8c7104b632624f1%5E..1a7740c44a6c4d03423c4b5ff7d746e1a1b7363e?pretty=fuller

r442828 is the most obvious candidate which may have affected builds.

BUG= 679607 
TBR=kbr@chromium.org

Review-Url: https://codereview.chromium.org/2626993002 .
Cr-Commit-Position: refs/heads/master@{#442832}

[modify] https://crrev.com/117c52b0a0add3b82ca354e6a2d3dd2be54abc25/build/get_landmines.py

Comment 11 by kbr@chromium.org, Jan 11 2017

Cc: foolip@chromium.org
foolip@: could you please provide a link to the broken build? Did the landmine fix it? My change did not affect compilation, so I doubt it was the cause of the problem you saw.

Sign in to add a comment