New issue
Advanced search Search tips

Issue 679603 link

Starred by 2 users
Status: Fixed
Owner:
sclit...@chromium.org
Closed: Jan 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Remove uses of std::deque in data_reduction_proxy code

Project Member Reported by sclit...@chromium.org, Jan 10 2017 
According to Issue 674287, std::deque is quite memory inefficient when there's a small number of elements, especially on Android.

The data_reduction_proxy code currently uses std::deque in one place, which should be replaced to save memory.

https://cs.chromium.org/search/?q=deque+file:%5Esrc/components/data_reduction_proxy&sq=package:chromium&type=cs
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 12 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c37c6180c36f4c69be3bdccafbbc2a2bee556ed7

commit c37c6180c36f4c69be3bdccafbbc2a2bee556ed7
Author: sclittle <sclittle@chromium.org>
Date: Thu Jan 12 00:17:32 2017

Replace std::deque usage in drp_event_store with a circular buffer.

Since std::deque is memory inefficient for small numbers of elements,
especially on Android, (see http://crbug.com/674287), this CL replaces
the std::deque in DataReductionProxyEventStore with a simple circular
buffer.

BUG= 679603 

Review-Url: https://codereview.chromium.org/2619373003
Cr-Commit-Position: refs/heads/master@{#443073}

[modify] https://crrev.com/c37c6180c36f4c69be3bdccafbbc2a2bee556ed7/components/data_reduction_proxy/core/common/data_reduction_proxy_event_store.cc
[modify] https://crrev.com/c37c6180c36f4c69be3bdccafbbc2a2bee556ed7/components/data_reduction_proxy/core/common/data_reduction_proxy_event_store.h

Comment 2 by sclit...@chromium.org, Jan 12 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment