New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 679574 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

Clean-up: media::PipelineMetadata::natural_size consistently store the rotated video size

Project Member Reported by x...@chromium.org, Jan 10 2017

Issue description

Currently media::PipelineMetadata::natural_size stores either the original video natural size or the rotated size. To avoid confusion, it should consistently store the rotated video natural size since all currently applications require the rotated size.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/15b483f7dc564d1aaf60e8c400b03cf78ab2f7d5

commit 15b483f7dc564d1aaf60e8c400b03cf78ab2f7d5
Author: xjz <xjz@chromium.org>
Date: Thu Jan 12 00:21:36 2017

Clean-up: media::PipelineMetadata stores the rotated video size.

media::PipelineMetadata::natural_size could be either the orignal
video natural size or the rotated one when VideoRotation indicates a
90 degree rotation. To avoid confusion, this Cl let it always store
the video natural size after rotation.

BUG= 679574 

Review-Url: https://codereview.chromium.org/2622803002
Cr-Commit-Position: refs/heads/master@{#443076}

[modify] https://crrev.com/15b483f7dc564d1aaf60e8c400b03cf78ab2f7d5/media/base/pipeline_impl.cc
[modify] https://crrev.com/15b483f7dc564d1aaf60e8c400b03cf78ab2f7d5/media/base/pipeline_metadata.h
[modify] https://crrev.com/15b483f7dc564d1aaf60e8c400b03cf78ab2f7d5/media/blink/webmediaplayer_impl.cc
[modify] https://crrev.com/15b483f7dc564d1aaf60e8c400b03cf78ab2f7d5/media/blink/webmediaplayer_impl_unittest.cc
[modify] https://crrev.com/15b483f7dc564d1aaf60e8c400b03cf78ab2f7d5/media/remoting/remoting_renderer_controller.cc

Comment 2 by x...@chromium.org, Jan 12 2017

Status: Fixed (was: Started)

Sign in to add a comment