New issue
Advanced search Search tips

Issue 679569 link

Starred by 2 users

Issue metadata

Status: Duplicate
Merged: issue 679470
Owner: ----
Closed: Jan 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

"ExtensionBrowserTest.OverrideStartupPagesSettings" is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, Jan 10 2017

Issue description

"ExtensionBrowserTest.OverrideStartupPagesSettings" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyPAsSBUZsYWtlIjFFeHRlbnNpb25Ccm93c2VyVGVzdC5PdmVycmlkZVN0YXJ0dXBQYWdlc1NldHRpbmdzDA.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
 

Comment 1 by foolip@chromium.org, Jan 10 2017

Likely the same as  issue 679470 .

Comment 2 by foolip@chromium.org, Jan 10 2017

Mergedinto: 679470
Status: Duplicate (was: Untriaged)
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8534d16a27bc5999a28c0d964e1a5b5409617b39

commit 8534d16a27bc5999a28c0d964e1a5b5409617b39
Author: foolip <foolip@chromium.org>
Date: Tue Jan 10 16:51:03 2017

Revert of Make extensions DSE persistent in browser prefs (patchset #15 id:280001 of https://codereview.chromium.org/2479113002/ )

Reason for revert:
ExtensionBrowserTest.OverrideHomePageSettings and ExtensionBrowserTest.OverrideStartupPagesSettings are flaky.

BUG= 679470 , 679569 

Original issue's description:
> Make extensions DSE persistent in browser prefs
>
> This fix stores extension installed DSE in browser prefs using extension
> overriden preferences API. This is needed so extension installed default
> search would be available from browser before extensions subsystem load.
> This will affect url for first loaded NTP which is taken from current
> default search settings.
>
> BUG= 450534 
>
> R=pkasting@chromium.org, vasilii@chromium.org
>
> Review-Url: https://codereview.chromium.org/2479113002
> Cr-Commit-Position: refs/heads/master@{#442235}
> Committed: https://chromium.googlesource.com/chromium/src/+/f5f1407adee2b18b59b33fb8d74739dcc27d8c0b

TBR=gab@chromium.org,hashimoto@chromium.org,maxbogue@chromium.org,pkasting@chromium.org,vasilii@chromium.org,a-v-y@yandex-team.ru
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG= 450534 

Review-Url: https://codereview.chromium.org/2623833005
Cr-Commit-Position: refs/heads/master@{#442612}

[modify] https://crrev.com/8534d16a27bc5999a28c0d964e1a5b5409617b39/chrome/browser/extensions/api/settings_overrides/settings_overrides_api.cc
[modify] https://crrev.com/8534d16a27bc5999a28c0d964e1a5b5409617b39/chrome/browser/extensions/api/settings_overrides/settings_overrides_api.h
[modify] https://crrev.com/8534d16a27bc5999a28c0d964e1a5b5409617b39/chrome/browser/extensions/api/settings_overrides/settings_overrides_browsertest.cc
[modify] https://crrev.com/8534d16a27bc5999a28c0d964e1a5b5409617b39/chrome/browser/prefs/session_startup_pref.h
[modify] https://crrev.com/8534d16a27bc5999a28c0d964e1a5b5409617b39/chrome/browser/search_engines/template_url_service_sync_unittest.cc
[modify] https://crrev.com/8534d16a27bc5999a28c0d964e1a5b5409617b39/chrome/browser/search_engines/template_url_service_test_util.cc
[modify] https://crrev.com/8534d16a27bc5999a28c0d964e1a5b5409617b39/chrome/browser/search_engines/template_url_service_test_util.h
[modify] https://crrev.com/8534d16a27bc5999a28c0d964e1a5b5409617b39/chrome/browser/search_engines/template_url_service_unittest.cc
[modify] https://crrev.com/8534d16a27bc5999a28c0d964e1a5b5409617b39/components/search_engines/BUILD.gn
[modify] https://crrev.com/8534d16a27bc5999a28c0d964e1a5b5409617b39/components/search_engines/default_search_manager.cc
[modify] https://crrev.com/8534d16a27bc5999a28c0d964e1a5b5409617b39/components/search_engines/default_search_manager.h
[modify] https://crrev.com/8534d16a27bc5999a28c0d964e1a5b5409617b39/components/search_engines/default_search_manager_unittest.cc
[delete] https://crrev.com/2cad8b6680852a10a9e6e342c8b78dd701e8c656/components/search_engines/search_engines_test_util.cc
[delete] https://crrev.com/2cad8b6680852a10a9e6e342c8b78dd701e8c656/components/search_engines/search_engines_test_util.h
[modify] https://crrev.com/8534d16a27bc5999a28c0d964e1a5b5409617b39/components/search_engines/template_url.cc
[modify] https://crrev.com/8534d16a27bc5999a28c0d964e1a5b5409617b39/components/search_engines/template_url.h
[modify] https://crrev.com/8534d16a27bc5999a28c0d964e1a5b5409617b39/components/search_engines/template_url_prepopulate_data.cc
[modify] https://crrev.com/8534d16a27bc5999a28c0d964e1a5b5409617b39/components/search_engines/template_url_prepopulate_data.h
[modify] https://crrev.com/8534d16a27bc5999a28c0d964e1a5b5409617b39/components/search_engines/template_url_service.cc
[modify] https://crrev.com/8534d16a27bc5999a28c0d964e1a5b5409617b39/components/search_engines/template_url_service.h

Sign in to add a comment