New issue
Advanced search Search tips

Issue 679568 link

Starred by 1 user
Status: Fixed
Owner:
sclit...@chromium.org
Closed: Apr 2017
Cc:
rajendrant@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Remove uses of std::deque in data_usage code

Project Member Reported by sclit...@chromium.org, Jan 10 2017 
According to Issue 674287, std::deque is quite memory inefficient when there's a small number of elements, especially on Android.

The data_usage code currently uses std::deque in a few places, and these uses should be removed to save memory, e.g. by replacing them with std::vector.

https://cs.chromium.org/search/?q=deque+file:%5Esrc/chrome/browser/android/data_usage/&sq=package:chromium&type=cs
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 12 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dfc7302588449730604019c9ca057bcbf83544d0

commit dfc7302588449730604019c9ca057bcbf83544d0
Author: sclittle <sclittle@chromium.org>
Date: Thu Jan 12 00:08:35 2017

Changed uses of deque to vector in chrome/browser/android/data_usage.

chrome/browser/android/data_usage has a few uses of std::deque that
would work just about as well using std::vector, and since std::deque is
memory inefficient for small numbers of elements (see
http://crbug.com/674287), this CL replaces those uses of std::deque with
std::vector.

BUG= 679568 

Review-Url: https://codereview.chromium.org/2624663002
Cr-Commit-Position: refs/heads/master@{#443066}

[modify] https://crrev.com/dfc7302588449730604019c9ca057bcbf83544d0/chrome/browser/android/data_usage/external_data_use_observer.cc
[modify] https://crrev.com/dfc7302588449730604019c9ca057bcbf83544d0/chrome/browser/android/data_usage/external_data_use_observer.h
[modify] https://crrev.com/dfc7302588449730604019c9ca057bcbf83544d0/chrome/browser/android/data_usage/external_data_use_reporter.cc
[modify] https://crrev.com/dfc7302588449730604019c9ca057bcbf83544d0/chrome/browser/android/data_usage/external_data_use_reporter.h
[modify] https://crrev.com/dfc7302588449730604019c9ca057bcbf83544d0/chrome/browser/android/data_usage/external_data_use_reporter_unittest.cc
[modify] https://crrev.com/dfc7302588449730604019c9ca057bcbf83544d0/chrome/browser/android/data_usage/tab_data_use_entry.cc
[modify] https://crrev.com/dfc7302588449730604019c9ca057bcbf83544d0/chrome/browser/android/data_usage/tab_data_use_entry.h
[modify] https://crrev.com/dfc7302588449730604019c9ca057bcbf83544d0/chrome/browser/android/data_usage/tab_data_use_entry_unittest.cc

Comment 2 by sclit...@chromium.org, Apr 5 2017

Status: Fixed (was: Started)
►

Sign in to add a comment