New issue
Advanced search Search tips

Issue 679564 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug-Regression



Sign in to add a comment

windows switched automatically to the previous focus window under win10's default chinese Microsoft Pinyin IME

Reported by may...@gmail.com, Jan 10 2017

Issue description

UserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/54.0.2840.99 Safari/537.36

Steps to reproduce the problem:
1. Use CTRL+N to open at least 2 windows while both of them are maximized
2. On one of the window (window 1), click the URL bar and switch IME to Microsoft Pinyin which is win10's default chinese IME input, and input something. The purpose is to make sure the focus is on the window 1.
3. Click another window(window 2) on the win10's task bar. It will switch to that window 2 for a very short time like 0.1s then automatically switched back to the previous window 1.

What is the expected behavior?
When we click window B task from Win10's task bar, window B should be showed out.

What went wrong?
When we click window B task from Win10's task bar, finally window A which has the previous IME focus showed out.

Did this work before? Yes 54.0.2840.99

Chrome version: 55.0.2883  Channel: stable
OS Version: 10.0
Flash Version: Shockwave Flash 24.0 r0
 

Comment 1 by ajha@chromium.org, Jan 10 2017

Labels: Needs-Triage-M55 Needs-Bisect

Comment 2 Deleted

Comment 3 by may...@gmail.com, Jan 10 2017

My win10 use English language as default language.

And under the default ENG language US keyboard I didn't see any issue.

I'm having the issue when using the win10's default chinese input Microsoft Pinyin.

Also it works previously with the previous stable release 54.0.2840.99, so should be something wrong in Chrome.
Cc: kkaluri@chromium.org
Labels: Needs-Feedback
Unable to reproduce the issue on windows 10 with chrome version #55.0.2883.87.
These are the steps i followed.
1. Installed the Chinese simplified language and made it as default.
2. Opened two chrome windows using ctrl + N command and maximized it.
3. In the window-1 omnibox, typed some random text in Chinese language
4. Now switched to Window-2, by clicking on the task-bar.
Observed that  window-2 is on top and didn't switched back to window-1.

Attaching the screen-cast for your reference, could you please try the same scenario with new profile with no apps & extensions and let us know your observations.
Issue 679564.mp4
1.7 MB View Download
Hi kkaluri,

I can reproduce the issue.
Try this: 
1. right click on windown 10 taskbar select "Setting" 

2. Under "combine taskbar buttons" select never or "when taskbar is full", if you select "when taskbar is full" make sure the multiple chrome windows isn't combined.

3. under default english language US keyboard open multiple chrome windows maximized on same monitor.

4. click window A's URL bar and switch to Microsoft Pinyin IME, and type something.

5. click another window B's icon button on the windows 10's task bar. It maybe reproduced. If the issue isn't reproduced click on the window B's URL bar and use the microsoft PINYIN to input something.

6. repeat step 5 and do the same thing on window C

7. click window A's icon button on the windows 10's task bar.

8. click window B's icon button on the windows 10's task bar.

9. click window C's icon button on the windows 10's task bar.



Comment 6 by may...@gmail.com, Jan 11 2017

Hi kaluri,

Agree with raconter, you need to disable the task bar button combine. 

I also can't reproduce the issue when the multiple windows are combined to one icon button on the task bar, when they are combined you have to first click the button then select the window again which are twice clicks.

Please try to not combine the multiple windows to one taskbar button. 

Thanks.
mayerd@ in order to triage this issue could you please help us with the screen-cast  for the issue you are facing.

Thank You...

Comment 8 Deleted

Comment 9 by may...@gmail.com, Jan 12 2017

Hi kaluri,

I knew why you can't reproduce the issue.
There are 2 critical points:
1. make sure the chrome button on the taskbar are not combined.
2. change the Microsoft Pinyin IME config as in this attached screen recording. Set the "Choose how long to show the floating IME mode icon" to "1 second".

Then it can be easily reproduced by only 2 chrome windows.

The previous stable version 54.0.2840.99 doesn't have this issue.

Recording2.mp4
4.3 MB View Download

Comment 10 by may...@gmail.com, Jan 12 2017

Set the "Choose how long to show the floating IME mode icon" to "3 seconds" also can reproduce the issue same as the "1 second" config.

Set it to "never" won't trigger the issue.
Labels: -Needs-Feedback -Needs-Bisect
Owner: shuchen@chromium.org
Status: Assigned (was: Unconfirmed)
 mayerd@ Thank you for your detailed response, able to reproduce the issue with provided steps in comment #9 on windows 10 with chrome stable version #55.0.2883.87 and also in beta #56.0.2924.59, dev #57.0.2970.0, canary #57.0.2978.0 
Issue broken in M55

Bisect Info:
===========
Good build : 55.0.2883.28
Bad build  : 55.0.2883.29  

On manually looking between the CL's between good and bad builds
------------------------------------
https://chromium.googlesource.com/chromium/src/+log/55.0.2883.28..55.0.2883.29?pretty=fuller&n=10000

The suspecting Change Log is :
-----------
https://chromium.googlesource.com/chromium/src/+/a41a950192808e991cf550748a25bf51ba18f034

From the above CL suspecting the below change
---------------------------
Review-Url: https://codereview.chromium.org/2445253002

ShuChen@- Could you please look into this issue, if it's related to your change?  if not could you please help us to reassign this issue to the right owner.



Labels: -Pri-2 M-57 Pri-1
Status: Started (was: Assigned)
Project Member

Comment 14 by bugdroid1@chromium.org, Feb 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/17c78241a37810aff596974cfdec60b01bc0f4c5

commit 17c78241a37810aff596974cfdec60b01bc0f4c5
Author: shuchen <shuchen@chromium.org>
Date: Sat Feb 18 13:53:24 2017

Updates the IME state when necessary when switching top-level windows.

BUG= 679564 , 680524 

Review-Url: https://codereview.chromium.org/2700933002
Cr-Commit-Position: refs/heads/master@{#451460}

[modify] https://crrev.com/17c78241a37810aff596974cfdec60b01bc0f4c5/ui/base/ime/input_method_win.cc
[modify] https://crrev.com/17c78241a37810aff596974cfdec60b01bc0f4c5/ui/base/ime/input_method_win.h

Labels: Merge-Request-57
Project Member

Comment 16 by sheriffbot@chromium.org, Feb 20 2017

Labels: -Merge-Request-57 Hotlist-Merge-Approved Merge-Approved-57
Your change meets the bar and is auto-approved for M57. Please go ahead and merge the CL to branch 2987 manually. Please contact milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), ketakid@(cros), govind@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 17 by bugdroid1@chromium.org, Feb 20 2017

Labels: -merge-approved-57 merge-merged-2987
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/062cdaa73def7c1e0093db181810aaed74b6d182

commit 062cdaa73def7c1e0093db181810aaed74b6d182
Author: Shu Chen <shuchen@google.com>
Date: Mon Feb 20 02:08:31 2017

Updates the IME state when necessary when switching top-level windows.

BUG= 679564 , 680524 

Review-Url: https://codereview.chromium.org/2700933002
Cr-Commit-Position: refs/heads/master@{#451460}
(cherry picked from commit 17c78241a37810aff596974cfdec60b01bc0f4c5)

Review-Url: https://codereview.chromium.org/2706723002 .
Cr-Commit-Position: refs/branch-heads/2987@{#591}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}

[modify] https://crrev.com/062cdaa73def7c1e0093db181810aaed74b6d182/ui/base/ime/input_method_win.cc
[modify] https://crrev.com/062cdaa73def7c1e0093db181810aaed74b6d182/ui/base/ime/input_method_win.h

Status: Fixed (was: Started)
Labels: -Hotlist-Merge-Approved
Labels: TE-Verified-57.0.2987.74 TE-Verified-M57
Verified the issue on Win 10 using 57.0.2987.74 and its working fine now.
Please find the scree cast for the same.
679564_Feb_22.mp4
4.2 MB View Download

Comment 21 by may...@gmail.com, Mar 16 2017

I can still reproduce the issue with both of the 57.0.2987.110 and 57.0.2987.98.


Recording #5.mp4
1.2 MB View Download

Sign in to add a comment