Issue metadata
Sign in to add a comment
|
build failure with 'enable_webrtc = false'
Reported by
robrich...@gmail.com,
Jan 10 2017
|
||||||||||||||||||||
Issue descriptionUserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/57.0.2977.0 Safari/537.36 Steps to reproduce the problem: 1. Supply enable_webrtc = false when building Chromium. 2. Build failure during linking. What is the expected behavior? To successfully build without WebRTC enabled. What went wrong? Link error. D:/depot_tools/python276_bin/python.exe ../../build/toolchain/win/tool_wrapper.py link-wrapper environment.x64 False link.exe /nologo /IMPLIB:./chrome.dll.lib /DLL /OUT:./chrome.dll /PDB:./chrome.dll.pdb @./chrome.dll.rsp video_capture_manager.obj : error LNK2019: unresolved external symbol "public: static class std::unique_ptr<class media::VideoCaptureDevice,struct std::default_delete<class media::VideoCaptureDevice> > __cdecl content::DesktopCaptureDevice::Create(struct content::DesktopMediaID const &)" (?Create@DesktopCaptureDevice@content@@SA?AV?$unique_ptr@VVideoCaptureDevice@media@@U?$default_delete@VVideoCaptureDevice@media@@@std@@@std@@AEBUDesktopMediaID@2@@Z) referenced in function "private: class std::unique_ptr<class media::VideoCaptureDevice,struct std::default_delete<class media::VideoCaptureDevice> > __cdecl content::VideoCaptureManager::DoStartDesktopCaptureOnDeviceThread(class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const &,struct media::VideoCaptureParams const &,class std::unique_ptr<class media::VideoCaptureDevice::Client,struct std::default_delete<class media::VideoCaptureDevice::Client> >)" (?DoStartDesktopCaptureOnDeviceThread@VideoCaptureManager@content@@AEAA?AV?$unique_ptr@VVideoCaptureDevice@media@@U?$default_delete@VVideoCaptureDevice@media@@@std@@@std@@AEBV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@4@AEBUVideoCaptureParams@media@@V?$unique_ptr@VClient@VideoCaptureDevice@media@@U?$default_delete@VClient@VideoCaptureDevice@media@@@std@@@4@@Z) video_capture_manager.obj : error LNK2019: unresolved external symbol "public: void __cdecl content::DesktopCaptureDevice::SetNotificationWindowId(__int64)" (?SetNotificationWindowId@DesktopCaptureDevice@content@@QEAAX_J@Z) referenced in function "private: void __cdecl content::VideoCaptureManager::SetDesktopCaptureWindowIdOnDeviceThread(class media::VideoCaptureDevice *,__int64)" (?SetDesktopCaptureWindowIdOnDeviceThread@VideoCaptureManager@content@@AEAAXPEAVVideoCaptureDevice@media@@_J@Z) ./chrome.dll : fatal error LNK1120: 2 unresolved externals Did this work before? Yes Started sometime around or after 57.0.2971.x. Chrome version: 57.0.2977.0 Channel: n/a OS Version: 10.0 Flash Version: not installed Pertinent build arguments leading to linking failure: is_debug = false target_cpu = "x64" enable_webrtc = disable Enabling WebRTC allows the build to successfully complete.
,
Jan 12 2017
Issue appears resolved. Just verified 57.0.2979.0 r443032 builds with WebRTC disabled.
,
Jan 13 2017
as per comment 2, marking this issue as wontfix. Thank you. |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by ajha@chromium.org
, Jan 10 2017Labels: TE-NeedsTriageHelp