New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 679543 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jan 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Add Precache.CacheStatus.Prefetch UMA

Project Member Reported by twif...@chromium.org, Jan 10 2017

Issue description

This would be the complement to the Precache.CacheStatus.NonPrefetch UMA. It helps us to answer oft-asked questions about where the service is providing the most benefit.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5c61d124a2b14a963c7169359a99a9d2e5bdf560

commit 5c61d124a2b14a963c7169359a99a9d2e5bdf560
Author: twifkak <twifkak@chromium.org>
Date: Tue Jan 10 18:34:37 2017

Add Precache.CacheStatus.Prefetch UMA.

This is the complement to the Precache.CacheStatus.NonPrefetch UMA. It
helps us to answer oft-asked questions about where the service is
providing the most benefit.

BUG= 679543 

Review-Url: https://codereview.chromium.org/2628513002
Cr-Commit-Position: refs/heads/master@{#442637}

[modify] https://crrev.com/5c61d124a2b14a963c7169359a99a9d2e5bdf560/components/precache/content/precache_manager_unittest.cc
[modify] https://crrev.com/5c61d124a2b14a963c7169359a99a9d2e5bdf560/components/precache/core/precache_database.cc
[modify] https://crrev.com/5c61d124a2b14a963c7169359a99a9d2e5bdf560/components/precache/core/precache_database_unittest.cc
[modify] https://crrev.com/5c61d124a2b14a963c7169359a99a9d2e5bdf560/tools/metrics/histograms/histograms.xml

Labels: Merge-Request-56
Project Member

Comment 3 by sheriffbot@chromium.org, Jan 11 2017

Labels: -Merge-Request-56 Hotlist-Merge-Approved Merge-Approved-56
Your change meets the bar and is auto-approved for M56. Please go ahead and merge the CL manually. Please contact milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), gkihumba@(cros), bustamante@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 4 by bugdroid1@chromium.org, Jan 11 2017

Labels: -merge-approved-56 merge-merged-2924
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7c546d237095918c4fd62dd84b78a5fdabeb3be1

commit 7c546d237095918c4fd62dd84b78a5fdabeb3be1
Author: Devin Mullins <twifkak@google.com>
Date: Wed Jan 11 20:46:45 2017

Add Precache.CacheStatus.Prefetch UMA.

This is the complement to the Precache.CacheStatus.NonPrefetch UMA. It
helps us to answer oft-asked questions about where the service is
providing the most benefit.

BUG= 679543 

Review-Url: https://codereview.chromium.org/2628513002
Cr-Commit-Position: refs/heads/master@{#442637}
(cherry picked from commit 5c61d124a2b14a963c7169359a99a9d2e5bdf560)

Review-Url: https://codereview.chromium.org/2621413004 .
Cr-Commit-Position: refs/branch-heads/2924@{#735}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}

[modify] https://crrev.com/7c546d237095918c4fd62dd84b78a5fdabeb3be1/components/precache/content/precache_manager_unittest.cc
[modify] https://crrev.com/7c546d237095918c4fd62dd84b78a5fdabeb3be1/components/precache/core/precache_database.cc
[modify] https://crrev.com/7c546d237095918c4fd62dd84b78a5fdabeb3be1/components/precache/core/precache_database_unittest.cc
[modify] https://crrev.com/7c546d237095918c4fd62dd84b78a5fdabeb3be1/tools/metrics/histograms/histograms.xml

Status: Fixed (was: Started)

Sign in to add a comment