Android page info doesn't have Learn More link on http-bad page |
|||||||
Issue descriptionChrome Version: 57.0.2974.0 OS: Android What steps will reproduce the problem? (1) Visit http://rsolomakhin.github.io/autofill (2) Tap the (i) in the omnibox. What is the expected result? A "Learn More" link as on desktop pointing to https://support.google.com/chrome/answer/95617?visit_id=0-636196033758434745-3289202962&p=ui_security_indicator&rd=1 What happens instead? No "Learn More" link (see screenshot)
,
Jan 10 2017
Thanks for reporting! Personally I think since the warning is so small, it's okay to not merge at this point. However, we should have it for 57, especially since with Form Not Secure there will be more attention on our warning on Android (though there is a link to HC in the form UI, so that's an argument it's less important)
,
Jan 10 2017
Also, note that the link still exists in connection details for HTTPS pages. But I just realized that https://codereview.chromium.org/2624653002 will change that string for Android as well as iOS. Is that okay?
,
Jan 10 2017
I'm confused. Are you saying: (1) On Android, LEARN MORE exists for HTTPS but not HTTP (2) After your CL LEARN MORE will not exist for HTTPS on either Android or iOS
,
Jan 10 2017
(1)-ish. Learn more exists, but in the old place: as part of the connection details (which matched the desktop connection tab), using the old "What does this mean?" string, and not available from HTTP pages. My CL would have kept it in the same place, but changed the string to "Learn More". In any case, I've abandoned the CL to move the relevant strings to the proper place instead.
,
Nov 10 2017
,
Feb 18 2018
,
Jun 13 2018
We should try to get this link added to the main Page Info dialog in M70 when the HTTP-Bad icon will get more aggressive.
,
Oct 16
,
Oct 17
,
Oct 22
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/20d89220f3cc7d383f15057e258ab0f179f156e4 commit 20d89220f3cc7d383f15057e258ab0f179f156e4 Author: Joe DeBlasio <jdeblasio@chromium.org> Date: Mon Oct 22 22:15:08 2018 Add 'Details' link to page info box for HTTP sites on Android. The 'Details' link in the page info box was previously only shown for HTTPS pages. This CL provides this link for http-bad pages to help provide additional context for why HTTP is bad. Bug: 679532 Change-Id: I7f5af068d49c52df2519c2eff3f7cd87a24aa502 Reviewed-on: https://chromium-review.googlesource.com/c/1286895 Reviewed-by: Ted Choc <tedchoc@chromium.org> Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> Cr-Commit-Position: refs/heads/master@{#601748} [modify] https://crrev.com/20d89220f3cc7d383f15057e258ab0f179f156e4/chrome/android/java/src/org/chromium/chrome/browser/page_info/PageInfoController.java
,
Oct 22
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by est...@chromium.org
, Jan 10 2017