New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 679523 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: May 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: ----

Blocked on:
issue 684162
issue 684929
issue 684937

Blocking:
issue 539779



Sign in to add a comment

Enable DirectX capturer in CRD

Project Member Reported by zijiehe@chromium.org, Jan 9 2017

Issue description

This is a work item to track changes to enable DirectX capturer in CRD.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/58de2fd49950cbad65f5d1429e111cd6ea28f795

commit 58de2fd49950cbad65f5d1429e111cd6ea28f795
Author: zijiehe <zijiehe@chromium.org>
Date: Tue Jan 10 02:41:08 2017

[Chromoting] Enable DirectX capturer

A simple and straightforward change to enable DirectX capturer by default in
CRD.

BUG= 679523 

Review-Url: https://codereview.chromium.org/2628473002
Cr-Commit-Position: refs/heads/master@{#442454}

[modify] https://crrev.com/58de2fd49950cbad65f5d1429e111cd6ea28f795/remoting/host/desktop_environment_options.cc

Owner: ajnolley@chromium.org
Status: Fixed (was: Assigned)
DirectX capturer has been enabled by the change above in CRD.
AJ, feel free to talk to me about the detail.

Comment 3 Deleted

Blockedon: 685258 684929 663073
Blockedon: -685258 684937
Blockedon: -663073 684162

Comment 7 by joedow@chromium.org, Jan 27 2017

Labels: -M-57 M-58
Project Member

Comment 8 by bugdroid1@chromium.org, Mar 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f478d76ee3acd92b6a2cf5ff2e5a0e4094c756db

commit f478d76ee3acd92b6a2cf5ff2e5a0e4094c756db
Author: zijiehe <zijiehe@chromium.org>
Date: Sat Mar 25 02:23:53 2017

[Chromoting] Send DesktopFrame::capturer_id() to client through WebrtcVideoStream

Once DirectX Capturer is enabled or being experimented, we can use the
capturer_id() logged in clients to analyze the failure rate.

BUG=650926,  679523 

Review-Url: https://codereview.chromium.org/2767193007
Cr-Commit-Position: refs/heads/master@{#459625}

[modify] https://crrev.com/f478d76ee3acd92b6a2cf5ff2e5a0e4094c756db/remoting/proto/video_stats.proto
[modify] https://crrev.com/f478d76ee3acd92b6a2cf5ff2e5a0e4094c756db/remoting/protocol/frame_stats.cc
[modify] https://crrev.com/f478d76ee3acd92b6a2cf5ff2e5a0e4094c756db/remoting/protocol/frame_stats.h
[modify] https://crrev.com/f478d76ee3acd92b6a2cf5ff2e5a0e4094c756db/remoting/protocol/webrtc_video_stream.cc
[modify] https://crrev.com/f478d76ee3acd92b6a2cf5ff2e5a0e4094c756db/remoting/protocol/webrtc_video_stream.h

Project Member

Comment 9 by bugdroid1@chromium.org, Mar 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d019ead71fc0056f622b6955e4ea599d43231e32

commit d019ead71fc0056f622b6955e4ea599d43231e32
Author: thakis <thakis@chromium.org>
Date: Sun Mar 26 01:33:28 2017

Revert of [Chromoting] Send DesktopFrame::capturer_id() to client through WebrtcVideoStream (patchset #2 id:40001 of https://codereview.chromium.org/2767193007/ )

Reason for revert:
Speculative, looks like this broke Webrtc_ConnectionTest.SecondCaptureFailed_0 on msan: https://build.chromium.org/p/chromium.memory.full/builders/Linux%20MSan%20Tests/builds/6646

Original issue's description:
> [Chromoting] Send DesktopFrame::capturer_id() to client through WebrtcVideoStream
>
> Once DirectX Capturer is enabled or being experimented, we can use the
> capturer_id() logged in clients to analyze the failure rate.
>
> BUG=650926,  679523 
>
> Review-Url: https://codereview.chromium.org/2767193007
> Cr-Commit-Position: refs/heads/master@{#459625}
> Committed: https://chromium.googlesource.com/chromium/src/+/f478d76ee3acd92b6a2cf5ff2e5a0e4094c756db

TBR=sergeyu@chromium.org,zijiehe@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=650926,  679523 

Review-Url: https://codereview.chromium.org/2779483002
Cr-Commit-Position: refs/heads/master@{#459665}

[modify] https://crrev.com/d019ead71fc0056f622b6955e4ea599d43231e32/remoting/proto/video_stats.proto
[modify] https://crrev.com/d019ead71fc0056f622b6955e4ea599d43231e32/remoting/protocol/frame_stats.cc
[modify] https://crrev.com/d019ead71fc0056f622b6955e4ea599d43231e32/remoting/protocol/frame_stats.h
[modify] https://crrev.com/d019ead71fc0056f622b6955e4ea599d43231e32/remoting/protocol/webrtc_video_stream.cc
[modify] https://crrev.com/d019ead71fc0056f622b6955e4ea599d43231e32/remoting/protocol/webrtc_video_stream.h

Project Member

Comment 10 by bugdroid1@chromium.org, Mar 27 2017

Project Member

Comment 11 by bugdroid1@chromium.org, Apr 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/external/webrtc.git/+/403267434950154c2c1bdaa53ab33ff622f0b91c

commit 403267434950154c2c1bdaa53ab33ff622f0b91c
Author: zijiehe <zijiehe@chromium.org>
Date: Fri Apr 28 01:39:01 2017

Forward capturer_id between DesktopFrame and its implementations

This is a trivial change to forward capturer id from various DesktopFrame
related implementations.

BUG= chromium:679523 , chromium:650926

Review-Url: https://codereview.webrtc.org/2851513003
Cr-Commit-Position: refs/heads/master@{#17918}

[modify] https://crrev.com/403267434950154c2c1bdaa53ab33ff622f0b91c/webrtc/modules/desktop_capture/desktop_and_cursor_composer.cc
[modify] https://crrev.com/403267434950154c2c1bdaa53ab33ff622f0b91c/webrtc/modules/desktop_capture/desktop_capturer_differ_wrapper.cc
[modify] https://crrev.com/403267434950154c2c1bdaa53ab33ff622f0b91c/webrtc/modules/desktop_capture/desktop_frame.cc

Project Member

Comment 12 by bugdroid1@chromium.org, Apr 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a1336afb916a5ea783cf76454f8804ac12709624

commit a1336afb916a5ea783cf76454f8804ac12709624
Author: zijiehe <zijiehe@chromium.org>
Date: Fri Apr 28 05:29:28 2017

Forward capturer id from desktop process to network process

Updates of message, proxy and agent are needed to forward capturer id to the
network process and eventually to the client.

BUG= chromium:679523 , chromium:650926

Review-Url: https://codereview.chromium.org/2848753002
Cr-Commit-Position: refs/heads/master@{#467902}

[modify] https://crrev.com/a1336afb916a5ea783cf76454f8804ac12709624/remoting/host/chromoting_messages.h
[modify] https://crrev.com/a1336afb916a5ea783cf76454f8804ac12709624/remoting/host/desktop_session_agent.cc
[modify] https://crrev.com/a1336afb916a5ea783cf76454f8804ac12709624/remoting/host/desktop_session_proxy.cc

Project Member

Comment 13 by bugdroid1@chromium.org, May 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7240a3c1412ec22c8931b1e5b3359f1bc2aafb32

commit 7240a3c1412ec22c8931b1e5b3359f1bc2aafb32
Author: zijiehe <zijiehe@chromium.org>
Date: Thu May 25 19:23:56 2017

[Chromoting] Enable DirectX capturer for Windows hosts

BUG= 679523 

Review-Url: https://codereview.chromium.org/2908563002
Cr-Commit-Position: refs/heads/master@{#474750}

[modify] https://crrev.com/7240a3c1412ec22c8931b1e5b3359f1bc2aafb32/remoting/host/desktop_environment_options.cc

Owner: ajnolley@chromium.org
Status: Fixed (was: Assigned)
Status: Verified (was: Fixed)

Sign in to add a comment