'Stop casting' item in the overflow media controls is confusing |
||||||
Issue descriptionThe way it sounds, it should immediately stop casting the video. However, it shows the controller dialog instead where user can stop casting or change volume and so on. Not sure what the ideal wording would be or if we should just stop casting in this case - would be inconsistent with the cast button in the controls bar though which doesn't have words next to it so the user would expect the cast dialog to show the same way it works in other Android apps. Maybe just leave it as 'Cast' (don't know what the policy on ... is now, it used to be an indicator of showing some UI vs just doing something).
,
Nov 15 2017
+Amy Thanks Anton! Would you be able to provide screenshots for us? I agree that my expectation was that the 'stop casting' button would immediately stop the cast, though I also admit that we didn't deep dive into this piece (and kept the existing behavior without realizing that it was different than expected).
,
Nov 15 2017
My understanding is that the new media controls will not show "Stop Casting" but just "Cast" which would address this issue, right?
,
Nov 15 2017
Yes I think that is the case
,
Nov 15 2017
,
Nov 15 2017
Er - I'm not entirely sure. Amy - would you have a chance to touch base with Becca today or tomorrow?
,
Nov 15 2017
comment 3 and 4 sound right, the new media controls should solve for this confusion. https://docs.google.com/presentation/d/1wso086QMuxxSyIJPuuv2T5aJOn3Mlwo4c9KhfAdMdGw/edit#slide=id.g2a8e363ddd_1_0
,
Nov 16 2017
KK :)
,
Jan 2 2018
,
Jan 2 2018
,
Jan 5 2018
,
Jan 5 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/243b47e97b8ebef9ae3b32bf29ddb1664a6714de commit 243b47e97b8ebef9ae3b32bf29ddb1664a6714de Author: Becca Hughes <beccahughes@chromium.org> Date: Fri Jan 05 16:08:21 2018 Media Controls: Rename "stop casting" to "cast" Rename "stop casting" to "cast" in line with the spec for the new media controls. On the old controls, show cast instead of "stop casting" because we show a settings dialog instead of actually stopping casting. BUG= 679520 Change-Id: Ie6857fd710d412f166cfa2ae49e1490918791c69 Reviewed-on: https://chromium-review.googlesource.com/846881 Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by: Jochen Eisinger <jochen@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#527286} [modify] https://crrev.com/243b47e97b8ebef9ae3b32bf29ddb1664a6714de/content/app/strings/content_strings.grd [modify] https://crrev.com/243b47e97b8ebef9ae3b32bf29ddb1664a6714de/content/child/blink_platform_impl.cc [modify] https://crrev.com/243b47e97b8ebef9ae3b32bf29ddb1664a6714de/third_party/WebKit/Source/modules/media_controls/elements/MediaControlCastButtonElement.cpp [modify] https://crrev.com/243b47e97b8ebef9ae3b32bf29ddb1664a6714de/third_party/WebKit/public/platform/WebLocalizedString.h
,
Jan 5 2018
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by lethalantidote@chromium.org
, Nov 15 2017