Issue metadata
Sign in to add a comment
|
Numerous failures on perf waterfall |
||||||||||||||||||||
Issue descriptionhttps://build.chromium.org/p/chromium.perf/builders/Android%20Nexus5%20Perf%20%281%29 https://build.chromium.org/p/chromium.perf/builders/Android%20Nexus5%20Perf%20%283%29 https://build.chromium.org/p/chromium.perf/builders/Android%20Nexus6%20Perf%20%281%29 https://build.chromium.org/p/chromium.perf/builders/Android%20Nexus6%20Perf%20%283%29 https://build.chromium.org/p/chromium.perf/builders/Android%20Nexus7v2%20Perf%20%283%29 https://build.chromium.org/p/chromium.perf/builders/Android%20One%20Perf%20%281%29 https://build.chromium.org/p/chromium.perf/builders/Android%20Nexus6%20WebView%20Perf%20%283%29 https://build.chromium.org/p/chromium.perf/builders/Android%20Nexus9%20Perf%20%283%29 https://build.chromium.org/p/chromium.perf/builders/Android%20Nexus5X%20Perf%20%281%29 https://build.chromium.org/p/chromium.perf/builders/Android%20Nexus5X%20Perf%20%283%29 https://build.chromium.org/p/chromium.perf/builders/Android%20Nexus5X%20WebView%20Perf%20%281%29 https://build.chromium.org/p/chromium.perf/builders/Android%20Nexus5X%20WebView%20Perf%20%283%29 Traceback (most recent call last): File "/b/rr/tmpSYSk3T/w/src/third_party/catapult/telemetry/telemetry/internal/story_runner.py", line 94, in _RunStoryAndProcessErrorIfNeeded state.RunStory(results) File "/b/rr/tmpSYSk3T/w/src/third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py", line 75, in traced_function return func(*args, **kwargs) File "/b/rr/tmpSYSk3T/w/src/third_party/catapult/telemetry/telemetry/page/shared_page_state.py", line 298, in RunStory self._PreparePage() File "/b/rr/tmpSYSk3T/w/src/third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py", line 75, in traced_function return func(*args, **kwargs) File "/b/rr/tmpSYSk3T/w/src/third_party/catapult/telemetry/telemetry/page/shared_page_state.py", line 278, in _PreparePage 'Login as ' + self._current_page.credentials + ' failed') Failure: Login as google failed INFO:root:Chrome version: 2977 INFO:devil.utils.cmd_helper:[host]> /b/rr/tmpSYSk3T/w/src/third_party/catapult/devil/bin/deps/linux2/x86_64/bin/adb -s 03852c29003b9cb6 shell '( rm -f /data/local/chrome-trace-config.json );echo %$?' INFO:devil.utils.cmd_helper:[host]> /b/rr/tmpSYSk3T/w/src/third_party/catapult/devil/bin/deps/linux2/x86_64/bin/adb -s 03852c29003b9cb6 shell '( log -p i -t Telemetry '"'"'END http://www.youtube.com'"'"' );echo %$?' [ FAILED ] http://www.youtube.com (102163 ms)
,
Jan 10 2017
Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/8990894244363348736
,
Jan 10 2017
=== Auto-CCing suspected CL author perezju@chromium.org === Hi perezju@chromium.org, the bisect results pointed to your CL, please take a look at the results. === BISECT JOB RESULTS === Test failure found with culprit Suspected Commit Author : perezju Commit : 9c4a543d55a4afcab403f792785fae964586978c Date : Mon Jan 09 14:12:31 2017 Subject: [Telemetry] Allow value interpolation in action_runner JavaScript API Bisect Details Configuration: android_nexus5X_perf_bisect Benchmark : tracing.tracing_with_debug_overhead Metric : Max event size in bytes per second_avg/Max event size in bytes per second_avg Revision Exit Code N chromium@442230 0 +- N/A 5 good chromium@442241 0 +- N/A 5 good chromium@442246 0 +- N/A 5 good chromium@442249 0 +- N/A 5 good chromium@442250 0 +- N/A 5 good chromium@442250,catapult@9c4a543d55 1 +- N/A 5 bad <-- chromium@442251 1 +- N/A 5 bad chromium@442271 1 +- N/A 5 bad chromium@442311 1 +- N/A 5 bad To Run This Test src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests tracing.tracing_with_debug_overhead Debug Info https://chromeperf.appspot.com/buildbucket_job_status/8990894244363348736 Is this bisect wrong? https://chromeperf.appspot.com/bad_bisect?try_job_id=5807947910742016 | O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq | X | for more information addressing perf regression bugs. For feedback, | / \ | file a bug with component Tests>AutoBisect. Thank you!
,
Jan 10 2017
I'll try to see if there is a quick fix. Otherwise I'll revert my CL.
,
Jan 10 2017
got fix, uploading CL ...
,
Jan 10 2017
Now in CQ: https://codereview.chromium.org/2625653002/
,
Jan 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/149f53e13220adcbdf02bc8126840f0677a49050 commit 149f53e13220adcbdf02bc8126840f0677a49050 Author: catapult-deps-roller <catapult-deps-roller@chromium.org> Date: Tue Jan 10 13:10:28 2017 Roll src/third_party/catapult/ 0c217fe87..f1ec9eb8c (1 commit). https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/0c217fe8765c..f1ec9eb8cd15 $ git log 0c217fe87..f1ec9eb8c --date=short --no-merges --format='%ad %ae %s' 2017-01-10 perezju [telemetry] Fix bug in form_based_credentials_backend BUG= 679518 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=catapult-sheriff@chromium.org Review-Url: https://codereview.chromium.org/2619823004 Cr-Commit-Position: refs/heads/master@{#442565} [modify] https://crrev.com/149f53e13220adcbdf02bc8126840f0677a49050/DEPS
,
Jan 10 2017
Changing title to reflect that lots of other bots are coming in now with similar failures.
,
Jan 10 2017
Can you point to a recent failure? These should have been fixed on recent builds.
,
Jan 10 2017
https://build.chromium.org/p/chromium.perf/builders/Linux%20Perf/builds/231 Your fix is queued, will probably run in the next few hours.
,
Jan 10 2017
Ok. Hopefully it should turn green after my fix rolls. It did work e.g. here: https://build.chromium.org/p/chromium.perf/builders/Android%20Nexus5%20Perf%20%281%29/builds/5056/steps/tracing.tracing_with_background_memory_infra I'm leaving for home now. If you see persisting failures go ahead and revert 9c4a543d55a4afcab403f792785fae964586978c. It's probably not a clean revert now (because of the fix), but resolving the conflict should be straightforward.
,
Jan 10 2017
Awesome, thanks for jumping on this so quickly! I'll keep an eye out :)
,
Jan 11 2017
Not sure if it's only on my end, but I have been having problems accessing https://build.chromium.org/p/chromium.perf/console -- any idea if the problems were all fixed? I'm hoping to land a new CL that depends on the CL in #3, and will complicate matters if we need to revert that one.
,
Jan 11 2017
Ok, had a look through https://luci-milo.appspot.com/buildbot/chromium.perf/Linux%20Perf/233 (after the fix in #7 landed) There are a few failures, but none seem to be related to my changes. Considering this fixed, but let me know if you think otherwise. |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by simonhatch@chromium.org
, Jan 9 2017