New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 679517 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature



Sign in to add a comment

[sync] Handle local changes in AutocompleteSyncBridge

Project Member Reported by pnoland@chromium.org, Jan 9 2017

Issue description

Implement AutofillEntriesChanged to listen for local changes to the autofill db. Propagate these changes to the processor, and write associated tests. 
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1e4b08621e36a68cc141e04b50a55f1a09cec9ce

commit 1e4b08621e36a68cc141e04b50a55f1a09cec9ce
Author: pnoland <pnoland@chromium.org>
Date: Thu Jan 19 20:51:08 2017

[sync] Handle local changes in AutocompleteSyncBridge

Implement AutofillEntriesChanged to listen for local autofill changes.
Add logic that propagates these changes to the processor.
Extract RecordingModelTypeChangeProcessor for general use.

R=pavely@chromium.org,maxbogue@chromium.org,mathp@chromium.org,pkasting@chromium.org

BUG= 679517 

Review-Url: https://codereview.chromium.org/2620783002
Cr-Commit-Position: refs/heads/master@{#444840}

[modify] https://crrev.com/1e4b08621e36a68cc141e04b50a55f1a09cec9ce/components/autofill/core/browser/webdata/autocomplete_sync_bridge.cc
[modify] https://crrev.com/1e4b08621e36a68cc141e04b50a55f1a09cec9ce/components/autofill/core/browser/webdata/autocomplete_sync_bridge.h
[modify] https://crrev.com/1e4b08621e36a68cc141e04b50a55f1a09cec9ce/components/autofill/core/browser/webdata/autocomplete_sync_bridge_unittest.cc
[modify] https://crrev.com/1e4b08621e36a68cc141e04b50a55f1a09cec9ce/components/sync/BUILD.gn
[modify] https://crrev.com/1e4b08621e36a68cc141e04b50a55f1a09cec9ce/components/sync/device_info/device_info_sync_bridge_unittest.cc
[add] https://crrev.com/1e4b08621e36a68cc141e04b50a55f1a09cec9ce/components/sync/model/recording_model_type_change_processor.cc
[add] https://crrev.com/1e4b08621e36a68cc141e04b50a55f1a09cec9ce/components/sync/model/recording_model_type_change_processor.h

Comment 2 by treib@chromium.org, May 28 2018

Components: Services>Sync
Owner: pnoland@chromium.org
Status: Fixed (was: Started)
I think this has been done for a long time

Sign in to add a comment