We should integrate histograms.xml & actions.xml formatters into "git cl format" |
||
Issue descriptionWe should integrate histograms.xml & actions.xml formatters into "git cl format". Chatting with Nico, he's supportive of this and it makes sense to have "git cl format" just do the right thing. One difference is that "git cl format" only formats lines that are changed - but that's not the case for the metrics XML file formatters. However, given that these files are kept format-clean by presubmit, this shouldn't be a problem in practice.
,
Feb 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/02441ca994699e2ce6fe29247a4f97970899c721 commit 02441ca994699e2ce6fe29247a4f97970899c721 Author: asvitkine <asvitkine@chromium.org> Date: Mon Feb 06 17:45:20 2017 Make metrics pretty_print.py scripts runnable from git cl format. Adds some additional command-line params to metrics (histograms, actions, rappor) pretty_print.py scripts that format XML files so that they can be invoked by 'git cl format'. This will allow (in a follow-up CL to depot tools) to have git cl format invoke these scripts automatically when ran. BUG= 679514 Review-Url: https://codereview.chromium.org/2674283002 Cr-Commit-Position: refs/heads/master@{#448292} [modify] https://crrev.com/02441ca994699e2ce6fe29247a4f97970899c721/tools/metrics/common/presubmit_util.py
,
Feb 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/depot_tools/+/f3cac415469335979e16a13273b50239400fd1a6 commit f3cac415469335979e16a13273b50239400fd1a6 Author: Alexei Svitkine <asvitkine@chromium.org> Date: Wed Feb 15 21:53:23 2017 Integrate metrics XML file pretty print into git cl format. Depends on: https://codereview.chromium.org/2674283002/ BUG= 679514 Change-Id: I61611fc19724028bb8cdefefc50b4d5d3bb77a46 Reviewed-on: https://chromium-review.googlesource.com/437919 Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by: Robbie Iannucci <iannucci@chromium.org> [modify] https://crrev.com/f3cac415469335979e16a13273b50239400fd1a6/git_cl.py
,
Feb 16 2017
Should be working now!
,
Mar 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/depot_tools/+/d5bc73d467eda7d9f12681d3b428799411b93a8d commit d5bc73d467eda7d9f12681d3b428799411b93a8d Author: Pierre-Antoine Manzagol <manzagop@chromium.org> Date: Mon Mar 27 01:14:24 2017 Fix 'git cl format' on windows metrics files The issue is with directory separators: "Check that c:\src\chromium\src or c:\src\chromium\src\tools/metrics/histograms/pretty_print.py exist and have execution permission." BUG= 679514 Change-Id: I88a57783ca3bf8aa5af4d83fb34901c2d2385fe9 Reviewed-on: https://chromium-review.googlesource.com/457800 Reviewed-by: Robbie Iannucci <iannucci@chromium.org> Commit-Queue: Pierre-Antoine Manzagol <manzagop@chromium.org> [modify] https://crrev.com/d5bc73d467eda7d9f12681d3b428799411b93a8d/git_cl.py |
||
►
Sign in to add a comment |
||
Comment 1 by asvitk...@chromium.org
, Feb 6 2017Status: Started (was: Available)